[DISCUSS] Cleanup needed for RESOLVED-FIXED issues

classic Classic list List threaded Threaded
6 messages Options
Reply | Threaded
Open this post in threaded view
|

[DISCUSS] Cleanup needed for RESOLVED-FIXED issues

Kay Schenk-2
I think typically the process for RESOLVED-FIXED (those
issues that were fixed by some kind of code change to
/trunk) issues is to:

* commit the change to a release build
* once the release build is out for testing, check that the
bug is fixed, and use RESOLVED-VERFIED, to verify the fix, then
* CLOSE the issue

Recently, when I was looking at some issues that we'd
targeted for 4.1.2, I came upon a number that had been
RESOLVED-FIXED, but some had been committed to a release and
some had not. For those that had, I skipped the
RESOLVED-VERIFIED step and just closed them.

Currently, I feel we could use some additional help with
a) closing out old issues that have been ported to a
release, and
b) resetting the Target Release information for those issues
that have been fixed but have not been "released".

The following query only looks at RESOLVED-FIXED issues
since 2011-01-01

https://bz.apache.org/ooo/buglist.cgi?bug_status=RESOLVED&chfield=resolution&chfieldfrom=2011-01-01&chfieldto=Now&chfieldvalue=Fixed&limit=0&order=priority%2Cbug_severity&query_format=advanced&resolution=FIXED&resolution=FIXED_WITHOUT_CODE

A warning -- unless you can see an SVN commit clearly
stating that the fix has been ported to one of our existing
releases, it may take a bit of investigation into the
release branch area to determine this.

release branch area--
http://svn.apache.org/viewvc/openoffice/branches/


Our new resolution of FIXED_WITHOUT_CODE should result in
CLOSING without any further investigation.

Thoughts on undertaking this cleanup?
--
--------------------------------------------
MzK

"Time spent with cats is never wasted."
                   -- Sigmund Freud

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [DISCUSS] Cleanup needed for RESOLVED-FIXED issues

Marcus (OOo)
Am 04/07/2016 12:43 AM, schrieb Kay Schenk:

> I think typically the process for RESOLVED-FIXED (those
> issues that were fixed by some kind of code change to
> /trunk) issues is to:
>
> * commit the change to a release build
> * once the release build is out for testing, check that the
> bug is fixed, and use RESOLVED-VERFIED, to verify the fix, then
> * CLOSE the issue
>
> Recently, when I was looking at some issues that we'd
> targeted for 4.1.2, I came upon a number that had been
> RESOLVED-FIXED, but some had been committed to a release and
> some had not. For those that had, I skipped the
> RESOLVED-VERIFIED step and just closed them.
>
> Currently, I feel we could use some additional help with
> a) closing out old issues that have been ported to a
> release, and
> b) resetting the Target Release information for those issues
> that have been fixed but have not been "released".
>
> The following query only looks at RESOLVED-FIXED issues
> since 2011-01-01
>
> https://bz.apache.org/ooo/buglist.cgi?bug_status=RESOLVED&chfield=resolution&chfieldfrom=2011-01-01&chfieldto=Now&chfieldvalue=Fixed&limit=0&order=priority%2Cbug_severity&query_format=advanced&resolution=FIXED&resolution=FIXED_WITHOUT_CODE
>
> A warning -- unless you can see an SVN commit clearly
> stating that the fix has been ported to one of our existing
> releases, it may take a bit of investigation into the
> release branch area to determine this.
>
> release branch area--
> http://svn.apache.org/viewvc/openoffice/branches/
>
>
> Our new resolution of FIXED_WITHOUT_CODE should result in
> CLOSING without any further investigation.
>
> Thoughts on undertaking this cleanup?

I've closed all listed issues regarding our infrastructure (Website,
Bugzilla, etc.). As you can see every single change results in a mail
and will fill everybody's inbox - when you are subscribed to the issues@
mailing list.

There will be the possibility to disable mails when performing special
actions (e.g., bulk issue changes) but not before release 6.0 [1]. At
the moment we are at 5.0.2. So, it will take some more time. ;-(

For the time being we have only the way do disable completely sending
mails when we work on the issue. But this means that *absolutely no
mails will be sent* regardless what was done (new issue, change,
comments, closing, etc.).

[1] https://bugzilla.mozilla.org/show_bug.cgi?id=1062718

Sorry for the spam. ;-)

Marcus

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [DISCUSS] Cleanup needed for RESOLVED-FIXED issues

Carl Marcum
In reply to this post by Kay Schenk-2
On 04/06/2016 06:43 PM, Kay Schenk wrote:

> I think typically the process for RESOLVED-FIXED (those
> issues that were fixed by some kind of code change to
> /trunk) issues is to:
>
> * commit the change to a release build
> * once the release build is out for testing, check that the
> bug is fixed, and use RESOLVED-VERFIED, to verify the fix, then
> * CLOSE the issue
>
> Recently, when I was looking at some issues that we'd
> targeted for 4.1.2, I came upon a number that had been
> RESOLVED-FIXED, but some had been committed to a release and
> some had not. For those that had, I skipped the
> RESOLVED-VERIFIED step and just closed them.
>
> Currently, I feel we could use some additional help with
> a) closing out old issues that have been ported to a
> release, and
> b) resetting the Target Release information for those issues
> that have been fixed but have not been "released".
>
> The following query only looks at RESOLVED-FIXED issues
> since 2011-01-01
>
> https://bz.apache.org/ooo/buglist.cgi?bug_status=RESOLVED&chfield=resolution&chfieldfrom=2011-01-01&chfieldto=Now&chfieldvalue=Fixed&limit=0&order=priority%2Cbug_severity&query_format=advanced&resolution=FIXED&resolution=FIXED_WITHOUT_CODE
>
> A warning -- unless you can see an SVN commit clearly
> stating that the fix has been ported to one of our existing
> releases, it may take a bit of investigation into the
> release branch area to determine this.
>
> release branch area--
> http://svn.apache.org/viewvc/openoffice/branches/
>
>
> Our new resolution of FIXED_WITHOUT_CODE should result in
> CLOSING without any further investigation.
>
> Thoughts on undertaking this cleanup?
Off topic...

I started going through some of the NetBeans related issues last evening.

Most are very old. In some cases I found the proposed code changes had
been made but I couldn't tell when because it was prior to the Apache
migration.

I RESOLVED-OBSOLETE very old ones I could not verify and RESOLVED-FIXED
ones I could.

Thanks,
Carl


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [DISCUSS] Cleanup needed for RESOLVED-FIXED issues

Kay Schenk-2
In reply to this post by Marcus (OOo)
On Thu, Apr 7, 2016 at 3:58 PM, Kay Schenk <[hidden email]> wrote:

>
> On Thu, Apr 7, 2016 at 9:59 AM, Marcus <[hidden email]> wrote:
>
>> Am 04/07/2016 06:35 PM, schrieb Dennis E. Hamilton:
>>
>>> My only concern is that this is a giant CTR and pretty much assures that
>>> the "R" will not happen.
>>>
>>
>> yes, but especially with old issues I don't see a big problem here. Maybe
>> for single issues. But IMHO this is no argument to keep every issue open
>> and inspect them in all details. Then it's better to reopen some of them.
>>
>
> ​Ok, perhaps some misunderstanding here. What I'm asking for is assistance
> is finding the RESOLVED-FIXED issues that actually were incorporated in a
> release, and CLOSE them.
>
>
> ​Some of them even have comments that the issue was checked against a
> release, but they were not CLOSEd.​ I am NOT requesting that RESOLVED-FIXED
> issues that did not make it to a release be closed. This would be
> premature. Sorry for the misunderstanding.
>
>
>> When it's "RESOLVED - FIXED", then I trust the status somehow and will
>> only do some checks. But I don't put the resolution "FIXED" into doubt and
>> do everything again that is listed in the issue.
>>
>> So be it.
>>>
>>> However, do not disable the issues mails for any reason.  There is a
>>> difference between R not happening and R not being possible.
>>>
>>
>> That's right.
>>
>
> ​The search I referenced in the first post has more than 1500 issues in
> the RESOLVED-FIXED category. ​
>
> ​ Of these, some percentage should be CLOSEd. And yes, it's a bit of an
> annoyance to get the emails, but I think it's worth it to keep better
> records.
> ​
>
>>
>> Marcus
>
>
​A great big THANK YOU for the work done on this cleanup business so far.

SUPER!!!!!



>
>>
>>
>>
>> -----Original Message-----
>>>> From: Marcus [mailto:[hidden email]]
>>>> Sent: Thursday, April 7, 2016 02:10
>>>> To: [hidden email]
>>>> Cc: [hidden email]
>>>> Subject: Re: [DISCUSS] Cleanup needed for RESOLVED-FIXED issues
>>>>
>>>> [ ... ]
>>>
>>>> I've closed all listed issues regarding our infrastructure (Website,
>>>> Bugzilla, etc.). As you can see every single change results in a mail
>>>> and will fill everybody's inbox - when you are subscribed to the issues@
>>>> mailing list.
>>>>
>>>> There will be the possibility to disable mails when performing special
>>>> actions (e.g., bulk issue changes) but not before release 6.0 [1]. At
>>>> the moment we are at 5.0.2. So, it will take some more time. ;-(
>>>>
>>>> For the time being we have only the way do disable completely sending
>>>> mails when we work on the issue. But this means that *absolutely no
>>>> mails will be sent* regardless what was done (new issue, change,
>>>> comments, closing, etc.).
>>>>
>>>> [1] https://bugzilla.mozilla.org/show_bug.cgi?id=1062718
>>>>
>>>> Sorry for the spam. ;-)
>>>>
>>>> Marcus
>>>>
>>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: [hidden email]
>> For additional commands, e-mail: [hidden email]
>>
>>
>
>
> --
> ----------------------------------------------------------------------
> MzK
>
> "Time spent with cats is never wasted."
>                                 -- Sigmund Freud
>
>


--
----------------------------------------------------------------------
MzK

"Time spent with cats is never wasted."
                                -- Sigmund Freud
Reply | Threaded
Open this post in threaded view
|

Re: [DISCUSS] Cleanup needed for RESOLVED-FIXED issues

Marcus (OOo)
Am 04/08/2016 07:04 PM, schrieb Kay Schenk:

> On Thu, Apr 7, 2016 at 3:58 PM, Kay Schenk<[hidden email]>  wrote:
>>
>> On Thu, Apr 7, 2016 at 9:59 AM, Marcus<[hidden email]>  wrote:
>>
>>> Am 04/07/2016 06:35 PM, schrieb Dennis E. Hamilton:
>>>
>>>> My only concern is that this is a giant CTR and pretty much assures that
>>>> the "R" will not happen.
>>>>
>>>
>>> yes, but especially with old issues I don't see a big problem here. Maybe
>>> for single issues. But IMHO this is no argument to keep every issue open
>>> and inspect them in all details. Then it's better to reopen some of them.
>>>
>>
>> ​Ok, perhaps some misunderstanding here. What I'm asking for is assistance
>> is finding the RESOLVED-FIXED issues that actually were incorporated in a
>> release, and CLOSE them.
>>
>>
>> ​Some of them even have comments that the issue was checked against a
>> release, but they were not CLOSEd.​ I am NOT requesting that RESOLVED-FIXED
>> issues that did not make it to a release be closed. This would be
>> premature. Sorry for the misunderstanding.
>>
>>
>>> When it's "RESOLVED - FIXED", then I trust the status somehow and will
>>> only do some checks. But I don't put the resolution "FIXED" into doubt and
>>> do everything again that is listed in the issue.
>>>
>>> So be it.
>>>>
>>>> However, do not disable the issues mails for any reason.  There is a
>>>> difference between R not happening and R not being possible.
>>>>
>>>
>>> That's right.
>>>
>>
>> ​The search I referenced in the first post has more than 1500 issues in
>> the RESOLVED-FIXED category. ​
>>
>> ​ Of these, some percentage should be CLOSEd. And yes, it's a bit of an
>> annoyance to get the emails, but I think it's worth it to keep better
>> records.
>> ​
>>
>>>
>>> Marcus
>>
>>
> ​A great big THANK YOU for the work done on this cleanup business so far.
>
> SUPER!!!!!

please, no. ;-)

Judging for these issues is easy without fixes for any OpenOffice code.

I'll answer your other mail later. And try to close more issues in the
next days.

Marcus



>>> -----Original Message-----
>>>>> From: Marcus [mailto:[hidden email]]
>>>>> Sent: Thursday, April 7, 2016 02:10
>>>>> To: [hidden email]
>>>>> Cc: [hidden email]
>>>>> Subject: Re: [DISCUSS] Cleanup needed for RESOLVED-FIXED issues
>>>>>
>>>>> [ ... ]
>>>>
>>>>> I've closed all listed issues regarding our infrastructure (Website,
>>>>> Bugzilla, etc.). As you can see every single change results in a mail
>>>>> and will fill everybody's inbox - when you are subscribed to the issues@
>>>>> mailing list.
>>>>>
>>>>> There will be the possibility to disable mails when performing special
>>>>> actions (e.g., bulk issue changes) but not before release 6.0 [1]. At
>>>>> the moment we are at 5.0.2. So, it will take some more time. ;-(
>>>>>
>>>>> For the time being we have only the way do disable completely sending
>>>>> mails when we work on the issue. But this means that *absolutely no
>>>>> mails will be sent* regardless what was done (new issue, change,
>>>>> comments, closing, etc.).
>>>>>
>>>>> [1] https://bugzilla.mozilla.org/show_bug.cgi?id=1062718
>>>>>
>>>>> Sorry for the spam. ;-)
>>>>>
>>>>> Marcus

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [DISCUSS] Cleanup needed for RESOLVED-FIXED issues

Marcus (OOo)
In reply to this post by Kay Schenk-2
Am 04/07/2016 12:43 AM, schrieb Kay Schenk:

> [...]
>
> A warning -- unless you can see an SVN commit clearly
> stating that the fix has been ported to one of our existing
> releases, it may take a bit of investigation into the
> release branch area to determine this.
>
> release branch area--
> http://svn.apache.org/viewvc/openoffice/branches/
>
>
> Our new resolution of FIXED_WITHOUT_CODE should result in
> CLOSING without any further investigation.
>
> Thoughts on undertaking this cleanup?

many issues are commented with "fixed in CMS xyz" but there are no real
commits visible. Not every CWS was committed into Trunk before the
project and software was transferred to Apache.

So, do we have a list of outstanding CWS from 2011 that were not
transferred to Apache?

Thanks

Marcus

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]