[GitHub] [openoffice] DonLewisFreeBSD opened a new pull request #100: Nssupgrade - Upgrade bundled nss to nss-3.39-with-nspr-4.20

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
6 messages Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] [openoffice] DonLewisFreeBSD opened a new pull request #100: Nssupgrade - Upgrade bundled nss to nss-3.39-with-nspr-4.20

GitBox

DonLewisFreeBSD opened a new pull request #100:
URL: https://github.com/apache/openoffice/pull/100


   Upgrade the bundled version of nss to nss-3.39-with-nspr-4.20.  This is not the latest version, but newer versions use a lot of C90, which the old version of Visual C++ that we use can't handle.
   
   nss contains security libraries and is used for document signing.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] [openoffice] DonLewisFreeBSD commented on pull request #100: Nssupgrade - Upgrade bundled nss to nss-3.39-with-nspr-4.20

GitBox

DonLewisFreeBSD commented on pull request #100:
URL: https://github.com/apache/openoffice/pull/100#issuecomment-700906638


   This needs to be tested on MacOS.  Nss integrates somewhat strangely on that platform and we had issues with the previous upgrade.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] [openoffice] Pilot-Pirx commented on pull request #100: Nssupgrade - Upgrade bundled nss to nss-3.39-with-nspr-4.20

GitBox
In reply to this post by GitBox

Pilot-Pirx commented on pull request #100:
URL: https://github.com/apache/openoffice/pull/100#issuecomment-701316288


   Just for the record:
   Build on Windows was successful. This was Windows 10 64-bit with MozillaBuild 3.3 (64-bit)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] [openoffice] cbmarcum commented on pull request #100: Nssupgrade - Upgrade bundled nss to nss-3.39-with-nspr-4.20

GitBox
In reply to this post by GitBox

cbmarcum commented on pull request #100:
URL: https://github.com/apache/openoffice/pull/100#issuecomment-703942008


   I built this PR with trunk on CentOS 7. BVT tests and some manually file creation and testing went fine.
   I don't think I have a certificate I can test signing a document with.
   Is there anything specific I can do to test this more?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] [openoffice] DonLewisFreeBSD commented on pull request #100: Nssupgrade - Upgrade bundled nss to nss-3.39-with-nspr-4.20

GitBox
In reply to this post by GitBox

DonLewisFreeBSD commented on pull request #100:
URL: https://github.com/apache/openoffice/pull/100#issuecomment-703948340


   I did my testing with a self-signed certificate that I created about a year ago.  The details are hazy now, but I found this set of instructions:
     https://www.dalesandro.net/create-self-signed-smime-certificates/
   
   I then imported the .pkcs12 file into Firefox for signing documents.  OpenOffice uses the same certificate storage as Firefox.  I haven't tried it, but I would think that Chrome would do the same.
   
   This isn't a great test because the certificate is self-signed, so OpenOffice can't validate it like it could if the certificate was issued by a well known certificate authority.  I'm hoping that someone who has an "official" certificate can do some testing.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] [openoffice] DonLewisFreeBSD commented on pull request #100: Nssupgrade - Upgrade bundled nss to nss-3.39-with-nspr-4.20

GitBox
In reply to this post by GitBox

DonLewisFreeBSD commented on pull request #100:
URL: https://github.com/apache/openoffice/pull/100#issuecomment-704403118


   Another test would be to open an existing validly signed document and verifying that the signature is valid.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]