[GitHub] [openoffice] DonLewisFreeBSD opened a new pull request #93: Force Linux builds to use gnu++98 (C++98 + GNU extensions) mode to be

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] [openoffice] DonLewisFreeBSD opened a new pull request #93: Force Linux builds to use gnu++98 (C++98 + GNU extensions) mode to be

GitBox

DonLewisFreeBSD opened a new pull request #93:
URL: https://github.com/apache/openoffice/pull/93


   the most compatible with our old code base rather than relying on the
   compiler default mode.  Compiling in C++11 or newer mode is very noisy
   due to deprecation warnings about our use of std::auto_ptr.  If the
   compiler defaults to C++17 mode or newer, the build would be totally
   broken because std::auto_ptr is removed from C++17.
   
   There is an unknown amount of porting effort needed to convert to
   std::unique_ptr, which has somewhat different semantics and which is
   not available before C++11, which would break building with older versions
   of gcc which default to gnu++98 mode.
   
   std::shared_ptr, might be an alternative since there is a BOOST
   implementation.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [GitHub] [openoffice] DonLewisFreeBSD opened a new pull request #93: Force Linux builds to use gnu++98 (C++98 + GNU extensions) mode to be

Don Lewis-2
On 23 Aug, GitBox wrote:

>
> DonLewisFreeBSD opened a new pull request #93:
> URL: https://github.com/apache/openoffice/pull/93
>
>
>    the most compatible with our old code base rather than relying on the
>    compiler default mode.  Compiling in C++11 or newer mode is very noisy
>    due to deprecation warnings about our use of std::auto_ptr.  If the
>    compiler defaults to C++17 mode or newer, the build would be totally
>    broken because std::auto_ptr is removed from C++17.
>    
>    There is an unknown amount of porting effort needed to convert to
>    std::unique_ptr, which has somewhat different semantics and which is
>    not available before C++11, which would break building with older versions
>    of gcc which default to gnu++98 mode.
>    
>    std::shared_ptr, might be an alternative since there is a BOOST
>    implementation.

This reduction of compiler warnings reduces the size of the build log by
2/3rd when compiling with gcc 6.3.0.


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] [openoffice] DonLewisFreeBSD merged pull request #93: Force Linux builds to use gnu++98 (C++98 + GNU extensions) mode to be

GitBox
In reply to this post by GitBox

DonLewisFreeBSD merged pull request #93:
URL: https://github.com/apache/openoffice/pull/93


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]