[GitHub] [openoffice] DonLewisFreeBSD opened a new pull request #95: JDK8 ODK

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
10 messages Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] [openoffice] DonLewisFreeBSD opened a new pull request #95: JDK8 ODK

GitBox

DonLewisFreeBSD opened a new pull request #95:
URL: https://github.com/apache/openoffice/pull/95


   Correct javadoc comments to unbreak --enable-odk build with JDK 8 or newer


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] [openoffice] DonLewisFreeBSD commented on pull request #95: JDK8 ODK

GitBox

DonLewisFreeBSD commented on pull request #95:
URL: https://github.com/apache/openoffice/pull/95#issuecomment-696560215


   > My Windows test builds (incl. SDK) were successful.
   > But when building with Java 8 (Oracle) an installed Java 7 is not detected by AOO.
   > Since we still are building our releases with Java 7 this would be a minor regression for our users.
   
   I believe the problem is present without the patch, but the build with Java 8 would have to be done w/o the SDK.
   
   I will try to dig into this.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] [openoffice] Pilot-Pirx commented on pull request #95: JDK8 ODK

GitBox
In reply to this post by GitBox

Pilot-Pirx commented on pull request #95:
URL: https://github.com/apache/openoffice/pull/95#issuecomment-696651911


   > I believe the problem is present without the patch, but the build with Java 8 would have to be done w/o the SDK.
   >
   > I will try to dig into this.
   
   Yes, I think this is independent of the patch. A general problem we have with 4.1.x
   Building AOO 4.2.x with Java 8 works as expected.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] [openoffice] DonLewisFreeBSD commented on pull request #95: JDK8 ODK

GitBox
In reply to this post by GitBox

DonLewisFreeBSD commented on pull request #95:
URL: https://github.com/apache/openoffice/pull/95#issuecomment-696971253


   > > I believe the problem is present without the patch, but the build with Java 8 would have to be done w/o the SDK.
   > > I will try to dig into this.
   >
   > Yes, I think this is independent of the patch. A general problem we have with 4.1.x
   > Building AOO 4.2.x with Java 8 works as expected.
   
   Which is odd.  A while back I compared the detection code between the two branches and they appeared to be identical.
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] [openoffice] cbmarcum commented on pull request #95: JDK8 ODK

GitBox
In reply to this post by GitBox

cbmarcum commented on pull request #95:
URL: https://github.com/apache/openoffice/pull/95#issuecomment-697016792


   I went back and checked my build and I can confirm what Matthias found about Java 7 was not discovered when I built with Java 8. But I don't think that is an issue for this PR.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] [openoffice] DonLewisFreeBSD merged pull request #95: JDK8 ODK

GitBox
In reply to this post by GitBox

DonLewisFreeBSD merged pull request #95:
URL: https://github.com/apache/openoffice/pull/95


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] [openoffice] DonLewisFreeBSD commented on pull request #95: JDK8 ODK

GitBox
In reply to this post by GitBox

DonLewisFreeBSD commented on pull request #95:
URL: https://github.com/apache/openoffice/pull/95#issuecomment-696560215






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] [openoffice] cbmarcum commented on pull request #95: JDK8 ODK

GitBox
In reply to this post by GitBox

cbmarcum commented on pull request #95:
URL: https://github.com/apache/openoffice/pull/95#issuecomment-697016792


   I went back and checked my build and I can confirm what Matthias found about Java 7 was not discovered when I built with Java 8. But I don't think that is an issue for this PR.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] [openoffice] DonLewisFreeBSD merged pull request #95: JDK8 ODK

GitBox
In reply to this post by GitBox

DonLewisFreeBSD merged pull request #95:
URL: https://github.com/apache/openoffice/pull/95


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] [openoffice] Pilot-Pirx commented on pull request #95: JDK8 ODK

GitBox
In reply to this post by GitBox

Pilot-Pirx commented on pull request #95:
URL: https://github.com/apache/openoffice/pull/95#issuecomment-696651911


   > I believe the problem is present without the patch, but the build with Java 8 would have to be done w/o the SDK.
   >
   > I will try to dig into this.
   
   Yes, I think this is independent of the patch. A general problem we have with 4.1.x
   Building AOO 4.2.x with Java 8 works as expected.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]