[GitHub] [openoffice] Pilot-Pirx opened a new pull request #90: Possible patch for Bugzilla Issue 128395

classic Classic list List threaded Threaded
15 messages Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] [openoffice] Pilot-Pirx opened a new pull request #90: Possible patch for Bugzilla Issue 128395

GitBox

Pilot-Pirx opened a new pull request #90:
URL: https://github.com/apache/openoffice/pull/90


   See: https://bz.apache.org/ooo/show_bug.cgi?id=128395
   
   I took over the logic from https://github.com/apache/openoffice/blob/trunk/main/sw/source/ui/utlui/navipi.cxx#L1217
   
   But since I am not a coder, I am not sure if that is enough. A test build on Windows was successful and did show the (inactive) entries.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] [openoffice] Pilot-Pirx commented on pull request #90: Possible patch for Bugzilla Issue 128395

GitBox

Pilot-Pirx commented on pull request #90:
URL: https://github.com/apache/openoffice/pull/90#issuecomment-658122082


   OK, we need some additional logic to exclude Help pages in that list...
   See: https://bz.apache.org/ooo/show_bug.cgi?id=53333


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] [openoffice] dev-hyeondnl commented on pull request #90: Possible patch for Bugzilla Issue 128395

GitBox
In reply to this post by GitBox

dev-hyeondnl commented on pull request #90:
URL: https://github.com/apache/openoffice/pull/90#issuecomment-659231424


   It seems that the first logic provides us the solution; I just added the code at the beginning of while statement, and the help pages vanished.
   ```C++
   if (pView->GetDocShell()->IsHelpDocument()) {
       pView = SwModule::GetNextView(pView);
       continue;
   }
   ```
   I tested and built the code on linux, centos7.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] [openoffice] Pilot-Pirx commented on pull request #90: Possible patch for Bugzilla Issue 128395

GitBox
In reply to this post by GitBox

Pilot-Pirx commented on pull request #90:
URL: https://github.com/apache/openoffice/pull/90#issuecomment-659354278


   >
   > ```c++
   > if (pView->GetDocShell()->IsHelpDocument()) {
   >     pView = SwModule::GetNextView(pView);
   >     continue;
   > }
   > ```
   
   Thanks, that code is inserted at line 1191?
   
   I have started a build on Windows now...


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] [openoffice] dev-hyeondnl commented on pull request #90: Possible patch for Bugzilla Issue 128395

GitBox
In reply to this post by GitBox

dev-hyeondnl commented on pull request #90:
URL: https://github.com/apache/openoffice/pull/90#issuecomment-659358173


   Yes it goes right after the opening parenthesis on line 1192. It will look like this
   ```cxx
   while (pView)
   {
            if (pView->GetDocShell()->IsHelpDocument()) {
                   pView = SwModule::GetNextView(pView);
                   continue;
            }
            String sInsert = pView->GetDocShell()->GetTitle();
            if (pView == pActiveView) {
            //
   ```


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] [openoffice] Pilot-Pirx commented on pull request #90: Possible patch for Bugzilla Issue 128395

GitBox
In reply to this post by GitBox

Pilot-Pirx commented on pull request #90:
URL: https://github.com/apache/openoffice/pull/90#issuecomment-660368529


   Updated patch to filter out help pages.
   My Windows Test Build was successful and did show (inactive) but no help window in context menu.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [GitHub] [openoffice] Pilot-Pirx opened a new pull request #90: Possible patch for Bugzilla Issue 128395

Carl Marcum
In reply to this post by GitBox
I've started a Linux build of this PR and trunk.

Thanks,
Carl

On 7/14/20 6:01 AM, GitBox wrote:

> Pilot-Pirx opened a new pull request #90:
> URL: https://github.com/apache/openoffice/pull/90
>
>
>     See: https://bz.apache.org/ooo/show_bug.cgi?id=128395
>    
>     I took over the logic from https://github.com/apache/openoffice/blob/trunk/main/sw/source/ui/utlui/navipi.cxx#L1217
>    
>     But since I am not a coder, I am not sure if that is enough. A test build on Windows was successful and did show the (inactive) entries.
>
>
> ----------------------------------------------------------------
> This is an automated message from the Apache Git Service.
> To respond to the message, please log on to GitHub and use the
> URL above to go to the specific comment.
>
> For queries about this service, please contact Infrastructure at:
> [hidden email]
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [hidden email]
> For additional commands, e-mail: [hidden email]
>


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [GitHub] [openoffice] Pilot-Pirx opened a new pull request #90: Possible patch for Bugzilla Issue 128395

Matthias Seidel
Hi Carl,

Am 18.07.20 um 19:07 schrieb Carl Marcum:
> I've started a Linux build of this PR and trunk.

Great!

So far this seems to work as intended, but I found a little problem
(related) in

/main/sw/source/ui/utlui/navipi.cxx

That will be another issue...

Regards,

   Matthias

>
> Thanks,
> Carl
>
> On 7/14/20 6:01 AM, GitBox wrote:
>> Pilot-Pirx opened a new pull request #90:
>> URL: https://github.com/apache/openoffice/pull/90
>>
>>
>>     See: https://bz.apache.org/ooo/show_bug.cgi?id=128395
>>         I took over the logic from
>> https://github.com/apache/openoffice/blob/trunk/main/sw/source/ui/utlui/navipi.cxx#L1217
>>         But since I am not a coder, I am not sure if that is enough.
>> A test build on Windows was successful and did show the (inactive)
>> entries.
>>
>>
>> ----------------------------------------------------------------
>> This is an automated message from the Apache Git Service.
>> To respond to the message, please log on to GitHub and use the
>> URL above to go to the specific comment.
>>
>> For queries about this service, please contact Infrastructure at:
>> [hidden email]
>>
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: [hidden email]
>> For additional commands, e-mail: [hidden email]
>>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [hidden email]
> For additional commands, e-mail: [hidden email]
>


smime.p7s (5K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

[GitHub] [openoffice] cbmarcum commented on pull request #90: Possible patch for Bugzilla Issue 128395

GitBox
In reply to this post by GitBox

cbmarcum commented on pull request #90:
URL: https://github.com/apache/openoffice/pull/90#issuecomment-660561183


   Writer context menu now shows a space before the parenthesis and displays inactive also.  This looks consistent with Calc now.
   I can also confirm that the help window is filtered out of the Writer context menu now.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] [openoffice] cbmarcum removed a comment on pull request #90: Possible patch for Bugzilla Issue 128395

GitBox
In reply to this post by GitBox

cbmarcum removed a comment on pull request #90:
URL: https://github.com/apache/openoffice/pull/90#issuecomment-660561183


   Writer context menu now shows a space before the parenthesis and displays inactive also.  This looks consistent with Calc now.
   I can also confirm that the help window is filtered out of the Writer context menu now.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] [openoffice] cbmarcum commented on pull request #90: Possible patch for Bugzilla Issue 128395

GitBox
In reply to this post by GitBox

cbmarcum commented on pull request #90:
URL: https://github.com/apache/openoffice/pull/90#issuecomment-660562354


   Will the bugzilla issue remain open for the Item 3 in the attachment about Untitled1 vs Untitled 1 with a space difference between titlebar and menus?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] [openoffice] dev-hyeondnl commented on pull request #90: Possible patch for Bugzilla Issue 128395

GitBox
In reply to this post by GitBox

dev-hyeondnl commented on pull request #90:
URL: https://github.com/apache/openoffice/pull/90#issuecomment-660584716


   OK I think there is a mistake in GetTitle function:( It seems that adding a space before this line works.
   https://github.com/apache/openoffice/blob/trunk/main/sfx2/source/doc/objmisc.cxx#L999
   
   ```cxx
   // add this line
   aNoName += ' ';
   aNoName += String::CreateFromInt32( pImp->nVisualDocumentNumber );
   ```
   Tested on centos.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] [openoffice] Pilot-Pirx commented on pull request #90: Possible patch for Bugzilla Issue 128395

GitBox
In reply to this post by GitBox

Pilot-Pirx commented on pull request #90:
URL: https://github.com/apache/openoffice/pull/90#issuecomment-660613990


   > Will the bugzilla issue remain open for the Item 3 in the attachment about Untitled1 vs Untitled 1 with a space difference between titlebar and menus?
   
   Maybe we should handle that part in a different ticket. The difference (Untitled1 vs. Untitled 1) occurs in several places throughout AOO and I am not sure if a change here would have impact on other parts.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [GitHub] [openoffice] Pilot-Pirx commented on pull request #90: Possible patch for Bugzilla Issue 128395

Czesław Wolański
Hi,

Maybe we should handle that part in a different ticket. The difference
> (Untitled1 vs. Untitled 1) occurs in several places throughout AOO and I
> am not sure if a change here would have impact on other part
>

+1.

Additional remarks:

1. Bugzilla Issue 95320 (now partly obsolete) provides examples of "The
difference (Untitled1 vs. Untitled 1)"
   Of interest therein is also inadequate name displayed when clicking
"Page Preview" several times.

   https://bz.apache.org/ooo/show_bug.cgi?id=95320


2. file "objmisc.cxx", line 242

https://github.com/apache/openoffice/blob/38b4ec22106f698bc160ab2dfb25a759cf961a7a/main/sfx2/source/doc/objmisc.cxx#L242

"// => nicht am Doc setzen, da sonst "unbenanntX" daraus wird"

Please notice "unbenanntX".


3. There is another issue about "Untitled".
In  File - Properties', "General" tab, file name is shown as "Untitled".

Title of the document window: "Untitled 1"
Dialog's title: "Properties of Untitled1"
"File" input field: "Untitled"


Regards,

Czesław Wolański







вс, 19 июл. 2020 г. в 11:13, GitBox <[hidden email]>:

>
> Pilot-Pirx commented on pull request #90:
> URL: https://github.com/apache/openoffice/pull/90#issuecomment-660613990
>
>
>    > Will the bugzilla issue remain open for the Item 3 in the attachment
> about Untitled1 vs Untitled 1 with a space difference between titlebar and
> menus?
>
>    Maybe we should handle that part in a different ticket. The difference
> (Untitled1 vs. Untitled 1) occurs in several places throughout AOO and I am
> not sure if a change here would have impact on other parts.
>
>
> ----------------------------------------------------------------
> This is an automated message from the Apache Git Service.
> To respond to the message, please log on to GitHub and use the
> URL above to go to the specific comment.
>
> For queries about this service, please contact Infrastructure at:
> [hidden email]
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [hidden email]
> For additional commands, e-mail: [hidden email]
>
>
Reply | Threaded
Open this post in threaded view
|

[GitHub] [openoffice] Pilot-Pirx merged pull request #90: Patch for Bugzilla Issue 128395

GitBox
In reply to this post by GitBox

Pilot-Pirx merged pull request #90:
URL: https://github.com/apache/openoffice/pull/90


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]