[GitHub] [openoffice] androidports opened a new pull request #106: Fix for crashing in exporting PDF with a Noto Serif CJK JP font.

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
13 messages Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] [openoffice] androidports opened a new pull request #106: Fix for crashing in exporting PDF with a Noto Serif CJK JP font.

GitBox

androidports opened a new pull request #106:
URL: https://github.com/apache/openoffice/pull/106


   I got a bug report of crashing in exporting PDF with a Noto Serif CJK JP font from my Android user.
   This is same bug in PC version:
   I confirm this crash with:
   
   OpenOffice 4.1.7
   macOS 10.15.6
   
   I fix this problem and send feed back patch.
   
   The attached file is the sample document for crashing with exporting PDF.
   
   [crashing-with-noto-serif-cjk-jp.docx](https://github.com/apache/openoffice/files/5390104/crashing-with-noto-serif-cjk-jp.docx)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] [openoffice] Pilot-Pirx commented on pull request #106: Fix for crashing in exporting PDF with a Noto Serif CJK JP font.

GitBox

Pilot-Pirx commented on pull request #106:
URL: https://github.com/apache/openoffice/pull/106#issuecomment-709916345


   Hi,
   Can you please test AOO 4.1.8-RC2?
   This *should* already be fixed.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] [openoffice] Pilot-Pirx edited a comment on pull request #106: Fix for crashing in exporting PDF with a Noto Serif CJK JP font.

GitBox
In reply to this post by GitBox

Pilot-Pirx edited a comment on pull request #106:
URL: https://github.com/apache/openoffice/pull/106#issuecomment-709916345


   Hi,
   Can you please test with AOO 4.1.8-RC2?
   
   https://dist.apache.org/repos/dist/dev/openoffice/4.1.8-RC2/binaries/


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] [openoffice] androidports commented on pull request #106: Fix for crashing in exporting PDF with a Noto Serif CJK JP font.

GitBox
In reply to this post by GitBox

androidports commented on pull request #106:
URL: https://github.com/apache/openoffice/pull/106#issuecomment-709966382


   OK, I confirm crashing is fixed.
   But exported PDF is invalid. (attached file)
   
   [crashing-with-noto-serif-cjk-jp.pdf](https://github.com/apache/openoffice/files/5390829/crashing-with-noto-serif-cjk-jp.pdf)
   
   I think 4.1.8-RC2 avoid crashing by invalid CFF format, but this invalid format is caused by casting from `float` to `int` in main/vcl/source/fontsubset/cff.cxx:637.
   
   `nInt = static_cast<int>(nVal);`
   
   This patch change casting from float to double.
   
   I will apply this patch to the latest AOO418 and inform the result to this thread.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] [openoffice] androidports edited a comment on pull request #106: Fix for crashing in exporting PDF with a Noto Serif CJK JP font.

GitBox
In reply to this post by GitBox

androidports edited a comment on pull request #106:
URL: https://github.com/apache/openoffice/pull/106#issuecomment-709966382


   OK, I confirm crashing is fixed in AOO 4.1.8-RC2.
   But exported PDF is invalid. (attached file)
   
   [crashing-with-noto-serif-cjk-jp.pdf](https://github.com/apache/openoffice/files/5390829/crashing-with-noto-serif-cjk-jp.pdf)
   
   I think 4.1.8-RC2 avoid crashing by invalid CFF format, but this invalid format is caused by casting from `float` to `int` in main/vcl/source/fontsubset/cff.cxx:637.
   
   `nInt = static_cast<int>(nVal);`
   
   This patch change casting from float to double.
   
   I will apply this patch to the latest AOO418 and inform the result to this thread.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] [openoffice] Pilot-Pirx commented on pull request #106: Fix for crashing in exporting PDF with a Noto Serif CJK JP font.

GitBox
In reply to this post by GitBox

Pilot-Pirx commented on pull request #106:
URL: https://github.com/apache/openoffice/pull/106#issuecomment-709971389


   Thanks for testing!
   
   Can you have a look at PR #89?
   
   This is an enhancement to the fix in 418-RC2.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] [openoffice] ardovm commented on pull request #106: Fix for crashing in exporting PDF with a Noto Serif CJK JP font.

GitBox
In reply to this post by GitBox

ardovm commented on pull request #106:
URL: https://github.com/apache/openoffice/pull/106#issuecomment-709984442


   Hello,
   
   I am chiming is as the proposer of PR #89.
   Unfortunately, we are still affected by the bug. I am investigating.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] [openoffice] ardovm commented on pull request #106: Fix for crashing in exporting PDF with a Noto Serif CJK JP font.

GitBox
In reply to this post by GitBox

ardovm commented on pull request #106:
URL: https://github.com/apache/openoffice/pull/106#issuecomment-710050455


   @androidports
   > I think 4.1.8-RC2 avoid crashing by invalid CFF format, but this invalid format is caused by casting from `float` to `int` in main/vcl/source/fontsubset/cff.cxx:637.
   >
   > `nInt = static_cast<int>(nVal);`
   
   Very good catch, Yoshikawa-san!
   A `float` cannot represent all values of a 32-bit `int`!
   
   I wonder why no one ever found this bug before?
   
   > This patch change casting from float to double.
   
   I confirm this fixes the garbled PDF output.
   
   IMHO this PR addresses a totally different problem than PR #89 and is worth merging on its own.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] [openoffice] Pilot-Pirx commented on pull request #106: Fix for crashing in exporting PDF with a Noto Serif CJK JP font.

GitBox
In reply to this post by GitBox

Pilot-Pirx commented on pull request #106:
URL: https://github.com/apache/openoffice/pull/106#issuecomment-710430813


   I can replicate the garbled PDF output on Windows and Ubuntu.
   Will now build 418 for Windows with the patch applied.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] [openoffice] Pilot-Pirx commented on pull request #106: Fix for crashing in exporting PDF with a Noto Serif CJK JP font.

GitBox
In reply to this post by GitBox

Pilot-Pirx commented on pull request #106:
URL: https://github.com/apache/openoffice/pull/106#issuecomment-711023823


   Actually I build AOO42X, but I can confirm that the exported PDF looks OK now.
   This will also go in AOO418-RC3.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] [openoffice] Pilot-Pirx merged pull request #106: Fix for crashing in exporting PDF with a Noto Serif CJK JP font.

GitBox
In reply to this post by GitBox

Pilot-Pirx merged pull request #106:
URL: https://github.com/apache/openoffice/pull/106


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] [openoffice] Pilot-Pirx commented on pull request #106: Fix for crashing in exporting PDF with a Noto Serif CJK JP font.

GitBox
In reply to this post by GitBox

Pilot-Pirx commented on pull request #106:
URL: https://github.com/apache/openoffice/pull/106#issuecomment-711082689


   I almost forgot to say thank you for providing this patch! ;-)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] [openoffice] androidports commented on pull request #106: Fix for crashing in exporting PDF with a Noto Serif CJK JP font.

GitBox
In reply to this post by GitBox

androidports commented on pull request #106:
URL: https://github.com/apache/openoffice/pull/106#issuecomment-711091850


   You are welcome!
   I’m going to give feed backs from my project.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]