[GitHub] [openoffice] ardovm opened a new pull request #113: Avoid "dmake clean" to wipe out the whole tree

classic Classic list List threaded Threaded
9 messages Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] [openoffice] ardovm opened a new pull request #113: Avoid "dmake clean" to wipe out the whole tree

GitBox

ardovm opened a new pull request #113:
URL: https://github.com/apache/openoffice/pull/113


   As per a recent thread on the dev@ mailing list, the "dmake clean" command may wipe out the whole source tree, if the build environment was not set by sourcing the appropriate `.Env` script.
   
   This PR has the purpose to fix the problem, assuming that if the build environment is not set, then the "dmake clean" command must not do anything.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] [openoffice] leginee commented on pull request #113: Avoid "dmake clean" to wipe out the whole tree

GitBox

leginee commented on pull request #113:
URL: https://github.com/apache/openoffice/pull/113#issuecomment-747446201


   hmm, that echo needs no quotes in
   ` echo Build environment not set; works without Quotes?`
   looks strange. Is it special on make files that they can omit these?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] [openoffice] ardovm commented on pull request #113: Avoid "dmake clean" to wipe out the whole tree

GitBox
In reply to this post by GitBox

ardovm commented on pull request #113:
URL: https://github.com/apache/openoffice/pull/113#issuecomment-747507745


   @leginee I was also surprised it works :-)
   
   Proof:
   ```
   $ echo Hello world; echo Hallo Welt
   Hello world
   Hallo Welt
   $
   ```


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] [openoffice] ardovm commented on pull request #113: Avoid "dmake clean" to wipe out the whole tree

GitBox
In reply to this post by GitBox

ardovm commented on pull request #113:
URL: https://github.com/apache/openoffice/pull/113#issuecomment-747509362


   By the way, I followed that "pattern" as is it the same for the `install` target in the same file:
   
   ```Makefile
   install .PHONY :
    @test "$(DESTDIR)$(prefix)" != "" || (echo Usage: make install [DESTDIR=DIR] prefix=DIR; exit 2)
   [...]
   ```


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] [openoffice] leginee commented on pull request #113: Avoid "dmake clean" to wipe out the whole tree

GitBox
In reply to this post by GitBox

leginee commented on pull request #113:
URL: https://github.com/apache/openoffice/pull/113#issuecomment-747527573


   Worth a test. :)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] [openoffice] Pilot-Pirx commented on pull request #113: Avoid "dmake clean" to wipe out the whole tree

GitBox
In reply to this post by GitBox

Pilot-Pirx commented on pull request #113:
URL: https://github.com/apache/openoffice/pull/113#issuecomment-749494181


   Is there any reason not to merge this PR?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [GitHub] [openoffice] Pilot-Pirx commented on pull request #113: Avoid "dmake clean" to wipe out the whole tree

Jim Jagielski
merge away

> On Dec 22, 2020, at 6:28 AM, GitBox <[hidden email]> wrote:
>
>
> Pilot-Pirx commented on pull request #113:
> URL: https://github.com/apache/openoffice/pull/113#issuecomment-749494181
>
>
>   Is there any reason not to merge this PR?
>
>
> ----------------------------------------------------------------
> This is an automated message from the Apache Git Service.
> To respond to the message, please log on to GitHub and use the
> URL above to go to the specific comment.
>
> For queries about this service, please contact Infrastructure at:
> [hidden email]
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [hidden email]
> For additional commands, e-mail: [hidden email]
>


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [GitHub] [openoffice] Pilot-Pirx commented on pull request #113: Avoid "dmake clean" to wipe out the whole tree

Matthias Seidel
Hi Jim,

Am 22.12.20 um 14:00 schrieb Jim Jagielski:
> merge away

I will do it, but other could do that as well... ;-)

BTW, I am just trying to build AOO on Windows with BeanShell 2.1.0.

Regards,

   Matthias

>
>> On Dec 22, 2020, at 6:28 AM, GitBox <[hidden email]> wrote:
>>
>>
>> Pilot-Pirx commented on pull request #113:
>> URL: https://github.com/apache/openoffice/pull/113#issuecomment-749494181
>>
>>
>>   Is there any reason not to merge this PR?
>>
>>
>> ----------------------------------------------------------------
>> This is an automated message from the Apache Git Service.
>> To respond to the message, please log on to GitHub and use the
>> URL above to go to the specific comment.
>>
>> For queries about this service, please contact Infrastructure at:
>> [hidden email]
>>
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: [hidden email]
>> For additional commands, e-mail: [hidden email]
>>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [hidden email]
> For additional commands, e-mail: [hidden email]
>


smime.p7s (5K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

[GitHub] [openoffice] Pilot-Pirx merged pull request #113: Avoid "dmake clean" to wipe out the whole tree

GitBox
In reply to this post by GitBox

Pilot-Pirx merged pull request #113:
URL: https://github.com/apache/openoffice/pull/113


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]