[GitHub] [openoffice] ardovm opened a new pull request #122: Address bug 128356 and similar ones (duplicated XML attributes)

classic Classic list List threaded Threaded
6 messages Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] [openoffice] ardovm opened a new pull request #122: Address bug 128356 and similar ones (duplicated XML attributes)

GitBox

ardovm opened a new pull request #122:
URL: https://github.com/apache/openoffice/pull/122


   This is a work-in-progress fix for https://bz.apache.org/ooo/show_bug.cgi?id=128356
   Please keep the discussion about the "philosophy" of the patch on Bugzilla.
   
   Code style, variable names, indentation etc. shall be discussed here.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] [openoffice] jimjag commented on pull request #122: Address bug 128356 and similar ones (duplicated XML attributes)

GitBox

jimjag commented on pull request #122:
URL: https://github.com/apache/openoffice/pull/122#issuecomment-773990932


   Is
   `
   if (!!bAutoStyles)
   `
   really the best way to format that logical if for https://github.com/apache/openoffice/pull/122/commits/7af97f4fe332f523912f0174635fb94d88995f46 ?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] [openoffice] ardovm commented on pull request #122: Address bug 128356 and similar ones (duplicated XML attributes)

GitBox
In reply to this post by GitBox

ardovm commented on pull request #122:
URL: https://github.com/apache/openoffice/pull/122#issuecomment-774024441


   > Is
   > `if (!!bAutoStyles)`
   > really the best way to format that logical if for [7af97f4](https://github.com/apache/openoffice/commit/7af97f4fe332f523912f0174635fb94d88995f46) ?
   
   Not at all! It's a typo! Thank you for spotting it!
   
   I was going to test this code later, after changing the assertion into an exception.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] [openoffice] ardovm edited a comment on pull request #122: Address bug 128356 and similar ones (duplicated XML attributes)

GitBox
In reply to this post by GitBox

ardovm edited a comment on pull request #122:
URL: https://github.com/apache/openoffice/pull/122#issuecomment-774024441


   > Is
   > `if (!!bAutoStyles)`
   > really the best way to format that logical if for [7af97f4](https://github.com/apache/openoffice/commit/7af97f4fe332f523912f0174635fb94d88995f46) ?
   
   Not at all! It's a typo! Thank you for spotting it!
   
   I am planning to test this code later, after changing the assertion into an exception.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] [openoffice] ardovm commented on pull request #122: Address bug 128356 and similar ones (duplicated XML attributes)

GitBox
In reply to this post by GitBox

ardovm commented on pull request #122:
URL: https://github.com/apache/openoffice/pull/122#issuecomment-774448450


   Ok, the exception details are shown in non-product builds.
   Product builds just show an error message "Error saving the document: write error. Error in writing sub-document content.xml".
   I think it is enough to warn the user that the attempt to save the document has failed.
   Moreover, if I try to close the document, I am warned that it has not been saved.
   
   Please note that the above was checked with a "hand-inserted" exception, as the documents attached to the reports do not seem to trigger the bug any more.
   
   The PR is IMHO production-ready, but I would like to spend some more time on documentation.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] [openoffice] ardovm commented on pull request #122: Address bug 128356 and similar ones (duplicated XML attributes)

GitBox
In reply to this post by GitBox

ardovm commented on pull request #122:
URL: https://github.com/apache/openoffice/pull/122#issuecomment-774489872


   Ok, I am done. Reviews welcome!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]