[GitHub] [openoffice] ardovm opened a new pull request #89: Use std::vector instead of fixed-size array of cffLocal objects

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
33 messages Options
12
Reply | Threaded
Open this post in threaded view
|

[GitHub] [openoffice] ardovm commented on pull request #89: Use std::vector instead of fixed-size array of cffLocal objects

GitBox

ardovm commented on pull request #89:
URL: https://github.com/apache/openoffice/pull/89#issuecomment-705172239


   I apologize for taking so long to reply.
   
   [This file](https://github.com/apache/openoffice/files/5343566/pr89.zip) contains an ODT and a PDF that was generated with the patch applied. It tries to be self-explaining: it contains a table with two columns. The first is in Noto Sans CJK, the second contains images that show the expected rendering.
   
   The images were taken from the OpenOffice Writer window, therefore their rendering was not influenced by this PR.
   
   The PDF seems ok, at least on my system (Ubuntu 18.04 x86_64) using several PDF readers.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] [openoffice] ardovm commented on pull request #89: Use std::vector instead of fixed-size array of cffLocal objects

GitBox
In reply to this post by GitBox

ardovm commented on pull request #89:
URL: https://github.com/apache/openoffice/pull/89#issuecomment-709985252


   The file provided in PR #106 ([this one](https://github.com/apache/openoffice/files/5390104/crashing-with-noto-serif-cjk-jp.docx)) is rendered incorrectly as PDF.
   I am working on it.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] [openoffice] ardovm commented on pull request #89: Use std::vector instead of fixed-size array of cffLocal objects

GitBox
In reply to this post by GitBox

ardovm commented on pull request #89:
URL: https://github.com/apache/openoffice/pull/89#issuecomment-711165338


   > The file provided in PR #106 ([this one](https://github.com/apache/openoffice/files/5390104/crashing-with-noto-serif-cjk-jp.docx)) is rendered incorrectly as PDF.
   > I am working on it.
   
   Merging PR #106 fixed the problem. It was a separate issue than this PR, although occurring in the same file.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] [openoffice] cbmarcum commented on pull request #89: Use std::vector instead of fixed-size array of cffLocal objects

GitBox
In reply to this post by GitBox

cbmarcum commented on pull request #89:
URL: https://github.com/apache/openoffice/pull/89#issuecomment-744009606


   When I open the pr89.odt file from the PR89.zip I see a discrepancy  in the characters 6th row left column vs. the image in the right column.
   ![pr89](https://user-images.githubusercontent.com/19439139/102013440-36a49100-3d1e-11eb-8a2e-5874f584ce5b.png)
   It is the same with a trunk build I had before this PR and after.  Also with a old AOO418 build I had so I think it's maybe the document and not a result of this PR.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] [openoffice] cbmarcum edited a comment on pull request #89: Use std::vector instead of fixed-size array of cffLocal objects

GitBox
In reply to this post by GitBox

cbmarcum edited a comment on pull request #89:
URL: https://github.com/apache/openoffice/pull/89#issuecomment-744009606


   When I open the pr89.odt file from the PR89.zip I see a discrepancy  in the characters 6th row left column vs. the image in the right column.
   ![pr89](https://user-images.githubusercontent.com/19439139/102013440-36a49100-3d1e-11eb-8a2e-5874f584ce5b.png)
   It is the same with a trunk build I had before this PR and after.  Also with a old AOO418 build I had so I think it's maybe the document and not a result of this PR.
   I will add that exports from all 3 of those match the ODT.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] [openoffice] cbmarcum edited a comment on pull request #89: Use std::vector instead of fixed-size array of cffLocal objects

GitBox
In reply to this post by GitBox

cbmarcum edited a comment on pull request #89:
URL: https://github.com/apache/openoffice/pull/89#issuecomment-744009606


   When I open the pr89.odt file from the PR89.zip I see a discrepancy  in the characters 6th row left column vs. the image in the right column. The pr89.pdf matches.
   ![pr89](https://user-images.githubusercontent.com/19439139/102013440-36a49100-3d1e-11eb-8a2e-5874f584ce5b.png)
   It is the same with a trunk build I had before this PR and after.  Also with a old AOO418 build I had so I think it's maybe the document and not a result of this PR.
   I will add that exports from all 3 of those match the ODT.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] [openoffice] Pilot-Pirx commented on pull request #89: Use std::vector instead of fixed-size array of cffLocal objects

GitBox
In reply to this post by GitBox

Pilot-Pirx commented on pull request #89:
URL: https://github.com/apache/openoffice/pull/89#issuecomment-744013286


   I don't see a mismatch in the odt (opened with AOO 4.1.8 on Ubuntu 16.04)
   Also no problems on Windows with AOO 4.2.0-dev.
   
   Do you have the font (Noto Sans CJK SC) installed?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] [openoffice] ardovm commented on pull request #89: Use std::vector instead of fixed-size array of cffLocal objects

GitBox
In reply to this post by GitBox

ardovm commented on pull request #89:
URL: https://github.com/apache/openoffice/pull/89#issuecomment-744016761


   @cbmarcum thank you for the detailed review.
   
   I don't know Korean, unfortunately, but from this page:
   https://fonts.google.com/?subset=korean&preview.text=%ED%95%98&preview.text_type=custom
   it seems that you are seeing a different font representing the same characters. In particular this one: 하
   Maybe you don't have the font "Noto Sans CJK SC" available in your system?
   
   The PDF matches because it contains embedded font subsets... and that is what this PR is about, after all ;-)
   
   I hope this makes sense!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] [openoffice] cbmarcum commented on pull request #89: Use std::vector instead of fixed-size array of cffLocal objects

GitBox
In reply to this post by GitBox

cbmarcum commented on pull request #89:
URL: https://github.com/apache/openoffice/pull/89#issuecomment-744035475


   I figured it out.  I had Noto Sans CJK SC font's installed but they had weight modifiers Light, Medium, Bold in the font names.  Once I changed them it appeared correctly. Thanks!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] [openoffice] cbmarcum edited a comment on pull request #89: Use std::vector instead of fixed-size array of cffLocal objects

GitBox
In reply to this post by GitBox

cbmarcum edited a comment on pull request #89:
URL: https://github.com/apache/openoffice/pull/89#issuecomment-744035475


   I figured it out.  I had Noto Sans CJK SC font's installed but they had weight modifiers Light, Medium, Bold in the font names.  Once I changed them it appeared correctly. Thanks!
   And The PDF exported correctly.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] [openoffice] Pilot-Pirx commented on pull request #89: Use std::vector instead of fixed-size array of cffLocal objects

GitBox
In reply to this post by GitBox

Pilot-Pirx commented on pull request #89:
URL: https://github.com/apache/openoffice/pull/89#issuecomment-744752764


   Did another build on Windows now. No problems with export.
   This PR is OK from my point of view.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] [openoffice] Pilot-Pirx commented on pull request #89: Use std::vector instead of fixed-size array of cffLocal objects

GitBox
In reply to this post by GitBox

Pilot-Pirx commented on pull request #89:
URL: https://github.com/apache/openoffice/pull/89#issuecomment-770998849


   Any objections against merging this PR?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] [openoffice] Pilot-Pirx merged pull request #89: Use std::vector instead of fixed-size array of cffLocal objects

GitBox
In reply to this post by GitBox

Pilot-Pirx merged pull request #89:
URL: https://github.com/apache/openoffice/pull/89


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

12