[GitHub] [openoffice] cbmarcum opened a new pull request #115: Flaky tests

classic Classic list List threaded Threaded
6 messages Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] [openoffice] cbmarcum opened a new pull request #115: Flaky tests

GitBox

cbmarcum opened a new pull request #115:
URL: https://github.com/apache/openoffice/pull/115


   This work is for flaky BVT tests that randomly pass or fail during multiple runs against the same build.
   Basically I'm adding a thread sleep prior to the test assertion check.
   So far this has reduced the average failure count of 2 or 3 per run to 0 for the last 5 runs I've made against trunk.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] [openoffice] cbmarcum merged pull request #115: Flaky tests

GitBox

cbmarcum merged pull request #115:
URL: https://github.com/apache/openoffice/pull/115


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] [openoffice] cbmarcum merged pull request #115: Flaky tests

GitBox
In reply to this post by GitBox

cbmarcum merged pull request #115:
URL: https://github.com/apache/openoffice/pull/115


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] [openoffice] leginee commented on pull request #115: Flaky tests

GitBox
In reply to this post by GitBox

leginee commented on pull request #115:
URL: https://github.com/apache/openoffice/pull/115#issuecomment-757465959


   I checked through the code and for me it is fine. I have a question thought.
   The assert call had always a parameter as a implicit nested Function. and you broke that up, by declaring a variable first and then hand it to the assert function. Did you do this for style reasons or was there a deeper technical thought behind it?
   Also note that the sleep comes always directly in front of the assert, so there is a change. That is why I wonder a bit.
   I like the structure, because it is cleaner now.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] [openoffice] cbmarcum commented on pull request #115: Flaky tests

GitBox
In reply to this post by GitBox

cbmarcum commented on pull request #115:
URL: https://github.com/apache/openoffice/pull/115#issuecomment-757522715


   The reason was technical.  My belief is the tests were passing and failing randomly either from threading issues or processor speeds that didn't exist when they were created.  When the tests would fail the error was the calculated values in formulas or grabbing from the clipboard was returning to slow to make it in time for the evaluation in the assertion.  By splitting them out I was able to add a sleep in thread before the assertion and this seemed to improve the reliability of the tests.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] [openoffice] leginee commented on pull request #115: Flaky tests

GitBox
In reply to this post by GitBox

leginee commented on pull request #115:
URL: https://github.com/apache/openoffice/pull/115#issuecomment-758453134


   Hmm, can I add a review confirmetion somehow, I wonder.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]