[GitHub] [openoffice] leginee opened a new pull request #121: translated various comments

[GitBox]

leginee opened a new pull request #121:
URL: https://github.com/apache/openoffice/pull/121


   Translation of some german comments of the interface.
   Please review and see if you understand those and check for spelling errors.
   
   Thanks.
   I hope this will help to improve the way we read and write documents.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

[GitBox]

ardovm commented on a change in pull request #121:
URL: https://github.com/apache/openoffice/pull/121#discussion_r565566978



##########
File path: main/sw/inc/shellio.hxx
##########
@@ -106,11 +105,11 @@ public:
 };
 
 /**************** SwReader/Reader ************************/
-// Basisklasse der moeglichen Optionen fuer einen speziellen Reader
+// base class for different specialized readers
 class Reader;
-// Ruft den Reader mit seinen Optionen, Dokument, Cursor etc.
+//  calls a document with its options, document, cursor etc.

Review comment:
       should it this call a Reader instead? It makes sense if "Reader" is the class

##########
File path: main/sw/inc/shellio.hxx
##########
@@ -367,32 +363,32 @@ public:
     void   SetBaseURL( const String& rURL );
 
  sal_Bool   IsOld() const;
- sal_uLong  ConvertToNew(); // Textbausteine konvertieren
+ sal_uLong  ConvertToNew(); // convert AutoText entries (ger: Textbausteine)

Review comment:
       Could Textbaustein be translated as "text building block"?
   I have no idea what it would mean... in both languages, though

##########
File path: main/sw/inc/shellio.hxx
##########
@@ -226,12 +225,12 @@ protected:
  SvStream* pStrm;
     SotStorageRef pStg;
     com::sun::star::uno::Reference < com::sun::star::embed::XStorage > xStg;
- SfxMedium* pMedium; // wer ein Medium haben will (W4W)
+ SfxMedium* pMedium; // describes file or storage  (W4W)
 
  SwgReaderOption aOpt;
  sal_Bool bInsertMode : 1;
  sal_Bool bTmplBrowseMode : 1;
- sal_Bool bReadUTF8: 1; // Stream als UTF-8 interpretieren
+ sal_Bool bReadUTF8: 1; // interpred stream as UTF-8

Review comment:
       maybe "interpre**te**d"

##########
File path: main/sw/inc/shellio.hxx
##########
@@ -414,18 +410,18 @@ SW_DLLPUBLIC SwRead SwGetReaderXML();
 // END source/filter/basflt/fltini.cxx
 
 
-extern sal_Bool SetHTMLTemplate( SwDoc &rDoc ); //Fuer Vorlagen aus HTML.vor laden shellio.cxx
+extern sal_Bool SetHTMLTemplate( SwDoc &rDoc ); // HTML templates (pre?)load shellio.cxx

Review comment:
       Or "before loading"? I have no idea :-(

##########
File path: main/sw/inc/shellio.hxx
##########
@@ -161,32 +160,32 @@ class SwReader: public SwDocFac
  SvStream* pStrm;
     SotStorageRef pStg;
     com::sun::star::uno::Reference < com::sun::star::embed::XStorage > xStg;
- SfxMedium* pMedium; // wer ein Medium haben will (W4W)
+ SfxMedium* pMedium; // describes file or storage (W4W)
 
  SwPaM* pCrsr;
  String aFileName;
     String sBaseURL;
 
 public:
  /*
- * Initiales Einlesen. Dokument wird erst beim Read(..) angelegt.
- * JP 25.04.95: oder falls es mitgegeben wird, in dieses.
- * Sonderfall fuer Load mit Sw3Reader
+ * Initial read. document is created when function Read(...) os called

Review comment:
       "os" or "is" ?

##########
File path: main/sw/inc/shellio.hxx
##########
@@ -501,32 +497,32 @@ public:
 
     const String&       GetBaseURL() const { return sBaseURL;}
 
-    // suche die naechste Bookmark-Position aus der Bookmark-Tabelle
+    // search next bookmark position from the bookmark table
  sal_Int32 FindPos_Bkmk( const SwPosition& rPos ) const;
  // build a bookmark table, which is sort by the node position. The
  // OtherPos of the bookmarks also inserted.
  void CreateBookmarkTbl();
- // search alle Bookmarks in the range and return it in the Array
+ // search all bookmarks in the range and return it in the Array
  sal_uInt16 GetBookmarks( const SwCntntNode& rNd,
  xub_StrLen nStt, xub_StrLen nEnd,
  SvPtrarr& rArr );
 
- // lege einen neuen PaM an der Position an
+ // create a new PaM at the position
     static SwPaM * NewSwPaM(SwDoc & rDoc,
                             sal_uLong const nStartIdx, sal_uLong const nEndIdx);
 
- // kopiere ggfs. eine lokale Datei ins Internet
+ // upload a local file to the internet / cloud
  sal_Bool CopyLocalFileToINet( String& rFileNm );
 
- // Stream-spezifische Routinen, im Storage-Writer NICHT VERWENDEN!
+ // Stream-specific routines, DO NOT USE IN Storage-Writer!
 
- // Optimierung der Ausgabe auf den Stream.
+ // Optimize of the output stream
  SvStream& OutLong( SvStream& rStrm, long nVal );
  SvStream& OutULong( SvStream& rStrm, sal_uLong nVal );
 
- // Hex-Zahl ausgeben, default ist 2.stellige Zahl
+ // print Hex-Zahl, default is 2. digit number

Review comment:
       Hex-Zahl could be translated into "hexadecimal number" unless Hex-Zahl is an actual class or type name

##########
File path: main/sw/inc/shellio.hxx
##########
@@ -45,7 +45,7 @@
 #include <errhdl.hxx>
 #include <iodetect.hxx>
 
-// einige Forward - Deklarationen
+// some forward declerations

Review comment:
       decl**a**rations ;-)

##########
File path: main/sw/inc/shellio.hxx
##########
@@ -367,32 +363,32 @@ public:
     void   SetBaseURL( const String& rURL );
 
  sal_Bool   IsOld() const;
- sal_uLong  ConvertToNew(); // Textbausteine konvertieren
+ sal_uLong  ConvertToNew(); // convert AutoText entries (ger: Textbausteine)
 
- sal_uInt16 GetCount() const; // Anzahl Textbausteine ermitteln
- sal_uInt16 GetIndex( const String& ) const; // Index fuer Kurznamen ermitteln
+ sal_uInt16 GetCount() const; // return amount of AutoText entries
+ sal_uInt16 GetIndex( const String& ) const; // return Index of shortnames
  sal_uInt16 GetLongIndex( const String& ) const; //Index fuer Langnamen ermitteln
- const  String& GetShortName( sal_uInt16 ) const; // Kurzname fuer Index zurueck
- const  String& GetLongName( sal_uInt16 ) const;   // Langname fuer Index zurueck
+ const  String& GetShortName( sal_uInt16 ) const; // return a shortname of an index
+ const  String& GetLongName( sal_uInt16 ) const;   // return longname of an index
 
- sal_Bool   Delete( sal_uInt16 ); // Loeschen
- sal_uInt16 Rename( sal_uInt16, const String*, const String* ); // Umbenennen
+ sal_Bool   Delete( sal_uInt16 ); // delete
+ sal_uInt16 Rename( sal_uInt16, const String*, const String* ); // rename
  sal_uLong  CopyBlock( SwTextBlocks& rSource, String& rSrcShort,
- const String& rLong ); // Block kopieren
+ const String& rLong ); // copy block
 
- sal_Bool   BeginGetDoc( sal_uInt16 ); // Textbaustein einlesen
- void   EndGetDoc(); // Textbaustein wieder loslassen
+ sal_Bool   BeginGetDoc( sal_uInt16 ); // read AutoText entry
+ void   EndGetDoc(); // release AutoText entry
 
- sal_Bool   BeginPutDoc( const String&, const String& ); // Speichern Beginn
- sal_uInt16 PutDoc(); // Speichern Ende
+ sal_Bool   BeginPutDoc( const String&, const String& ); // start save
+ sal_uInt16 PutDoc(); // End save
 
- sal_uInt16 PutText( const String&, const String&, const String& ); // Speichern( Kurzn., Text)
+ sal_uInt16 PutText( const String&, const String&, const String& ); // save (short., Text)

Review comment:
       IMHO "short." here is not clearly identified as "shortname". Maybe it's worth not abbreviating it.

##########
File path: main/sw/inc/shellio.hxx
##########
@@ -501,32 +497,32 @@ public:
 
     const String&       GetBaseURL() const { return sBaseURL;}
 
-    // suche die naechste Bookmark-Position aus der Bookmark-Tabelle
+    // search next bookmark position from the bookmark table
  sal_Int32 FindPos_Bkmk( const SwPosition& rPos ) const;
  // build a bookmark table, which is sort by the node position. The
  // OtherPos of the bookmarks also inserted.
  void CreateBookmarkTbl();
- // search alle Bookmarks in the range and return it in the Array
+ // search all bookmarks in the range and return it in the Array
  sal_uInt16 GetBookmarks( const SwCntntNode& rNd,
  xub_StrLen nStt, xub_StrLen nEnd,
  SvPtrarr& rArr );
 
- // lege einen neuen PaM an der Position an
+ // create a new PaM at the position
     static SwPaM * NewSwPaM(SwDoc & rDoc,
                             sal_uLong const nStartIdx, sal_uLong const nEndIdx);
 
- // kopiere ggfs. eine lokale Datei ins Internet
+ // upload a local file to the internet / cloud
  sal_Bool CopyLocalFileToINet( String& rFileNm );
 
- // Stream-spezifische Routinen, im Storage-Writer NICHT VERWENDEN!
+ // Stream-specific routines, DO NOT USE IN Storage-Writer!
 
- // Optimierung der Ausgabe auf den Stream.
+ // Optimize of the output stream

Review comment:
       Maybe "optimization"?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

[Marcus (OOo)]

It seems here a German-native speaker should help as the context is
important and needs to be considered when translating the text.

How urgent do you need this?
I would try to help you after the release is done.

Marcus



Am 27.01.21 um 20:27 schrieb GitBox:

>
> ardovm commented on a change in pull request #121:
> URL: https://github.com/apache/openoffice/pull/121#discussion_r565566978
>
>
>
> ##########
> File path: main/sw/inc/shellio.hxx
> ##########
> @@ -367,32 +363,32 @@ public:
>       void   SetBaseURL( const String& rURL );
>  
>   sal_Bool   IsOld() const;
> - sal_uLong  ConvertToNew(); // Textbausteine konvertieren
> + sal_uLong  ConvertToNew(); // convert AutoText entries (ger: Textbausteine)
>
> Review comment:
>         Could Textbaustein be translated as "text building block"?
>     I have no idea what it would mean... in both languages, though
>
> [...]

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

[GitBox]

leginee commented on a change in pull request #121:
URL: https://github.com/apache/openoffice/pull/121#discussion_r565602584



##########
File path: main/sw/inc/shellio.hxx
##########
@@ -106,11 +105,11 @@ public:
 };
 
 /**************** SwReader/Reader ************************/
-// Basisklasse der moeglichen Optionen fuer einen speziellen Reader
+// base class for different specialized readers
 class Reader;
-// Ruft den Reader mit seinen Optionen, Dokument, Cursor etc.
+//  calls a document with its options, document, cursor etc.

Review comment:
       yea, you are right. I fix this




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

[GitBox]

leginee commented on a change in pull request #121:
URL: https://github.com/apache/openoffice/pull/121#discussion_r565603037



##########
File path: main/sw/inc/shellio.hxx
##########
@@ -161,32 +160,32 @@ class SwReader: public SwDocFac
  SvStream* pStrm;
     SotStorageRef pStg;
     com::sun::star::uno::Reference < com::sun::star::embed::XStorage > xStg;
- SfxMedium* pMedium; // wer ein Medium haben will (W4W)
+ SfxMedium* pMedium; // describes file or storage (W4W)
 
  SwPaM* pCrsr;
  String aFileName;
     String sBaseURL;
 
 public:
  /*
- * Initiales Einlesen. Dokument wird erst beim Read(..) angelegt.
- * JP 25.04.95: oder falls es mitgegeben wird, in dieses.
- * Sonderfall fuer Load mit Sw3Reader
+ * Initial read. document is created when function Read(...) os called

Review comment:
       thanks




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

[GitBox]

leginee commented on a change in pull request #121:
URL: https://github.com/apache/openoffice/pull/121#discussion_r565603678



##########
File path: main/sw/inc/shellio.hxx
##########
@@ -367,32 +363,32 @@ public:
     void   SetBaseURL( const String& rURL );
 
  sal_Bool   IsOld() const;
- sal_uLong  ConvertToNew(); // Textbausteine konvertieren
+ sal_uLong  ConvertToNew(); // convert AutoText entries (ger: Textbausteine)

Review comment:
       Well, yea Leo translates Textbaustein to Text building blog or boilerplate, but in the OpenOffice help it is translated to AutoText entry, which is a feature of OpenOffice.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

[GitBox]

leginee commented on a change in pull request #121:
URL: https://github.com/apache/openoffice/pull/121#discussion_r565606170



##########
File path: main/sw/inc/shellio.hxx
##########
@@ -414,18 +410,18 @@ SW_DLLPUBLIC SwRead SwGetReaderXML();
 // END source/filter/basflt/fltini.cxx
 
 
-extern sal_Bool SetHTMLTemplate( SwDoc &rDoc ); //Fuer Vorlagen aus HTML.vor laden shellio.cxx
+extern sal_Bool SetHTMLTemplate( SwDoc &rDoc ); // HTML templates (pre?)load shellio.cxx

Review comment:
       I am not sure, what the german comment means. It could mean before loading or only loading. :(




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

[GitBox]

leginee commented on a change in pull request #121:
URL: https://github.com/apache/openoffice/pull/121#discussion_r565606703



##########
File path: main/sw/inc/shellio.hxx
##########
@@ -501,32 +497,32 @@ public:
 
     const String&       GetBaseURL() const { return sBaseURL;}
 
-    // suche die naechste Bookmark-Position aus der Bookmark-Tabelle
+    // search next bookmark position from the bookmark table
  sal_Int32 FindPos_Bkmk( const SwPosition& rPos ) const;
  // build a bookmark table, which is sort by the node position. The
  // OtherPos of the bookmarks also inserted.
  void CreateBookmarkTbl();
- // search alle Bookmarks in the range and return it in the Array
+ // search all bookmarks in the range and return it in the Array
  sal_uInt16 GetBookmarks( const SwCntntNode& rNd,
  xub_StrLen nStt, xub_StrLen nEnd,
  SvPtrarr& rArr );
 
- // lege einen neuen PaM an der Position an
+ // create a new PaM at the position
     static SwPaM * NewSwPaM(SwDoc & rDoc,
                             sal_uLong const nStartIdx, sal_uLong const nEndIdx);
 
- // kopiere ggfs. eine lokale Datei ins Internet
+ // upload a local file to the internet / cloud
  sal_Bool CopyLocalFileToINet( String& rFileNm );
 
- // Stream-spezifische Routinen, im Storage-Writer NICHT VERWENDEN!
+ // Stream-specific routines, DO NOT USE IN Storage-Writer!
 
- // Optimierung der Ausgabe auf den Stream.
+ // Optimize of the output stream

Review comment:
       optimization is indeed better




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

[GitBox]

leginee commented on a change in pull request #121:
URL: https://github.com/apache/openoffice/pull/121#discussion_r565607126



##########
File path: main/sw/inc/shellio.hxx
##########
@@ -501,32 +497,32 @@ public:
 
     const String&       GetBaseURL() const { return sBaseURL;}
 
-    // suche die naechste Bookmark-Position aus der Bookmark-Tabelle
+    // search next bookmark position from the bookmark table
  sal_Int32 FindPos_Bkmk( const SwPosition& rPos ) const;
  // build a bookmark table, which is sort by the node position. The
  // OtherPos of the bookmarks also inserted.
  void CreateBookmarkTbl();
- // search alle Bookmarks in the range and return it in the Array
+ // search all bookmarks in the range and return it in the Array
  sal_uInt16 GetBookmarks( const SwCntntNode& rNd,
  xub_StrLen nStt, xub_StrLen nEnd,
  SvPtrarr& rArr );
 
- // lege einen neuen PaM an der Position an
+ // create a new PaM at the position
     static SwPaM * NewSwPaM(SwDoc & rDoc,
                             sal_uLong const nStartIdx, sal_uLong const nEndIdx);
 
- // kopiere ggfs. eine lokale Datei ins Internet
+ // upload a local file to the internet / cloud
  sal_Bool CopyLocalFileToINet( String& rFileNm );
 
- // Stream-spezifische Routinen, im Storage-Writer NICHT VERWENDEN!
+ // Stream-specific routines, DO NOT USE IN Storage-Writer!
 
- // Optimierung der Ausgabe auf den Stream.
+ // Optimize of the output stream
  SvStream& OutLong( SvStream& rStrm, long nVal );
  SvStream& OutULong( SvStream& rStrm, sal_uLong nVal );
 
- // Hex-Zahl ausgeben, default ist 2.stellige Zahl
+ // print Hex-Zahl, default is 2. digit number

Review comment:
       Ohh man I missed that. :facepalm:




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

[GitBox]

leginee commented on pull request #121:
URL: https://github.com/apache/openoffice/pull/121#issuecomment-768553149


   Thank you for the quick review. I have some really bad mistakes there.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

[Czesław Wolański]

Hi,

My remarks on Shelli O. (PDF file) can be downloaded from the following
link:

https://drive.google.com/file/d/1R4nw-5V7cPVTTmGsVuLdwzBxPgG65ttz/view?usp=sharing

Regards,
Czesław Wolański

Am Mi., 27. Jan. 2021 um 21:23 Uhr schrieb GitBox <[hidden email]>:

>
> leginee commented on pull request #121:
> URL: https://github.com/apache/openoffice/pull/121#issuecomment-768553149
>
>
>    Thank you for the quick review. I have some really bad mistakes there.
>
>
> ----------------------------------------------------------------
> This is an automated message from the Apache Git Service.
> To respond to the message, please log on to GitHub and use the
> URL above to go to the specific comment.
>
> For queries about this service, please contact Infrastructure at:
> [hidden email]
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [hidden email]
> For additional commands, e-mail: [hidden email]
>
>

[GitBox]

ardovm commented on a change in pull request #121:
URL: https://github.com/apache/openoffice/pull/121#discussion_r568057490



##########
File path: main/sw/inc/shellio.hxx
##########
@@ -414,18 +410,18 @@ SW_DLLPUBLIC SwRead SwGetReaderXML();
 // END source/filter/basflt/fltini.cxx
 
 
-extern sal_Bool SetHTMLTemplate( SwDoc &rDoc ); //Fuer Vorlagen aus HTML.vor laden shellio.cxx
+extern sal_Bool SetHTMLTemplate( SwDoc &rDoc ); // HTML templates (pre?)load shellio.cxx

Review comment:
       I can find other occurrences of the string `HTML.vor` in comments, always besides a call to `SetHTMLTemplate()`. Maybe it is an abbreviation for "HTML template"? A former file extension? Just speculating...




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

[GitBox]

ardovm commented on a change in pull request #121:
URL: https://github.com/apache/openoffice/pull/121#discussion_r568116353



##########
File path: main/sw/inc/shellio.hxx
##########
@@ -367,32 +363,32 @@ public:
     void   SetBaseURL( const String& rURL );
 
  sal_Bool   IsOld() const;
- sal_uLong  ConvertToNew(); // Textbausteine konvertieren
+ sal_uLong  ConvertToNew(); // convert AutoText entries (ger: Textbausteine)

Review comment:
       Fun fact: `SwTextBlocks::ConvertToNew()` is _commented out_.
   Source: main/sw/source/core/swg/swblocks.cxx




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

[GitBox]

ardovm commented on a change in pull request #121:
URL: https://github.com/apache/openoffice/pull/121#discussion_r568119970



##########
File path: main/sw/inc/shellio.hxx
##########
@@ -367,32 +363,32 @@ public:
     void   SetBaseURL( const String& rURL );
 
  sal_Bool   IsOld() const;
- sal_uLong  ConvertToNew(); // Textbausteine konvertieren
+ sal_uLong  ConvertToNew(); // convert AutoText entries (ger: Textbausteine)

Review comment:
       Ok, you are right. The correct translation is autotext. Sorry for the noise.
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

[GitBox]

leginee commented on a change in pull request #121:
URL: https://github.com/apache/openoffice/pull/121#discussion_r568185411



##########
File path: main/sw/inc/shellio.hxx
##########
@@ -367,32 +363,32 @@ public:
     void   SetBaseURL( const String& rURL );
 
  sal_Bool   IsOld() const;
- sal_uLong  ConvertToNew(); // Textbausteine konvertieren
+ sal_uLong  ConvertToNew(); // convert AutoText entries (ger: Textbausteine)

Review comment:
       No reason to be sorry. It is assuring that you agree.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

[Peter Kovacs-3]

Thanks Czesław,

your links look great. I need a biot more time to go through all the
points. But looks great additions.

Thanks a lot.


All the Best

Peter

On 28.01.21 16:48, Czesław Wolański wrote:

> Hi,
>
> My remarks on Shelli O. (PDF file) can be downloaded from the following
> link:
>
> https://drive.google.com/file/d/1R4nw-5V7cPVTTmGsVuLdwzBxPgG65ttz/view?usp=sharing
>
> Regards,
> Czesław Wolański
>
> Am Mi., 27. Jan. 2021 um 21:23 Uhr schrieb GitBox <[hidden email]>:
>
>> leginee commented on pull request #121:
>> URL: https://github.com/apache/openoffice/pull/121#issuecomment-768553149
>>
>>
>>     Thank you for the quick review. I have some really bad mistakes there.
>>
>>
>> ----------------------------------------------------------------
>> This is an automated message from the Apache Git Service.
>> To respond to the message, please log on to GitHub and use the
>> URL above to go to the specific comment.
>>
>> For queries about this service, please contact Infrastructure at:
>> [hidden email]
>>
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: [hidden email]
>> For additional commands, e-mail: [hidden email]
>>
>>

--
This is the Way! http://www.apache.org/theapacheway/index.html

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

[Czesław Wolański]

Hi Peter,

> Thanks a lot.

You're welcome. And you might consider thanking Shelli O.  ;‑)

All the best
Czesław

пн, 1 февр. 2021 г. в 23:33, Peter Kovacs <[hidden email]>:

> Thanks Czesław,
>
> your links look great. I need a biot more time to go through all the
> points. But looks great additions.
>
> Thanks a lot.
>
>
> All the Best
>
> Peter
>
> On 28.01.21 16:48, Czesław Wolański wrote:
> > Hi,
> >
> > My remarks on Shelli O. (PDF file) can be downloaded from the following
> > link:
> >
> >
> https://drive.google.com/file/d/1R4nw-5V7cPVTTmGsVuLdwzBxPgG65ttz/view?usp=sharing
> >
> > Regards,
> > Czesław Wolański
> >
> > Am Mi., 27. Jan. 2021 um 21:23 Uhr schrieb GitBox <[hidden email]>:
> >
> >> leginee commented on pull request #121:
> >> URL:
> https://github.com/apache/openoffice/pull/121#issuecomment-768553149
> >>
> >>
> >>     Thank you for the quick review. I have some really bad mistakes
> there.
> >>
> >>
> >> ----------------------------------------------------------------
> >> This is an automated message from the Apache Git Service.
> >> To respond to the message, please log on to GitHub and use the
> >> URL above to go to the specific comment.
> >>
> >> For queries about this service, please contact Infrastructure at:
> >> [hidden email]
> >>
> >>
> >>
> >> ---------------------------------------------------------------------
> >> To unsubscribe, e-mail: [hidden email]
> >> For additional commands, e-mail: [hidden email]
> >>
> >>
> --
> This is the Way! http://www.apache.org/theapacheway/index.html
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [hidden email]
> For additional commands, e-mail: [hidden email]
>
>

[GitBox]

leginee commented on a change in pull request #121:
URL: https://github.com/apache/openoffice/pull/121#discussion_r568215534



##########
File path: main/sw/inc/shellio.hxx
##########
@@ -414,18 +410,18 @@ SW_DLLPUBLIC SwRead SwGetReaderXML();
 // END source/filter/basflt/fltini.cxx
 
 
-extern sal_Bool SetHTMLTemplate( SwDoc &rDoc ); //Fuer Vorlagen aus HTML.vor laden shellio.cxx
+extern sal_Bool SetHTMLTemplate( SwDoc &rDoc ); // HTML templates (pre?)load shellio.cxx

Review comment:
       I slowly get the Idea that the comment is borked. I checked opengrok and I found the line:
    bHTMLTemplSet = SetHTMLTemplate( *GetDoc() );//Styles aus HTML.vor in InitNew()  (see docshini.cxx 127)
   
   
   I assume from the code that it should mean:
   Extract HTMLTemplates from given Document.
   
   But when I check docsh2.cxx 1720 :
   // fix #51032#: Die HTML-Vorlage muss noch gesetzt werden
   SetHTMLTemplate( *GetDoc() ); //Styles aus HTML.vor
   
   The fix comment translates to: The HTML-Template has to be set
   The next line says Syles from HTML.vor maybe that is a fixed term?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

[GitBox]

leginee commented on a change in pull request #121:
URL: https://github.com/apache/openoffice/pull/121#discussion_r568216249



##########
File path: main/sw/inc/shellio.hxx
##########
@@ -414,18 +410,18 @@ SW_DLLPUBLIC SwRead SwGetReaderXML();
 // END source/filter/basflt/fltini.cxx
 
 
-extern sal_Bool SetHTMLTemplate( SwDoc &rDoc ); //Fuer Vorlagen aus HTML.vor laden shellio.cxx
+extern sal_Bool SetHTMLTemplate( SwDoc &rDoc ); // HTML templates (pre?)load shellio.cxx

Review comment:
       Great. Checking the Issue is leading to a wrong issue. Probably the Number is to old to be recognized?
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

[GitBox]

ardovm commented on a change in pull request #121:
URL: https://github.com/apache/openoffice/pull/121#discussion_r568367366



##########
File path: main/sw/inc/shellio.hxx
##########
@@ -367,32 +363,32 @@ public:
     void   SetBaseURL( const String& rURL );
 
  sal_Bool   IsOld() const;
- sal_uLong  ConvertToNew(); // Textbausteine konvertieren
+ sal_uLong  ConvertToNew(); // convert AutoText entries (ger: Textbausteine)
 
- sal_uInt16 GetCount() const; // Anzahl Textbausteine ermitteln
- sal_uInt16 GetIndex( const String& ) const; // Index fuer Kurznamen ermitteln
+ sal_uInt16 GetCount() const; // return amount of AutoText entries
+ sal_uInt16 GetIndex( const String& ) const; // return Index of shortnames
  sal_uInt16 GetLongIndex( const String& ) const; //Index fuer Langnamen ermitteln

Review comment:
       Maybe "Return index of longnames"?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]