Make lingucomponent warning-free for wntmsci10

classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

Make lingucomponent warning-free for wntmsci10

stephan.bergmann
Hi all,

I filed <http://www.openoffice.org/issues/show_bug.cgi?id=68903> for the
task of making module lingucomponent warning-free for platform wntmsci10
(i.e., Windows using the Microsoft C/C++ compiler)---a task I do not see
myself fit to complete.

If you want to pick this up, feel free to ask me, or (better) the
[hidden email] mailing list, or this thread for advice (I am not a
regular reader of [hidden email], but will try to
catch any follow-ups in this thread).  Also,
<http://wiki.services.openoffice.org/wiki/Writing_warning-free_code>
might be interesting.

Have fun,
-Stephan

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: Make lingucomponent warning-free for wntmsci10

nemeth-2
Hi Stephan,

Many thanks for your report and your fixes. I'd like to contribute
in fixing MS C/C++ compiler warnings (without Windows, so I will
be grateful for a full warning list in Issue 68903).

I have some little problems with the fixes.
Hunspell's Mozilla integration is
currently in progress: https://bugzilla.mozilla.org/show_bug.cgi?id=319778.
It would be fine to keep the standalone and the integrated version (hunspell
subdirectory in Lingucomponent source) in a single source for the future
developments. Now for the standalone Hunspell library, we need to resolve the
SAL dependency of the present casting fixes, and we need also Mozilla
Public License for the changes (maybe it hasn't be problem for these little
warning fixes.).

Thanks,

Laci

Quoting Stephan Bergmann <[hidden email]>:

> Hi all,
>
> I filed <http://www.openoffice.org/issues/show_bug.cgi?id=68903> for the
> task of making module lingucomponent warning-free for platform wntmsci10
> (i.e., Windows using the Microsoft C/C++ compiler)---a task I do not see
> myself fit to complete.
>
> If you want to pick this up, feel free to ask me, or (better) the
> [hidden email] mailing list, or this thread for advice (I am not a
> regular reader of [hidden email], but will try to
> catch any follow-ups in this thread).  Also,
> <http://wiki.services.openoffice.org/wiki/Writing_warning-free_code>
> might be interesting.
>
> Have fun,
> -Stephan
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [hidden email]
> For additional commands, e-mail: [hidden email]
>
>




----------------------------------------------------------------
This message was sent using IMP, the Internet Messaging Program.

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: Make lingucomponent warning-free for wntmsci10

thomas.lange
In reply to this post by stephan.bergmann

Hi Laci,

> Many thanks for your report and your fixes. I'd like to contribute
> in fixing MS C/C++ compiler warnings (without Windows, so I will
> be grateful for a full warning list in Issue 68903).
>
> I have some little problems with the fixes.
> Hunspell's Mozilla integration is
> currently in progress: https://bugzilla.mozilla.org/show_bug.cgi?id=319778.
> It would be fine to keep the standalone and the integrated version (hunspell
> subdirectory in Lingucomponent source) in a single source for the future
> developments. Now for the standalone Hunspell library, we need to resolve the
> SAL dependency of the present casting fixes, and we need also Mozilla
> Public License for the changes (maybe it hasn't be problem for these little
> warning fixes.).

The problem with this approach probably is that a full list will be
rather long and it is likely that you can not fix just any warning in
arbitrary order because fixing the first e.g. 10 warnings will easily
change the list of warnings detect after that.
Thus it would be an iterating process: to give you such a list, have you
fix e.g. the first 20 something warnings, have you commit those changes,
and we then need to compile again with your changes to give you an
updated list. And this process probably has to be repeated over and over
again until everything is done.
Is this what you want to do in order to get warning free code?


Regards,
Thomas


> Quoting Stephan Bergmann <[hidden email]>:
>
>> Hi all,
>>
>> I filed <http://www.openoffice.org/issues/show_bug.cgi?id=68903> for the
>> task of making module lingucomponent warning-free for platform wntmsci10
>> (i.e., Windows using the Microsoft C/C++ compiler)---a task I do not see
>> myself fit to complete.
>>
>> If you want to pick this up, feel free to ask me, or (better) the
>> [hidden email] mailing list, or this thread for advice (I am not a
>> regular reader of [hidden email], but will try to
>> catch any follow-ups in this thread).  Also,
>> <http://wiki.services.openoffice.org/wiki/Writing_warning-free_code>
>> might be interesting.
>>
>> Have fun,
>> -Stephan
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: [hidden email]
>> For additional commands, e-mail: [hidden email]
>>
>>
>
>
>
>
> ----------------------------------------------------------------
> This message was sent using IMP, the Internet Messaging Program.
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [hidden email]
> For additional commands, e-mail: [hidden email]
>

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: Make lingucomponent warning-free for wntmsci10

nemeth-2
Quoting Thomas Lange <[hidden email]>:

>
> Hi Laci,
>
> > Many thanks for your report and your fixes. I'd like to contribute
> > in fixing MS C/C++ compiler warnings (without Windows, so I will
> > be grateful for a full warning list in Issue 68903).
> >
> > I have some little problems with the fixes.
> > Hunspell's Mozilla integration is
> > currently in progress: https://bugzilla.mozilla.org/show_bug.cgi?id=319778.
> > It would be fine to keep the standalone and the integrated version
> (hunspell
> > subdirectory in Lingucomponent source) in a single source for the future
> > developments. Now for the standalone Hunspell library, we need to resolve
> the
> > SAL dependency of the present casting fixes, and we need also Mozilla
> > Public License for the changes (maybe it hasn't be problem for these little
> > warning fixes.).
>
> The problem with this approach probably is that a full list will be
> rather long and it is likely that you can not fix just any warning in
> arbitrary order because fixing the first e.g. 10 warnings will easily
> change the list of warnings detect after that.
> Thus it would be an iterating process: to give you such a list, have you
> fix e.g. the first 20 something warnings, have you commit those changes,
> and we then need to compile again with your changes to give you an
> updated list. And this process probably has to be repeated over and over
> again until everything is done.
> Is this what you want to do in order to get warning free code?

Hi Thomas,

Yes, it is. Fortunatelly, most of the warnings are trivial, and not real
problems (for example, using assigments in conditions). I think, it will
be enough one or two checking on Windows. Thanks in advance,

Laci

>
>
> Regards,
> Thomas
>
>
> > Quoting Stephan Bergmann <[hidden email]>:
> >
> >> Hi all,
> >>
> >> I filed <http://www.openoffice.org/issues/show_bug.cgi?id=68903> for the
> >> task of making module lingucomponent warning-free for platform wntmsci10
> >> (i.e., Windows using the Microsoft C/C++ compiler)---a task I do not see
> >> myself fit to complete.
> >>
> >> If you want to pick this up, feel free to ask me, or (better) the
> >> [hidden email] mailing list, or this thread for advice (I am not a
> >> regular reader of [hidden email], but will try to
> >> catch any follow-ups in this thread).  Also,
> >> <http://wiki.services.openoffice.org/wiki/Writing_warning-free_code>
> >> might be interesting.
> >>
> >> Have fun,
> >> -Stephan
> >>
> >> ---------------------------------------------------------------------
> >> To unsubscribe, e-mail: [hidden email]
> >> For additional commands, e-mail: [hidden email]
> >>
> >>
> >
> >
> >
> >
> > ----------------------------------------------------------------
> > This message was sent using IMP, the Internet Messaging Program.
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: [hidden email]
> > For additional commands, e-mail: [hidden email]
> >
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [hidden email]
> For additional commands, e-mail: [hidden email]
>
>




----------------------------------------------------------------
This message was sent using IMP, the Internet Messaging Program.

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: Make lingucomponent warning-free for wntmsci10

stephan.bergmann
In reply to this post by stephan.bergmann
[hidden email] wrote:
> Hi Stephan,
[...]
> I have some little problems with the fixes.
> Hunspell's Mozilla integration is
> currently in progress: https://bugzilla.mozilla.org/show_bug.cgi?id=319778.
> It would be fine to keep the standalone and the integrated version (hunspell
> subdirectory in Lingucomponent source) in a single source for the future
> developments. Now for the standalone Hunspell library, we need to resolve the
> SAL dependency of the present casting fixes, and we need also Mozilla
> Public License for the changes (maybe it hasn't be problem for these little
> warning fixes.).

I had asked Martin Hollmichel to follow up on this.

-Stephan

> Thanks,
>
> Laci
[...]

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]