Patch through Github

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
10 messages Options
Reply | Threaded
Open this post in threaded view
|

Patch through Github

FR web forum
Hello dev team,
Is it a right way to submit patch through Github?
https://github.com/apache/openoffice/pulls

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: Patch through Github

Matthias Seidel
Hi,

I think GitHub is "readonly".

Contributions can be made with subversion:
https://openoffice.apache.org/source.html
https://openoffice.apache.org/contributing-code.html

Or you can attach a patch file to the specific issue in Bugzilla.

Did you test the code or would you be interested in a special (Windows)
build?
I don't have such a fancy mouse... ;-)

Regards,

   Matthias

Am 26.07.2018 um 11:21 schrieb FR web forum:
> Hello dev team,
> Is it a right way to submit patch through Github?
> https://github.com/apache/openoffice/pulls
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [hidden email]
> For additional commands, e-mail: [hidden email]
>



smime.p7s (5K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: Patch through Github

FR web forum
Thanks for this answer
I know that I can do it with SVN
But this is too heavy for me to download all aoo-trunk files.
Is it possible to create a patch from Github and then submit to BZ?

----- Mail original -----

> De: "Matthias Seidel" <[hidden email]>
> À: [hidden email]
> Envoyé: Jeudi 26 Juillet 2018 11:31:35
> Objet: Re: Patch through Github
>
> Hi,
>
> I think GitHub is "readonly".
>
> Contributions can be made with subversion:
> https://openoffice.apache.org/source.html
> https://openoffice.apache.org/contributing-code.html
>
> Or you can attach a patch file to the specific issue in Bugzilla.
>
> Did you test the code or would you be interested in a special
> (Windows)
> build?
> I don't have such a fancy mouse... ;-)
>
> Regards,
>
>    Matthias
>
> Am 26.07.2018 um 11:21 schrieb FR web forum:
> > Hello dev team,
> > Is it a right way to submit patch through Github?
> > https://github.com/apache/openoffice/pulls
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: [hidden email]
> > For additional commands, e-mail: [hidden email]
> >
>
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: Patch through Github

Matthias Seidel
Hi,

Am 26.07.2018 um 15:53 schrieb FR web forum:
> Thanks for this answer
> I know that I can do it with SVN
> But this is too heavy for me to download all aoo-trunk files.
> Is it possible to create a patch from Github and then submit to BZ?

I don't know.

But since it is only two lines, I will include it in my next build and
everyone can test it.

Regards,
   Matthias

>
> ----- Mail original -----
>> De: "Matthias Seidel" <[hidden email]>
>> À: [hidden email]
>> Envoyé: Jeudi 26 Juillet 2018 11:31:35
>> Objet: Re: Patch through Github
>>
>> Hi,
>>
>> I think GitHub is "readonly".
>>
>> Contributions can be made with subversion:
>> https://openoffice.apache.org/source.html
>> https://openoffice.apache.org/contributing-code.html
>>
>> Or you can attach a patch file to the specific issue in Bugzilla.
>>
>> Did you test the code or would you be interested in a special
>> (Windows)
>> build?
>> I don't have such a fancy mouse... ;-)
>>
>> Regards,
>>
>>    Matthias
>>
>> Am 26.07.2018 um 11:21 schrieb FR web forum:
>>> Hello dev team,
>>> Is it a right way to submit patch through Github?
>>> https://github.com/apache/openoffice/pulls
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: [hidden email]
>>> For additional commands, e-mail: [hidden email]
>>>
>>
>>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [hidden email]
> For additional commands, e-mail: [hidden email]
>


smime.p7s (5K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: Patch through Github

FR web forum
Ah that will be fine
Thanks Matthias

----- Mail original -----

> De: "Matthias Seidel" <[hidden email]>
> À: [hidden email]
> Envoyé: Jeudi 26 Juillet 2018 16:03:00
> Objet: Re: Patch through Github
>
> Hi,
>
> Am 26.07.2018 um 15:53 schrieb FR web forum:
> > Thanks for this answer
> > I know that I can do it with SVN
> > But this is too heavy for me to download all aoo-trunk files.
> > Is it possible to create a patch from Github and then submit to BZ?
>
> I don't know.
>
> But since it is only two lines, I will include it in my next build
> and
> everyone can test it.
>
> Regards,
>    Matthias
>
> >
> > ----- Mail original -----
> >> De: "Matthias Seidel" <[hidden email]>
> >> À: [hidden email]
> >> Envoyé: Jeudi 26 Juillet 2018 11:31:35
> >> Objet: Re: Patch through Github
> >>
> >> Hi,
> >>
> >> I think GitHub is "readonly".
> >>
> >> Contributions can be made with subversion:
> >> https://openoffice.apache.org/source.html
> >> https://openoffice.apache.org/contributing-code.html
> >>
> >> Or you can attach a patch file to the specific issue in Bugzilla.
> >>
> >> Did you test the code or would you be interested in a special
> >> (Windows)
> >> build?
> >> I don't have such a fancy mouse... ;-)
> >>
> >> Regards,
> >>
> >>    Matthias
> >>
> >> Am 26.07.2018 um 11:21 schrieb FR web forum:
> >>> Hello dev team,
> >>> Is it a right way to submit patch through Github?
> >>> https://github.com/apache/openoffice/pulls
> >>>
> >>> ---------------------------------------------------------------------
> >>> To unsubscribe, e-mail: [hidden email]
> >>> For additional commands, e-mail: [hidden email]
> >>>
> >>
> >>
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: [hidden email]
> > For additional commands, e-mail: [hidden email]
> >
>
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: Re: Patch through Github

mabdul
In reply to this post by FR web forum
Use your commit and attach to the url ".patch", so

https://github.com/apache/openoffice/commit/ba72a0641c1b077c4de326a8da20fc7252b99bc1.patch

Hope that helps.

--- original message ---
From: FR web forum <[hidden email]>
Date: 26.07.2018 15:53:15
To: [hidden email]
Subject: Re: Patch through Github

> Thanks for this answer
> I know that I can do it with SVN
> But this is too heavy for me to download all aoo-trunk files.
> Is it possible to create a patch from Github and then submit to BZ?
>
> ----- Mail original -----
> > De: "Matthias Seidel" <[hidden email]>
> > À: [hidden email]
> > Envoyé: Jeudi 26 Juillet 2018 11:31:35
> > Objet: Re: Patch through Github
> >
> > Hi,
> >
> > I think GitHub is "readonly".
> >
> > Contributions can be made with subversion:
> > https://openoffice.apache.org/source.html
> > https://openoffice.apache.org/contributing-code.html
> >
> > Or you can attach a patch file to the specific issue in Bugzilla.
> >
> > Did you test the code or would you be interested in a special
> > (Windows)
> > build?
> > I don't have such a fancy mouse... ;-)
> >
> > Regards,
> >
> >    Matthias
> >
> > Am 26.07.2018 um 11:21 schrieb FR web forum:
> > > Hello dev team,
> > > Is it a right way to submit patch through Github?
> > > https://github.com/apache/openoffice/pulls
> > >
> > > ---------------------------------------------------------------------
>
> > > To unsubscribe, e-mail: [hidden email]
> > > For additional commands, e-mail: [hidden email]
>
> > >
> >
> >
> >
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [hidden email]
> For additional commands, e-mail: [hidden email]
>



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: Patch through Github

FR web forum
I note this tip for next time
thanks

----- Mail original -----

> De: [hidden email]
> À: [hidden email]
> Cc: [hidden email]
> Envoyé: Vendredi 27 Juillet 2018 01:02:44
> Objet: Re: Re: Patch through Github
>
> Use your commit and attach to the url ".patch", so
>
> https://github.com/apache/openoffice/commit/ba72a0641c1b077c4de326a8da20fc7252b99bc1.patch
>
> Hope that helps.
>
> --- original message ---
> From: FR web forum <[hidden email]>
> Date: 26.07.2018 15:53:15
> To: [hidden email]
> Subject: Re: Patch through Github
>
> > Thanks for this answer
> > I know that I can do it with SVN
> > But this is too heavy for me to download all aoo-trunk files.
> > Is it possible to create a patch from Github and then submit to BZ?
> >
> > ----- Mail original -----
> > > De: "Matthias Seidel" <[hidden email]>
> > > À: [hidden email]
> > > Envoyé: Jeudi 26 Juillet 2018 11:31:35
> > > Objet: Re: Patch through Github
> > >
> > > Hi,
> > >
> > > I think GitHub is "readonly".
> > >
> > > Contributions can be made with subversion:
> > > https://openoffice.apache.org/source.html
> > > https://openoffice.apache.org/contributing-code.html
> > >
> > > Or you can attach a patch file to the specific issue in Bugzilla.
> > >
> > > Did you test the code or would you be interested in a special
> > > (Windows)
> > > build?
> > > I don't have such a fancy mouse... ;-)
> > >
> > > Regards,
> > >
> > >    Matthias
> > >
> > > Am 26.07.2018 um 11:21 schrieb FR web forum:
> > > > Hello dev team,
> > > > Is it a right way to submit patch through Github?
> > > > https://github.com/apache/openoffice/pulls
> > > >
> > > > ---------------------------------------------------------------------
> >
> > > > To unsubscribe, e-mail: [hidden email]
> > > > For additional commands, e-mail: [hidden email]
> >
> > > >
> > >
> > >
> > >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: [hidden email]
> > For additional commands, e-mail: [hidden email]
> >
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [hidden email]
> For additional commands, e-mail: [hidden email]
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: Patch through Github

Matthias Seidel
In reply to this post by FR web forum
Have you been able to test my build?
https://home.apache.org/~mseidel/AOO-builds/AOO-420-Test/

One user already confirmed, that the mouse now shows the wanted behavior
when scrolling horizontally.
But it would be great if you can also confirm it.

Since you don't use Subversion, I could commit the patch (by mentioning
your name) into trunk and close the issue.

Regards,

   Matthias

Am 26.07.2018 um 16:07 schrieb FR web forum:

> Ah that will be fine
> Thanks Matthias
>
> ----- Mail original -----
>> De: "Matthias Seidel" <[hidden email]>
>> À: [hidden email]
>> Envoyé: Jeudi 26 Juillet 2018 16:03:00
>> Objet: Re: Patch through Github
>>
>> Hi,
>>
>> Am 26.07.2018 um 15:53 schrieb FR web forum:
>>> Thanks for this answer
>>> I know that I can do it with SVN
>>> But this is too heavy for me to download all aoo-trunk files.
>>> Is it possible to create a patch from Github and then submit to BZ?
>> I don't know.
>>
>> But since it is only two lines, I will include it in my next build
>> and
>> everyone can test it.
>>
>> Regards,
>>    Matthias
>>
>>> ----- Mail original -----
>>>> De: "Matthias Seidel" <[hidden email]>
>>>> À: [hidden email]
>>>> Envoyé: Jeudi 26 Juillet 2018 11:31:35
>>>> Objet: Re: Patch through Github
>>>>
>>>> Hi,
>>>>
>>>> I think GitHub is "readonly".
>>>>
>>>> Contributions can be made with subversion:
>>>> https://openoffice.apache.org/source.html
>>>> https://openoffice.apache.org/contributing-code.html
>>>>
>>>> Or you can attach a patch file to the specific issue in Bugzilla.
>>>>
>>>> Did you test the code or would you be interested in a special
>>>> (Windows)
>>>> build?
>>>> I don't have such a fancy mouse... ;-)
>>>>
>>>> Regards,
>>>>
>>>>    Matthias
>>>>
>>>> Am 26.07.2018 um 11:21 schrieb FR web forum:
>>>>> Hello dev team,
>>>>> Is it a right way to submit patch through Github?
>>>>> https://github.com/apache/openoffice/pulls
>>>>>
>>>>> ---------------------------------------------------------------------
>>>>> To unsubscribe, e-mail: [hidden email]
>>>>> For additional commands, e-mail: [hidden email]
>>>>>
>>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: [hidden email]
>>> For additional commands, e-mail: [hidden email]
>>>
>>
>>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [hidden email]
> For additional commands, e-mail: [hidden email]
>
>


smime.p7s (5K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: Patch through Github

Matthias Seidel
Re-ping.

Do you want to commit the code by yourself? Simply let me know! ;-)

Regards,

   Matthias


Am 28.07.2018 um 11:45 schrieb Matthias Seidel:

> Have you been able to test my build?
> https://home.apache.org/~mseidel/AOO-builds/AOO-420-Test/
>
> One user already confirmed, that the mouse now shows the wanted behavior
> when scrolling horizontally.
> But it would be great if you can also confirm it.
>
> Since you don't use Subversion, I could commit the patch (by mentioning
> your name) into trunk and close the issue.
>
> Regards,
>
>    Matthias
>
> Am 26.07.2018 um 16:07 schrieb FR web forum:
>> Ah that will be fine
>> Thanks Matthias
>>
>> ----- Mail original -----
>>> De: "Matthias Seidel" <[hidden email]>
>>> À: [hidden email]
>>> Envoyé: Jeudi 26 Juillet 2018 16:03:00
>>> Objet: Re: Patch through Github
>>>
>>> Hi,
>>>
>>> Am 26.07.2018 um 15:53 schrieb FR web forum:
>>>> Thanks for this answer
>>>> I know that I can do it with SVN
>>>> But this is too heavy for me to download all aoo-trunk files.
>>>> Is it possible to create a patch from Github and then submit to BZ?
>>> I don't know.
>>>
>>> But since it is only two lines, I will include it in my next build
>>> and
>>> everyone can test it.
>>>
>>> Regards,
>>>    Matthias
>>>
>>>> ----- Mail original -----
>>>>> De: "Matthias Seidel" <[hidden email]>
>>>>> À: [hidden email]
>>>>> Envoyé: Jeudi 26 Juillet 2018 11:31:35
>>>>> Objet: Re: Patch through Github
>>>>>
>>>>> Hi,
>>>>>
>>>>> I think GitHub is "readonly".
>>>>>
>>>>> Contributions can be made with subversion:
>>>>> https://openoffice.apache.org/source.html
>>>>> https://openoffice.apache.org/contributing-code.html
>>>>>
>>>>> Or you can attach a patch file to the specific issue in Bugzilla.
>>>>>
>>>>> Did you test the code or would you be interested in a special
>>>>> (Windows)
>>>>> build?
>>>>> I don't have such a fancy mouse... ;-)
>>>>>
>>>>> Regards,
>>>>>
>>>>>    Matthias
>>>>>
>>>>> Am 26.07.2018 um 11:21 schrieb FR web forum:
>>>>>> Hello dev team,
>>>>>> Is it a right way to submit patch through Github?
>>>>>> https://github.com/apache/openoffice/pulls
>>>>>>
>>>>>> ---------------------------------------------------------------------
>>>>>> To unsubscribe, e-mail: [hidden email]
>>>>>> For additional commands, e-mail: [hidden email]
>>>>>>
>>>> ---------------------------------------------------------------------
>>>> To unsubscribe, e-mail: [hidden email]
>>>> For additional commands, e-mail: [hidden email]
>>>>
>>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: [hidden email]
>> For additional commands, e-mail: [hidden email]
>>
>>
>


smime.p7s (5K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: Patch through Github

FR web forum
Sorry for the delay
No you can commit directly.
Thanks

----- Mail original -----

> De: "Matthias Seidel" <[hidden email]>
> À: [hidden email]
> Envoyé: Mardi 7 Août 2018 12:17:42
> Objet: Re: Patch through Github
>
> Re-ping.
>
> Do you want to commit the code by yourself? Simply let me know! ;-)
>
> Regards,
>
>    Matthias
>
>
> Am 28.07.2018 um 11:45 schrieb Matthias Seidel:
> > Have you been able to test my build?
> > https://home.apache.org/~mseidel/AOO-builds/AOO-420-Test/
> >
> > One user already confirmed, that the mouse now shows the wanted
> > behavior
> > when scrolling horizontally.
> > But it would be great if you can also confirm it.
> >
> > Since you don't use Subversion, I could commit the patch (by
> > mentioning
> > your name) into trunk and close the issue.
> >
> > Regards,
> >
> >    Matthias
> >
> > Am 26.07.2018 um 16:07 schrieb FR web forum:
> >> Ah that will be fine
> >> Thanks Matthias
> >>
> >> ----- Mail original -----
> >>> De: "Matthias Seidel" <[hidden email]>
> >>> À: [hidden email]
> >>> Envoyé: Jeudi 26 Juillet 2018 16:03:00
> >>> Objet: Re: Patch through Github
> >>>
> >>> Hi,
> >>>
> >>> Am 26.07.2018 um 15:53 schrieb FR web forum:
> >>>> Thanks for this answer
> >>>> I know that I can do it with SVN
> >>>> But this is too heavy for me to download all aoo-trunk files.
> >>>> Is it possible to create a patch from Github and then submit to
> >>>> BZ?
> >>> I don't know.
> >>>
> >>> But since it is only two lines, I will include it in my next
> >>> build
> >>> and
> >>> everyone can test it.
> >>>
> >>> Regards,
> >>>    Matthias
> >>>
> >>>> ----- Mail original -----
> >>>>> De: "Matthias Seidel" <[hidden email]>
> >>>>> À: [hidden email]
> >>>>> Envoyé: Jeudi 26 Juillet 2018 11:31:35
> >>>>> Objet: Re: Patch through Github
> >>>>>
> >>>>> Hi,
> >>>>>
> >>>>> I think GitHub is "readonly".
> >>>>>
> >>>>> Contributions can be made with subversion:
> >>>>> https://openoffice.apache.org/source.html
> >>>>> https://openoffice.apache.org/contributing-code.html
> >>>>>
> >>>>> Or you can attach a patch file to the specific issue in
> >>>>> Bugzilla.
> >>>>>
> >>>>> Did you test the code or would you be interested in a special
> >>>>> (Windows)
> >>>>> build?
> >>>>> I don't have such a fancy mouse... ;-)
> >>>>>
> >>>>> Regards,
> >>>>>
> >>>>>    Matthias
> >>>>>
> >>>>> Am 26.07.2018 um 11:21 schrieb FR web forum:
> >>>>>> Hello dev team,
> >>>>>> Is it a right way to submit patch through Github?
> >>>>>> https://github.com/apache/openoffice/pulls
> >>>>>>
> >>>>>> ---------------------------------------------------------------------
> >>>>>> To unsubscribe, e-mail: [hidden email]
> >>>>>> For additional commands, e-mail:
> >>>>>> [hidden email]
> >>>>>>
> >>>> ---------------------------------------------------------------------
> >>>> To unsubscribe, e-mail: [hidden email]
> >>>> For additional commands, e-mail: [hidden email]
> >>>>
> >>>
> >> ---------------------------------------------------------------------
> >> To unsubscribe, e-mail: [hidden email]
> >> For additional commands, e-mail: [hidden email]
> >>
> >>
> >
>
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]