QA build needed for cws allocacleanup

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

QA build needed for cws allocacleanup

Maho NAKATA
Hello all,

We use function alloca, which is not a standard function of C.
problem here is: to use alloca, we include alloca.h or something like OS
dependent. This gives raise to porting issue.
For this purpose, OOo already has sal/alloca.h as a buffer.
However, we still use alloca.h in many .hxx or .cxx files, and for such
source code we have #ifdef ~ #endif to use alloca; this makes source code
dirty. I cleanuped all (two exceptions; which seems to
be the output bison?) direct inclusion of alloca.h, and use sal/alloca.h.


What I need is:
o full build by Windows/Solaris/GNU/Linux
-> IMHO buildability check is enough

I verified:
o full build by FreeBSD 5.4-RELEASE with SRC680_m138.

data
cws : cws_src680_allocacleanup
issue #i53286#
http://www.openoffice.org/issues/show_bug.cgi?id=53286
patch against SRC680_m138 (also attached at #i53286#):
http://www.openoffice.org/nonav/issues/showattachment.cgi/31248/patch-allocacleanup

Tests and suggestions are extremley appriciated.
-- NAKATA, Maho ([hidden email])

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: QA build needed for cws allocacleanup

stephan.bergmann
NAKATA Maho wrote:

> Hello all,
>
> We use function alloca, which is not a standard function of C.
> problem here is: to use alloca, we include alloca.h or something like OS
> dependent. This gives raise to porting issue.
> For this purpose, OOo already has sal/alloca.h as a buffer.
> However, we still use alloca.h in many .hxx or .cxx files, and for such
> source code we have #ifdef ~ #endif to use alloca; this makes source code
> dirty. I cleanuped all (two exceptions; which seems to
> be the output bison?) direct inclusion of alloca.h, and use sal/alloca.h.
>
>
> What I need is:
> o full build by Windows/Solaris/GNU/Linux
> -> IMHO buildability check is enough
>
> I verified:
> o full build by FreeBSD 5.4-RELEASE with SRC680_m138.
>
> data
> cws : cws_src680_allocacleanup
> issue #i53286#
> http://www.openoffice.org/issues/show_bug.cgi?id=53286
> patch against SRC680_m138 (also attached at #i53286#):
> http://www.openoffice.org/nonav/issues/showattachment.cgi/31248/patch-allocacleanup
>
> Tests and suggestions are extremley appriciated.

In case any of your changes are in UNO-specific modules:
<http://udk.openoffice.org/common/man/draft/tests.html> is a list of
more-or-less automatic tests for UNO; esp. testtools/source/bridgetest/
should be a quick and painless check to see that nothing broke...

-Stephan

> -- NAKATA, Maho ([hidden email])

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]