Re: [allsvn] r269010 - trunk/icu

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

Re: [allsvn] r269010 - trunk/icu

stephan.bergmann
Being curious, can anybody tell me what problem the below change fixed?

-Stephan

On 03/06/09 15:30, [hidden email] wrote:

> Author: releng
> Date: Fri Mar  6 14:28:05 2009
> New Revision: 269010
>
> Log:
> #i10000# fix for LD_LIBRARY_PATH
>
> Modified:
>    trunk/icu/makefile.mk
>
> Modified: trunk/icu/makefile.mk
> ==============================================================================
> --- trunk/icu/makefile.mk Fri Mar  6 13:40:34 2009 (r269009)
> +++ trunk/icu/makefile.mk Fri Mar  6 14:28:05 2009 (r269010)
> @@ -116,7 +116,7 @@
>  # note the position of the single quotes.
>  
>  BUILD_DIR=$(CONFIGURE_DIR)
> -BUILD_ACTION=$(GNUMAKE)
> +BUILD_ACTION=$(AUGMENT_LIBRARY_PATH) $(GNUMAKE)
>  OUT2LIB= \
>   $(BUILD_DIR)$/lib$/libicudata$(DLLPOST).$(ICU_MAJOR)$(ICU_MINOR).$(ICU_MICRO) \
>   $(BUILD_DIR)$/lib$/libicudata$(DLLPOST).$(ICU_MAJOR)$(ICU_MINOR) \

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: Re: [allsvn] r269010 - trunk/icu

Oliver Bolte
Hi Stephan,

Stephan Bergmann wrote:
> Being curious, can anybody tell me what problem the below change fixed?
>
> -Stephan

it fixes the missing libstdc++.so.6 problem.

Oliver

>
> On 03/06/09 15:30, [hidden email] wrote:
>> Author: releng
>> Date: Fri Mar  6 14:28:05 2009
>> New Revision: 269010
>>
>> Log:
>> #i10000# fix for LD_LIBRARY_PATH
>>
>> Modified:
>>    trunk/icu/makefile.mk
>>
>> Modified: trunk/icu/makefile.mk
>> ==============================================================================
>>
>> --- trunk/icu/makefile.mk    Fri Mar  6 13:40:34 2009    (r269009)
>> +++ trunk/icu/makefile.mk    Fri Mar  6 14:28:05 2009    (r269010)
>> @@ -116,7 +116,7 @@
>>  # note the position of the single quotes.
>>  
>>  BUILD_DIR=$(CONFIGURE_DIR)
>> -BUILD_ACTION=$(GNUMAKE)
>> +BUILD_ACTION=$(AUGMENT_LIBRARY_PATH) $(GNUMAKE)
>>  OUT2LIB= \
>>      
>> $(BUILD_DIR)$/lib$/libicudata$(DLLPOST).$(ICU_MAJOR)$(ICU_MINOR).$(ICU_MICRO)
>> \
>>      $(BUILD_DIR)$/lib$/libicudata$(DLLPOST).$(ICU_MAJOR)$(ICU_MINOR) \
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [hidden email]
> For additional commands, e-mail: [hidden email]
>

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: Re: [allsvn] r269010 - trunk/icu

stephan.bergmann
On 03/09/09 15:59, Oliver Bolte wrote:
> it fixes the missing libstdc++.so.6 problem.

I see, building OOo module icu, the icu makefiles call a program
(../bin/genpname) created during the icu build.  That program depends on
the libstdc++.so.6 from the g++ used for building.  The Sun Hamburg
build environment is set up in a way that (a) the g++ used for building
is taken from a fixed place (independent of the machine the build is
done on), (b) the libstdc++.so.6 for that g++ need not be installed in
the system directories of the machine the build is done on, and (c) the
libstdc++.so.6 for that g++ is copied to the solver lib directory early
on during the build (module so_prereq).

I consider it a little odd (but probably effective) to use
AUGMENT_LIBRARY_PATH to fix the given problem.  (Thinking about it, the
fix of adding AUGMENT_LIBRARY_PATH in front of the call to cpp.lcc was
of the same category...)

-Stephan

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]