Re: [dev] EducOOo donated code for ARM Linux port

Next Topic
 
classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

Re: [dev] EducOOo donated code for ARM Linux port

Rene Engelhard-7
On Sat, Feb 19, 2011 at 08:41:43AM +0100, eric b wrote:
> Hi,
>
> For your information :
> http://www.openoffice.org/issues/show_bug.cgi?id=117017

"EducOOo donated code for ARM Linux port" makes it sound you did the port.
Wrong. Stop your propaganda, please.

Now to the technical points:

ARM_TARGET=7

ehm, no. *If* you want to set a minimal baseline, use armv4t. Assuming anyone
has the latest and greatest ARM is bogus.

And

+    if test "x$with_arm_target" < "x6"
+       then    AC_MSG_RESULT([arm target is armv5 or inferior])
+       ARM_TARGET=5

aha, let's break even more older ARMs...

Intreresting you even dropped the correct list from your CCs (dev@porting). What does
marketing to do here instead?
Grüße/Regards,

René

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [dev] EducOOo donated code for ARM Linux port

Rene Engelhard-7
Hi,

On Sat, Feb 19, 2011 at 01:51:02PM +0100, Rene Engelhard wrote:
> ARM_TARGET=7

Oh, and this:

+# Default is armv7 mini. If you build
+# for an older version (could be slow),
+# please adapt to your needs
+
+.IF "$(ARM_TARGET)" == "ARMV6"
+ARCH_FLAGS+=-march=armv6 -mfloat-abi=softfp -D__SOFTFP__
+CDEFS+=-DARMV6
+.ENDIF
+
+.IF "$(ARM_TARGET)" == "ARMV7"
+ARCH_FLAGS+=-march=armv7-a -mtune=cortex-a8 -mfpu=neon -mfloat-abi=softfp -D__SOFTFP__
+CDEFS+=-DARMV7
+.ENDIF
+

is broken, too.
*If* you want to optimize for speed, you want hardfp, and IMHO you don't need to
specify -mfloat-abi=softfp -D__SOFTFP__ manually in either case, that's the job of your toolchain.

Grüße/Regards,

René

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [dev] EducOOo donated code for ARM Linux port

Rene Engelhard-7
On Sat, Feb 19, 2011 at 01:55:50PM +0100, Rene Engelhard wrote:
> +.IF "$(ARM_TARGET)" == "ARMV6"

This is broken, too, afaics.
In configure you set ARM_TARGET to e.g. 6 (WITHOUT ARMV)
but there you use it WITH ARMV...

Grüße/Regards,

René

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [dev] Re: [porting-dev] Re: [dev] EducOOo donated code for ARM Linux port

Rene Engelhard-7
On Sat, Feb 19, 2011 at 02:37:39PM +0100, Rene Engelhard wrote:
> On Sat, Feb 19, 2011 at 01:55:50PM +0100, Rene Engelhard wrote:
> > +.IF "$(ARM_TARGET)" == "ARMV6"
>
> This is broken, too, afaics.
> In configure you set ARM_TARGET to e.g. 6 (WITHOUT ARMV)
> but there you use it WITH ARMV...

I fixed some more (even syntax errors) in the patch, can't attach it
right now since IZ is down, but here it is.

Will attach a new patch, which
 - defaults to armv4t
 - fixes syntax errors in the patch (test has no < and > but -lt and -gt,
   -a test is broken (either && or -a without test, missing $ before build_cpu)
 - remove the "x$something" nonsense for test which doesn't play well with
   test and -lt/-gt
 - you should not assume the build_cpu is stricly arm. on my debian sid on a
   sheevaplug the triplet is armv5tel-unknown-linux-gnu when not specifying
   arm-* manually on the configure line. There's a reason we have arm* in
   configure.ins case statements :)

The original "patch" obviously wasn't tested at all...

Grüße/Regards,

René

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

arm.diff (4K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: [dev] EducOOo donated code for ARM Linux port

Rene Engelhard-7
In reply to this post by Rene Engelhard-7
On Sat, Feb 19, 2011 at 06:02:44AM -0700, Tor Lillqvist wrote:
> > "EducOOo donated code for ARM Linux port" makes it sound you did the port.
>
> Me, I didn't understand if EducOOo is the subject or object here... (And with issuezilla being down, I couldn't check the link either.) Was it donated to EducOOo, or did EducOOo donate it to somebody else? And what does "donate" mean, exactly, in the context of Open Source software? Or is this not Open Source?

According to the issue they did do some arm6/armv7 optimizations and "donated"
the change back (Though the patch was buggy and not-working, see my later
comments) but the comment made it look that they "donated (the) code for
ARM Linux port". That was what I objected to.

Grüße/Regards,

René

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]