Re: [openoffice] 01/02: Avoid comparison between pointer and integer

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

Re: [openoffice] 01/02: Avoid comparison between pointer and integer

Don Lewis-2
On 27 Oct, [hidden email] wrote:

> This is an automated email from the ASF dual-hosted git repository.
>
> arielch pushed a commit to branch trunk
> in repository https://gitbox.apache.org/repos/asf/openoffice.git
>
> commit 958717d596e223826fa78462155b4447d227e5d3
> Author: Ariel Constenla-Haile <[hidden email]>
> AuthorDate: Sun Oct 27 03:43:35 2019 -0300
>
>     Avoid comparison between pointer and integer
> ---
>  main/vcl/unx/headless/svptext.cxx | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/main/vcl/unx/headless/svptext.cxx b/main/vcl/unx/headless/svptext.cxx
> index 21e5546..e58b65f 100644
> --- a/main/vcl/unx/headless/svptext.cxx
> +++ b/main/vcl/unx/headless/svptext.cxx
> @@ -154,7 +154,7 @@ void SvpGlyphPeer::RemovingFont( ServerFont& )
>  
>  void SvpGlyphPeer::RemovingGlyph( ServerFont&, GlyphData& rGlyphData, sal_GlyphId /*aGlyphId*/ )
>  {
> -    if( rGlyphData.ExtDataRef().mpData != Format::NONE )
> +    if( rGlyphData.ExtDataRef().mpData != NULL )
>      {
>          // release the glyph related resources
>          DBG_ASSERT( (rGlyphData.ExtDataRef().meInfo <= Format::MAX), "SVP::RG() invalid alpha format" );
>

This code is actually more deeply broken.  A while ago I started
investigating a patch, but I have absolutely no idea of how to test it.
I think I sent a message to the list at the time.


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]