Re: [openoffice] branch AOO419 updated: Force SDK 10.11 at most Pass NULL, not -1 (!!)

classic Classic list List threaded Threaded
49 messages Options
123
Reply | Threaded
Open this post in threaded view
|

Re: [openoffice] branch AOO419 updated: Force SDK 10.11 at most Pass NULL, not -1 (!!)

Jim Jagielski-2
So there is for sure a bug in AOO41X, but why it only seems to affect macOS BigSur is
unknown. It is this:

> diff --git a/main/bridges/source/cpp_uno/shared/vtablefactory.cxx b/main/bridges/source/cpp_uno/shared/vtablefactory.cxx
> index f4d6c56..2ca9b8f 100644
> --- a/main/bridges/source/cpp_uno/shared/vtablefactory.cxx
> +++ b/main/bridges/source/cpp_uno/shared/vtablefactory.cxx
> @@ -195,7 +195,7 @@ VtableFactory::VtableFactory(): m_arena(
>     rtl_arena_create(
>         "bridges::cpp_uno::shared::VtableFactory",
>         sizeof (void *), // to satisfy alignment requirements
> -        0, reinterpret_cast< rtl_arena_type * >(-1), allocExec, freeExec, 0))
> +        0, reinterpret_cast< rtl_arena_type * >(0), allocExec, freeExec, 0))
> {
>     if (m_arena == 0) {
>         throw std::bad_alloc();

I *think* this solves the issue, and a quick-and-dirty compilation seems to indicate that, but
I will double check.

The question is: Does this warrant a full 4.1.9 release for ALL platforms? To my mind, it does.


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [openoffice] branch AOO419 updated: Force SDK 10.11 at most Pass NULL, not -1 (!!)

Matthias Seidel
Hi Jim,

Am 26.12.20 um 20:45 schrieb Jim Jagielski:

> So there is for sure a bug in AOO41X, but why it only seems to affect macOS BigSur is
> unknown. It is this:
>
>> diff --git a/main/bridges/source/cpp_uno/shared/vtablefactory.cxx b/main/bridges/source/cpp_uno/shared/vtablefactory.cxx
>> index f4d6c56..2ca9b8f 100644
>> --- a/main/bridges/source/cpp_uno/shared/vtablefactory.cxx
>> +++ b/main/bridges/source/cpp_uno/shared/vtablefactory.cxx
>> @@ -195,7 +195,7 @@ VtableFactory::VtableFactory(): m_arena(
>>     rtl_arena_create(
>>         "bridges::cpp_uno::shared::VtableFactory",
>>         sizeof (void *), // to satisfy alignment requirements
>> -        0, reinterpret_cast< rtl_arena_type * >(-1), allocExec, freeExec, 0))
>> +        0, reinterpret_cast< rtl_arena_type * >(0), allocExec, freeExec, 0))
>> {
>>     if (m_arena == 0) {
>>         throw std::bad_alloc();
> I *think* this solves the issue, and a quick-and-dirty compilation seems to indicate that, but
> I will double check.
>
> The question is: Does this warrant a full 4.1.9 release for ALL platforms? To my mind, it does.
I will start a test build on Windows right now...

We have a small Linux issue as well [1] and we can still put some minor
cherry-picks into this build.

+1 for a 4.1.9

Regards,

   Matthias

[1] https://bz.apache.org/ooo/show_bug.cgi?id=128413

>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [hidden email]
> For additional commands, e-mail: [hidden email]
>


smime.p7s (5K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: [openoffice] branch AOO419 updated: Force SDK 10.11 at most Pass NULL, not -1 (!!)

Marcus (OOo)
Am 26.12.20 um 21:43 schrieb Matthias Seidel:

> Am 26.12.20 um 20:45 schrieb Jim Jagielski:
>> So there is for sure a bug in AOO41X, but why it only seems to affect macOS BigSur is
>> unknown. It is this:
>>
>>> diff --git a/main/bridges/source/cpp_uno/shared/vtablefactory.cxx b/main/bridges/source/cpp_uno/shared/vtablefactory.cxx
>>> index f4d6c56..2ca9b8f 100644
>>> --- a/main/bridges/source/cpp_uno/shared/vtablefactory.cxx
>>> +++ b/main/bridges/source/cpp_uno/shared/vtablefactory.cxx
>>> @@ -195,7 +195,7 @@ VtableFactory::VtableFactory(): m_arena(
>>>      rtl_arena_create(
>>>          "bridges::cpp_uno::shared::VtableFactory",
>>>          sizeof (void *), // to satisfy alignment requirements
>>> -        0, reinterpret_cast< rtl_arena_type * >(-1), allocExec, freeExec, 0))
>>> +        0, reinterpret_cast< rtl_arena_type * >(0), allocExec, freeExec, 0))
>>> {
>>>      if (m_arena == 0) {
>>>          throw std::bad_alloc();
>> I *think* this solves the issue, and a quick-and-dirty compilation seems to indicate that, but
>> I will double check.
>>
>> The question is: Does this warrant a full 4.1.9 release for ALL platforms? To my mind, it does.

when we put in some minor bug fixes for all plattforms, then yes.
But this time they must be *really* small.

> I will start a test build on Windows right now...
>
> We have a small Linux issue as well [1] and we can still put some minor
> cherry-picks into this build.
>
> +1 for a 4.1.9
>
> [1] https://bz.apache.org/ooo/show_bug.cgi?id=128413

Yes +1

Marcus


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [openoffice] branch AOO419 updated: Force SDK 10.11 at most Pass NULL, not -1 (!!)

Rory O'Farrell
In reply to this post by Matthias Seidel
On Sat, 26 Dec 2020 21:43:06 +0100
Matthias Seidel <[hidden email]> wrote:

> Hi Jim,
>
> Am 26.12.20 um 20:45 schrieb Jim Jagielski:
> > So there is for sure a bug in AOO41X, but why it only seems to affect macOS BigSur is
> > unknown. It is this:
> >
> >> diff --git a/main/bridges/source/cpp_uno/shared/vtablefactory.cxx b/main/bridges/source/cpp_uno/shared/vtablefactory.cxx
> >> index f4d6c56..2ca9b8f 100644
> >> --- a/main/bridges/source/cpp_uno/shared/vtablefactory.cxx
> >> +++ b/main/bridges/source/cpp_uno/shared/vtablefactory.cxx
> >> @@ -195,7 +195,7 @@ VtableFactory::VtableFactory(): m_arena(
> >>     rtl_arena_create(
> >>         "bridges::cpp_uno::shared::VtableFactory",
> >>         sizeof (void *), // to satisfy alignment requirements
> >> -        0, reinterpret_cast< rtl_arena_type * >(-1), allocExec, freeExec, 0))
> >> +        0, reinterpret_cast< rtl_arena_type * >(0), allocExec, freeExec, 0))
> >> {
> >>     if (m_arena == 0) {
> >>         throw std::bad_alloc();
> > I *think* this solves the issue, and a quick-and-dirty compilation seems to indicate that, but
> > I will double check.
> >
> > The question is: Does this warrant a full 4.1.9 release for ALL platforms? To my mind, it does.
>
> I will start a test build on Windows right now...
>
> We have a small Linux issue as well [1] and we can still put some minor
> cherry-picks into this build.
>
> +1 for a 4.1.9
>
> Regards,
>
>    Matthias
>
> [1] https://bz.apache.org/ooo/show_bug.cgi?id=128413

I think all platforms should maintain the same version numbering.  

There are occasional but frequent reports on Forum of problems with tables in Writer causing crashes when they are extended to cover multiple pages; my usual advice is to limit tables to one page, and repeat the structure if needed on subsequent pages.  This seems to work; I cannot comment from personal experience as my routine work does not involve Writer tables.  If this proposed fix involves tables it may have cross-talk into the Windows and other platforms.

--
Rory O'Farrell <[hidden email]>

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [openoffice] branch AOO419 updated: Force SDK 10.11 at most Pass NULL, not -1 (!!)

Jim Jagielski
I have uploaded a test build of en-US AOO419-dev for macOS. I have confirmed on my macOS11/BigSur VM that this version opens docx files w/ no problems, edits and saves them, etc...

Please test:

    http://home.apache.org/~jim/AOO-builds/

Cheers!

> On Dec 26, 2020, at 3:54 PM, Rory O'Farrell <[hidden email]> wrote:
>
> On Sat, 26 Dec 2020 21:43:06 +0100
> Matthias Seidel <[hidden email] <mailto:[hidden email]>> wrote:
>
>> Hi Jim,
>>
>> Am 26.12.20 um 20:45 schrieb Jim Jagielski:
>>> So there is for sure a bug in AOO41X, but why it only seems to affect macOS BigSur is
>>> unknown. It is this:
>>>
>>>> diff --git a/main/bridges/source/cpp_uno/shared/vtablefactory.cxx b/main/bridges/source/cpp_uno/shared/vtablefactory.cxx
>>>> index f4d6c56..2ca9b8f 100644
>>>> --- a/main/bridges/source/cpp_uno/shared/vtablefactory.cxx
>>>> +++ b/main/bridges/source/cpp_uno/shared/vtablefactory.cxx
>>>> @@ -195,7 +195,7 @@ VtableFactory::VtableFactory(): m_arena(
>>>>    rtl_arena_create(
>>>>        "bridges::cpp_uno::shared::VtableFactory",
>>>>        sizeof (void *), // to satisfy alignment requirements
>>>> -        0, reinterpret_cast< rtl_arena_type * >(-1), allocExec, freeExec, 0))
>>>> +        0, reinterpret_cast< rtl_arena_type * >(0), allocExec, freeExec, 0))
>>>> {
>>>>    if (m_arena == 0) {
>>>>        throw std::bad_alloc();
>>> I *think* this solves the issue, and a quick-and-dirty compilation seems to indicate that, but
>>> I will double check.
>>>
>>> The question is: Does this warrant a full 4.1.9 release for ALL platforms? To my mind, it does.
>>
>> I will start a test build on Windows right now...
>>
>> We have a small Linux issue as well [1] and we can still put some minor
>> cherry-picks into this build.
>>
>> +1 for a 4.1.9
>>
>> Regards,
>>
>>    Matthias
>>
>> [1] https://bz.apache.org/ooo/show_bug.cgi?id=128413
>
> I think all platforms should maintain the same version numbering.  
>
> There are occasional but frequent reports on Forum of problems with tables in Writer causing crashes when they are extended to cover multiple pages; my usual advice is to limit tables to one page, and repeat the structure if needed on subsequent pages.  This seems to work; I cannot comment from personal experience as my routine work does not involve Writer tables.  If this proposed fix involves tables it may have cross-talk into the Windows and other platforms.
>
> --
> Rory O'Farrell <[hidden email] <mailto:[hidden email]>>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [hidden email] <mailto:[hidden email]>
> For additional commands, e-mail: [hidden email] <mailto:[hidden email]>
Reply | Threaded
Open this post in threaded view
|

Re: [openoffice] branch AOO419 updated: Force SDK 10.11 at most Pass NULL, not -1 (!!)

Jim Jagielski
In reply to this post by Matthias Seidel
BUGZ seems to be a build issue, not a code one, but it still needs to be fixed and noted, likely with some autoconf checks that fakeroot exists.

> On Dec 26, 2020, at 3:43 PM, Matthias Seidel <[hidden email]> wrote:
>
> Hi Jim,
>
> Am 26.12.20 um 20:45 schrieb Jim Jagielski:
>> So there is for sure a bug in AOO41X, but why it only seems to affect macOS BigSur is
>> unknown. It is this:
>>
>>> diff --git a/main/bridges/source/cpp_uno/shared/vtablefactory.cxx b/main/bridges/source/cpp_uno/shared/vtablefactory.cxx
>>> index f4d6c56..2ca9b8f 100644
>>> --- a/main/bridges/source/cpp_uno/shared/vtablefactory.cxx
>>> +++ b/main/bridges/source/cpp_uno/shared/vtablefactory.cxx
>>> @@ -195,7 +195,7 @@ VtableFactory::VtableFactory(): m_arena(
>>>    rtl_arena_create(
>>>        "bridges::cpp_uno::shared::VtableFactory",
>>>        sizeof (void *), // to satisfy alignment requirements
>>> -        0, reinterpret_cast< rtl_arena_type * >(-1), allocExec, freeExec, 0))
>>> +        0, reinterpret_cast< rtl_arena_type * >(0), allocExec, freeExec, 0))
>>> {
>>>    if (m_arena == 0) {
>>>        throw std::bad_alloc();
>> I *think* this solves the issue, and a quick-and-dirty compilation seems to indicate that, but
>> I will double check.
>>
>> The question is: Does this warrant a full 4.1.9 release for ALL platforms? To my mind, it does.
>
> I will start a test build on Windows right now...
>
> We have a small Linux issue as well [1] and we can still put some minor
> cherry-picks into this build.
>
> +1 for a 4.1.9
>
> Regards,
>
>    Matthias
>
> [1] https://bz.apache.org/ooo/show_bug.cgi?id=128413
>
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: [hidden email]
>> For additional commands, e-mail: [hidden email]
>>
>


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [openoffice] branch AOO419 updated: Force SDK 10.11 at most Pass NULL, not -1 (!!)

Matthias Seidel
In reply to this post by Jim Jagielski
Hi Jim,

Am 26.12.20 um 21:59 schrieb Jim Jagielski:
> I have uploaded a test build of en-US AOO419-dev for macOS. I have confirmed on my macOS11/BigSur VM that this version opens docx files w/ no problems, edits and saves them, etc...
>
> Please test:
>
>     http://home.apache.org/~jim/AOO-builds/

I will test it...

However, when we already have a new branch, we should bump up the
version numbers asap.

Matthias

>
> Cheers!
>
>> On Dec 26, 2020, at 3:54 PM, Rory O'Farrell <[hidden email]> wrote:
>>
>> On Sat, 26 Dec 2020 21:43:06 +0100
>> Matthias Seidel <[hidden email] <mailto:[hidden email]>> wrote:
>>
>>> Hi Jim,
>>>
>>> Am 26.12.20 um 20:45 schrieb Jim Jagielski:
>>>> So there is for sure a bug in AOO41X, but why it only seems to affect macOS BigSur is
>>>> unknown. It is this:
>>>>
>>>>> diff --git a/main/bridges/source/cpp_uno/shared/vtablefactory.cxx b/main/bridges/source/cpp_uno/shared/vtablefactory.cxx
>>>>> index f4d6c56..2ca9b8f 100644
>>>>> --- a/main/bridges/source/cpp_uno/shared/vtablefactory.cxx
>>>>> +++ b/main/bridges/source/cpp_uno/shared/vtablefactory.cxx
>>>>> @@ -195,7 +195,7 @@ VtableFactory::VtableFactory(): m_arena(
>>>>>    rtl_arena_create(
>>>>>        "bridges::cpp_uno::shared::VtableFactory",
>>>>>        sizeof (void *), // to satisfy alignment requirements
>>>>> -        0, reinterpret_cast< rtl_arena_type * >(-1), allocExec, freeExec, 0))
>>>>> +        0, reinterpret_cast< rtl_arena_type * >(0), allocExec, freeExec, 0))
>>>>> {
>>>>>    if (m_arena == 0) {
>>>>>        throw std::bad_alloc();
>>>> I *think* this solves the issue, and a quick-and-dirty compilation seems to indicate that, but
>>>> I will double check.
>>>>
>>>> The question is: Does this warrant a full 4.1.9 release for ALL platforms? To my mind, it does.
>>> I will start a test build on Windows right now...
>>>
>>> We have a small Linux issue as well [1] and we can still put some minor
>>> cherry-picks into this build.
>>>
>>> +1 for a 4.1.9
>>>
>>> Regards,
>>>
>>>    Matthias
>>>
>>> [1] https://bz.apache.org/ooo/show_bug.cgi?id=128413
>> I think all platforms should maintain the same version numbering.  
>>
>> There are occasional but frequent reports on Forum of problems with tables in Writer causing crashes when they are extended to cover multiple pages; my usual advice is to limit tables to one page, and repeat the structure if needed on subsequent pages.  This seems to work; I cannot comment from personal experience as my routine work does not involve Writer tables.  If this proposed fix involves tables it may have cross-talk into the Windows and other platforms.
>>
>> --
>> Rory O'Farrell <[hidden email] <mailto:[hidden email]>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: [hidden email] <mailto:[hidden email]>
>> For additional commands, e-mail: [hidden email] <mailto:[hidden email]>


smime.p7s (5K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: [openoffice] branch AOO419 updated: Force SDK 10.11 at most Pass NULL, not -1 (!!)

Matthias Seidel
In reply to this post by Jim Jagielski
Hi Jim,

Am 26.12.20 um 21:59 schrieb Jim Jagielski:
> I have uploaded a test build of en-US AOO419-dev for macOS. I have confirmed on my macOS11/BigSur VM that this version opens docx files w/ no problems, edits and saves them, etc...
>
> Please test:
>
>     http://home.apache.org/~jim/AOO-builds/

I did a quick test with your build and can confirm that it opens docx
files without problems.
This was on macOS 11.2 beta

No other file formats were tested.

Regards,

   Matthias

>
> Cheers!
>
>> On Dec 26, 2020, at 3:54 PM, Rory O'Farrell <[hidden email]> wrote:
>>
>> On Sat, 26 Dec 2020 21:43:06 +0100
>> Matthias Seidel <[hidden email] <mailto:[hidden email]>> wrote:
>>
>>> Hi Jim,
>>>
>>> Am 26.12.20 um 20:45 schrieb Jim Jagielski:
>>>> So there is for sure a bug in AOO41X, but why it only seems to affect macOS BigSur is
>>>> unknown. It is this:
>>>>
>>>>> diff --git a/main/bridges/source/cpp_uno/shared/vtablefactory.cxx b/main/bridges/source/cpp_uno/shared/vtablefactory.cxx
>>>>> index f4d6c56..2ca9b8f 100644
>>>>> --- a/main/bridges/source/cpp_uno/shared/vtablefactory.cxx
>>>>> +++ b/main/bridges/source/cpp_uno/shared/vtablefactory.cxx
>>>>> @@ -195,7 +195,7 @@ VtableFactory::VtableFactory(): m_arena(
>>>>>    rtl_arena_create(
>>>>>        "bridges::cpp_uno::shared::VtableFactory",
>>>>>        sizeof (void *), // to satisfy alignment requirements
>>>>> -        0, reinterpret_cast< rtl_arena_type * >(-1), allocExec, freeExec, 0))
>>>>> +        0, reinterpret_cast< rtl_arena_type * >(0), allocExec, freeExec, 0))
>>>>> {
>>>>>    if (m_arena == 0) {
>>>>>        throw std::bad_alloc();
>>>> I *think* this solves the issue, and a quick-and-dirty compilation seems to indicate that, but
>>>> I will double check.
>>>>
>>>> The question is: Does this warrant a full 4.1.9 release for ALL platforms? To my mind, it does.
>>> I will start a test build on Windows right now...
>>>
>>> We have a small Linux issue as well [1] and we can still put some minor
>>> cherry-picks into this build.
>>>
>>> +1 for a 4.1.9
>>>
>>> Regards,
>>>
>>>    Matthias
>>>
>>> [1] https://bz.apache.org/ooo/show_bug.cgi?id=128413
>> I think all platforms should maintain the same version numbering.  
>>
>> There are occasional but frequent reports on Forum of problems with tables in Writer causing crashes when they are extended to cover multiple pages; my usual advice is to limit tables to one page, and repeat the structure if needed on subsequent pages.  This seems to work; I cannot comment from personal experience as my routine work does not involve Writer tables.  If this proposed fix involves tables it may have cross-talk into the Windows and other platforms.
>>
>> --
>> Rory O'Farrell <[hidden email] <mailto:[hidden email]>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: [hidden email] <mailto:[hidden email]>
>> For additional commands, e-mail: [hidden email] <mailto:[hidden email]>


smime.p7s (5K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: [openoffice] branch AOO419 updated: Force SDK 10.11 at most Pass NULL, not -1 (!!)

Peter Kovacs-3
In reply to this post by Jim Jagielski-2

On 26.12.20 20:45, Jim Jagielski wrote:

> So there is for sure a bug in AOO41X, but why it only seems to affect macOS BigSur is
> unknown. It is this:
>
>> diff --git a/main/bridges/source/cpp_uno/shared/vtablefactory.cxx b/main/bridges/source/cpp_uno/shared/vtablefactory.cxx
>> index f4d6c56..2ca9b8f 100644
>> --- a/main/bridges/source/cpp_uno/shared/vtablefactory.cxx
>> +++ b/main/bridges/source/cpp_uno/shared/vtablefactory.cxx
>> @@ -195,7 +195,7 @@ VtableFactory::VtableFactory(): m_arena(
>>      rtl_arena_create(
>>          "bridges::cpp_uno::shared::VtableFactory",
>>          sizeof (void *), // to satisfy alignment requirements
>> -        0, reinterpret_cast< rtl_arena_type * >(-1), allocExec, freeExec, 0))
>> +        0, reinterpret_cast< rtl_arena_type * >(0), allocExec, freeExec, 0))
>> {
>>      if (m_arena == 0) {
>>          throw std::bad_alloc();
> I *think* this solves the issue, and a quick-and-dirty compilation seems to indicate that, but
> I will double check.
>
> The question is: Does this warrant a full 4.1.9 release for ALL platforms? To my mind, it does.

yes we should go for 4.1.9 because there is no other way to fix this
quickly.

Any one has any Idea what the rtl_arena_create
<http://opengrok.openoffice.org/openoffice/s?refs=rtl_arena_create&project=trunk>does?
It looks to me like some C-Style factory, but I have a hard time
understanding the code.

And so far I did not find an explanation for it.

>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [hidden email]
> For additional commands, e-mail: [hidden email]
>
--
This is the Way! http://www.apache.org/theapacheway/index.html
Reply | Threaded
Open this post in threaded view
|

AOO 4.1.9 Info

Jim Jagielski
The AOO419 branch has been created.
The version numbers, et.al. have been bumped.
The Release Status page has been cloned: https://cwiki.apache.org/confluence/display/OOOUSERS/AOO+4.1.9
---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [openoffice] branch AOO419 updated: Force SDK 10.11 at most Pass NULL, not -1 (!!)

Arrigo Marchiori
In reply to this post by Peter Kovacs-3
On Sun, Dec 27, 2020 at 01:46:46PM +0100, Peter Kovacs wrote:

> On 26.12.20 20:45, Jim Jagielski wrote:
> > So there is for sure a bug in AOO41X, but why it only seems to affect macOS BigSur is
> > unknown. It is this:
> >
> > > diff --git a/main/bridges/source/cpp_uno/shared/vtablefactory.cxx b/main/bridges/source/cpp_uno/shared/vtablefactory.cxx
> > > index f4d6c56..2ca9b8f 100644
> > > --- a/main/bridges/source/cpp_uno/shared/vtablefactory.cxx
> > > +++ b/main/bridges/source/cpp_uno/shared/vtablefactory.cxx
> > > @@ -195,7 +195,7 @@ VtableFactory::VtableFactory(): m_arena(
> > >      rtl_arena_create(
> > >          "bridges::cpp_uno::shared::VtableFactory",
> > >          sizeof (void *), // to satisfy alignment requirements
> > > -        0, reinterpret_cast< rtl_arena_type * >(-1), allocExec, freeExec, 0))
> > > +        0, reinterpret_cast< rtl_arena_type * >(0), allocExec, freeExec, 0))
> > > {
> > >      if (m_arena == 0) {
> > >          throw std::bad_alloc();
> > I *think* this solves the issue, and a quick-and-dirty compilation seems to indicate that, but
> > I will double check.
> >
> > The question is: Does this warrant a full 4.1.9 release for ALL platforms? To my mind, it does.

My question is also: How has it possibly worked until today? :-)

> yes we should go for 4.1.9 because there is no other way to fix this
> quickly.

I also agree.

> Any one has any Idea what the rtl_arena_create <http://opengrok.openoffice.org/openoffice/s?refs=rtl_arena_create&project=trunk>does?
> It looks to me like some C-Style factory, but I have a hard time
> understanding the code.
>
> And so far I did not find an explanation for it.

I tried to look into it. I am not an expert of this low-level stuff,
but ``arena'''s seem to be an alternative to calling plain malloc(3)
and free(3).  They support a minimum size ("quantum") and some sort of
caching, that I could not fully understand.

They are somewhat chained among each other (each arena has a
``source''), with the ``public'' base object being gp_default_arena [1]
and two ``private'' objects being gp_arena_arena and gp_machdep_arena
inside /trunk/main/sal/rtl/source/alloc_arena.c

gp_machdep_arena is the ``source'' for the others, and it is
responsible of the actual allocation using function
rtl_machdep_alloc() [2]. Under Unix it cals mmap(2). Under Win32 it
calls VirtualAlloc() and under OS/2 it calls valloc().

Incidentally, the choice of mmap(2) over malloc(3) should be for
performance reasons, see [3]. It's a new thing I learned today ;-)

File main/bridges/source/cpp_uno/shared/vtablefactory.cxx declares its
own allocation function [4] that enables execution from the allocated
buffers (if I understood correctly).

I hope this makes sense.

References:

 1: http://opengrok.openoffice.org/xref/trunk/main/sal/rtl/source/alloc_arena.h?r=514f4c20#126
 
 2: http://opengrok.openoffice.org/xref/trunk/main/sal/rtl/source/alloc_arena.c?r=509a48ff#1182

 3: https://stackoverflow.com/questions/1739296/malloc-vs-mmap-in-c

 4: http://opengrok.openoffice.org/xref/trunk/main/bridges/source/cpp_uno/shared/vtablefactory.cxx?r=858958ab#77

--
Arrigo

http://rigo.altervista.org

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: AOO 4.1.9 Info

Matthias Seidel
In reply to this post by Jim Jagielski
Hi all,

Am 27.12.20 um 14:49 schrieb Jim Jagielski:
> The AOO419 branch has been created.
> The version numbers, et.al. have been bumped.
> The Release Status page has been cloned: https://cwiki.apache.org/confluence/display/OOOUSERS/AOO+4.1.9

First test builds for Windows are available at:

https://home.apache.org/~mseidel/AOO-builds/AOO-419-Test/

Regards,

   Matthias

> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [hidden email]
> For additional commands, e-mail: [hidden email]
>


smime.p7s (5K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: AOO 4.1.9 Info

Marcus (OOo)
In reply to this post by Jim Jagielski
Am 27.12.20 um 14:49 schrieb Jim Jagielski:
> The AOO419 branch has been created.
> The version numbers, et.al. have been bumped.
> The Release Status page has been cloned: https://cwiki.apache.org/confluence/display/OOOUSERS/AOO+4.1.9

thanks a lot for making this effort - and to wear the release manager
hat one more time. :-)

Marcus


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: AOO 4.1.9 Info

Keith N. McKenna
In reply to this post by Matthias Seidel
On 12/28/2020 5:11 AM, Matthias Seidel wrote:

> Hi all,
>
> Am 27.12.20 um 14:49 schrieb Jim Jagielski:
>> The AOO419 branch has been created.
>> The version numbers, et.al. have been bumped.
>> The Release Status page has been cloned: https://cwiki.apache.org/confluence/display/OOOUSERS/AOO+4.1.9
>
> First test builds for Windows are available at:
>
> https://home.apache.org/~mseidel/AOO-builds/AOO-419-Test/
>
> Regards,
>
>    Matthias
>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: [hidden email]
>> For additional commands, e-mail: [hidden email]
>>
> Attached is my QA report for 4.1.9 based on Matthias's 2020-12-29. I
would appreciate someone checking the issues I point out as I have been
experiencing occasional oddities with my system of late.

Regards
Keith

Verification_Report.odt (48K) Download Attachment
signature.asc (499 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: AOO 4.1.9 Info

Matthias Seidel
Hi Keith,

Just did a quick test with AOO 4.1.9 on Windows 7.

Clipboard works as expected for me.

Regarding the locked files, did you edit bootstrap.ini after "setup /a" ?

I will do some more tests (next year) with multi install on Windows 10.

Regards,

   Matthias

Am 31.12.20 um 00:59 schrieb Keith N. McKenna:

> On 12/28/2020 5:11 AM, Matthias Seidel wrote:
>> Hi all,
>>
>> Am 27.12.20 um 14:49 schrieb Jim Jagielski:
>>> The AOO419 branch has been created.
>>> The version numbers, et.al. have been bumped.
>>> The Release Status page has been cloned: https://cwiki.apache.org/confluence/display/OOOUSERS/AOO+4.1.9
>> First test builds for Windows are available at:
>>
>> https://home.apache.org/~mseidel/AOO-builds/AOO-419-Test/
>>
>> Regards,
>>
>>    Matthias
>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: [hidden email]
>>> For additional commands, e-mail: [hidden email]
>>>
>> Attached is my QA report for 4.1.9 based on Matthias's 2020-12-29. I
> would appreciate someone checking the issues I point out as I have been
> experiencing occasional oddities with my system of late.
>
> Regards
> Keith


smime.p7s (5K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: AOO 4.1.9 Info

Keith N. McKenna
On 12/30/2020 7:17 PM, Matthias Seidel wrote:
> Hi Keith,
>
> Just did a quick test with AOO 4.1.9 on Windows 7.
>
> Clipboard works as expected for me.
>
> Regarding the locked files, did you edit bootstrap.ini after "setup /a"

No simply did setup /a and it installed it with the profile in the same
folder.
>
> I will do some more tests (next year) with multi install on Windows 10.

Thank you Matthias. I will boot up my old windows 7 machine and try
testing it there as sell

Regards
Keith

>
> Regards,
>
>    Matthias
>
> Am 31.12.20 um 00:59 schrieb Keith N. McKenna:
>> On 12/28/2020 5:11 AM, Matthias Seidel wrote:
>>> Hi all,
>>>
>>> Am 27.12.20 um 14:49 schrieb Jim Jagielski:
>>>> The AOO419 branch has been created.
>>>> The version numbers, et.al. have been bumped.
>>>> The Release Status page has been cloned: https://cwiki.apache.org/confluence/display/OOOUSERS/AOO+4.1.9
>>> First test builds for Windows are available at:
>>>
>>> https://home.apache.org/~mseidel/AOO-builds/AOO-419-Test/
>>>
>>> Regards,
>>>
>>>    Matthias
>>>
>>>> ---------------------------------------------------------------------
>>>> To unsubscribe, e-mail: [hidden email]
>>>> For additional commands, e-mail: [hidden email]
>>>>
>>> Attached is my QA report for 4.1.9 based on Matthias's 2020-12-29. I
>> would appreciate someone checking the issues I point out as I have been
>> experiencing occasional oddities with my system of late.
>>
>> Regards
>> Keith
>


signature.asc (499 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: AOO 4.1.9 Info

Matthias Seidel
Hi Keith,

Am 31.12.20 um 04:43 schrieb Keith N. McKenna:

> On 12/30/2020 7:17 PM, Matthias Seidel wrote:
>> Hi Keith,
>>
>> Just did a quick test with AOO 4.1.9 on Windows 7.
>>
>> Clipboard works as expected for me.
>>
>> Regarding the locked files, did you edit bootstrap.ini after "setup /a"
> No simply did setup /a and it installed it with the profile in the same
> folder.
That may be the problem, you have to change the bootstrap.ini, otherwise
you use the wrong AOO profile.
>> I will do some more tests (next year) with multi install on Windows 10.
> Thank you Matthias. I will boot up my old windows 7 machine and try
> testing it there as sell

I now tested on Windows 10 with multiple AOO installations (4.1.8,
4.1.9, 4.2.0) and could not see a regression.

@all: Maybe some other can also test? I don't feel comfortable if we are
only two persons...

Regards,

   Matthias

>
> Regards
> Keith
>
>> Regards,
>>
>>    Matthias
>>
>> Am 31.12.20 um 00:59 schrieb Keith N. McKenna:
>>> On 12/28/2020 5:11 AM, Matthias Seidel wrote:
>>>> Hi all,
>>>>
>>>> Am 27.12.20 um 14:49 schrieb Jim Jagielski:
>>>>> The AOO419 branch has been created.
>>>>> The version numbers, et.al. have been bumped.
>>>>> The Release Status page has been cloned: https://cwiki.apache.org/confluence/display/OOOUSERS/AOO+4.1.9
>>>> First test builds for Windows are available at:
>>>>
>>>> https://home.apache.org/~mseidel/AOO-builds/AOO-419-Test/
>>>>
>>>> Regards,
>>>>
>>>>    Matthias
>>>>
>>>>> ---------------------------------------------------------------------
>>>>> To unsubscribe, e-mail: [hidden email]
>>>>> For additional commands, e-mail: [hidden email]
>>>>>
>>>> Attached is my QA report for 4.1.9 based on Matthias's 2020-12-29. I
>>> would appreciate someone checking the issues I point out as I have been
>>> experiencing occasional oddities with my system of late.
>>>
>>> Regards
>>> Keith
>


smime.p7s (5K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: AOO 4.1.9 Info

Keith N. McKenna
On 1/2/2021 11:07 AM, Matthias Seidel wrote:

> Hi Keith,
>
> Am 31.12.20 um 04:43 schrieb Keith N. McKenna:
>> On 12/30/2020 7:17 PM, Matthias Seidel wrote:
>>> Hi Keith,
>>>
>>> Just did a quick test with AOO 4.1.9 on Windows 7.
>>>
>>> Clipboard works as expected for me.
>>>
>>> Regarding the locked files, did you edit bootstrap.ini after "setup /a"
>> No simply did setup /a and it installed it with the profile in the same
>> folder.
> That may be the problem, you have to change the bootstrap.ini, otherwise
> you use the wrong AOO profile.
>>> I will do some more tests (next year) with multi install on Windows 10.
>> Thank you Matthias. I will boot up my old windows 7 machine and try
>> testing it there as sell
>
> I now tested on Windows 10 with multiple AOO installations (4.1.8,
> 4.1.9, 4.2.0) and could not see a regression.
>
> @all: Maybe some other can also test? I don't feel comfortable if we are
> only two persons...
>
> Regards,
>
>    Matthias
>
>>
Changing bootstrap.ini did the track and all problems disappeared. What
I do not understand is why. Leaving bootstrap.ini as is should just
point it to the standard profile

>> Regards
>> Keith
>>
>>> Regards,
>>>
>>>    Matthias
>>>
>>> Am 31.12.20 um 00:59 schrieb Keith N. McKenna:
>>>> On 12/28/2020 5:11 AM, Matthias Seidel wrote:
>>>>> Hi all,
>>>>>
>>>>> Am 27.12.20 um 14:49 schrieb Jim Jagielski:
>>>>>> The AOO419 branch has been created.
>>>>>> The version numbers, et.al. have been bumped.
>>>>>> The Release Status page has been cloned: https://cwiki.apache.org/confluence/display/OOOUSERS/AOO+4.1.9
>>>>> First test builds for Windows are available at:
>>>>>
>>>>> https://home.apache.org/~mseidel/AOO-builds/AOO-419-Test/
>>>>>
>>>>> Regards,
>>>>>
>>>>>    Matthias
>>>>>
>>>>>> ---------------------------------------------------------------------
>>>>>> To unsubscribe, e-mail: [hidden email]
>>>>>> For additional commands, e-mail: [hidden email]
>>>>>>
>>>>> Attached is my QA report for 4.1.9 based on Matthias's 2020-12-29. I
>>>> would appreciate someone checking the issues I point out as I have been
>>>> experiencing occasional oddities with my system of late.
>>>>
>>>> Regards
>>>> Keith
>>
>


signature.asc (499 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: AOO 4.1.9 Info

Dave Fisher-3


Sent from my iPhone

> On Jan 2, 2021, at 11:43 AM, Keith N. McKenna <[hidden email]> wrote:
>
> On 1/2/2021 11:07 AM, Matthias Seidel wrote:
>> Hi Keith,
>>
>>> Am 31.12.20 um 04:43 schrieb Keith N. McKenna:
>>> On 12/30/2020 7:17 PM, Matthias Seidel wrote:
>>>> Hi Keith,
>>>>
>>>> Just did a quick test with AOO 4.1.9 on Windows 7.
>>>>
>>>> Clipboard works as expected for me.
>>>>
>>>> Regarding the locked files, did you edit bootstrap.ini after "setup /a"
>>> No simply did setup /a and it installed it with the profile in the same
>>> folder.
>> That may be the problem, you have to change the bootstrap.ini, otherwise
>> you use the wrong AOO profile.
>>>> I will do some more tests (next year) with multi install on Windows 10.
>>> Thank you Matthias. I will boot up my old windows 7 machine and try
>>> testing it there as sell
>>
>> I now tested on Windows 10 with multiple AOO installations (4.1.8,
>> 4.1.9, 4.2.0) and could not see a regression.
>>
>> @all: Maybe some other can also test? I don't feel comfortable if we are
>> only two persons...
>>
>> Regards,
>>
>>    Matthias
>>
>>>
> Changing bootstrap.ini did the track and all problems disappeared. What
> I do not understand is why. Leaving bootstrap.ini as is should just
> point it to the standard profile

Could it be because this is a Developer Build?

Regards,
Dave

>
>>> Regards
>>> Keith
>>>
>>>> Regards,
>>>>
>>>>    Matthias
>>>>
>>>> Am 31.12.20 um 00:59 schrieb Keith N. McKenna:
>>>>> On 12/28/2020 5:11 AM, Matthias Seidel wrote:
>>>>>> Hi all,
>>>>>>
>>>>>> Am 27.12.20 um 14:49 schrieb Jim Jagielski:
>>>>>>> The AOO419 branch has been created.
>>>>>>> The version numbers, et.al. have been bumped.
>>>>>>> The Release Status page has been cloned: https://cwiki.apache.org/confluence/display/OOOUSERS/AOO+4.1.9
>>>>>> First test builds for Windows are available at:
>>>>>>
>>>>>> https://home.apache.org/~mseidel/AOO-builds/AOO-419-Test/
>>>>>>
>>>>>> Regards,
>>>>>>
>>>>>>    Matthias
>>>>>>
>>>>>>> ---------------------------------------------------------------------
>>>>>>> To unsubscribe, e-mail: [hidden email]
>>>>>>> For additional commands, e-mail: [hidden email]
>>>>>>>
>>>>>> Attached is my QA report for 4.1.9 based on Matthias's 2020-12-29. I
>>>>> would appreciate someone checking the issues I point out as I have been
>>>>> experiencing occasional oddities with my system of late.
>>>>>
>>>>> Regards
>>>>> Keith
>>>
>>
>
>


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: AOO 4.1.9 Info

Matthias Seidel
Hi Dave,

Am 02.01.21 um 21:00 schrieb Dave Fisher:

>
> Sent from my iPhone
>
>> On Jan 2, 2021, at 11:43 AM, Keith N. McKenna <[hidden email]> wrote:
>>
>> On 1/2/2021 11:07 AM, Matthias Seidel wrote:
>>> Hi Keith,
>>>
>>>> Am 31.12.20 um 04:43 schrieb Keith N. McKenna:
>>>> On 12/30/2020 7:17 PM, Matthias Seidel wrote:
>>>>> Hi Keith,
>>>>>
>>>>> Just did a quick test with AOO 4.1.9 on Windows 7.
>>>>>
>>>>> Clipboard works as expected for me.
>>>>>
>>>>> Regarding the locked files, did you edit bootstrap.ini after "setup /a"
>>>> No simply did setup /a and it installed it with the profile in the same
>>>> folder.
>>> That may be the problem, you have to change the bootstrap.ini, otherwise
>>> you use the wrong AOO profile.
>>>>> I will do some more tests (next year) with multi install on Windows 10.
>>>> Thank you Matthias. I will boot up my old windows 7 machine and try
>>>> testing it there as sell
>>> I now tested on Windows 10 with multiple AOO installations (4.1.8,
>>> 4.1.9, 4.2.0) and could not see a regression.
>>>
>>> @all: Maybe some other can also test? I don't feel comfortable if we are
>>> only two persons...
>>>
>>> Regards,
>>>
>>>    Matthias
>>>
>> Changing bootstrap.ini did the track and all problems disappeared. What
>> I do not understand is why. Leaving bootstrap.ini as is should just
>> point it to the standard profile
> Could it be because this is a Developer Build?
The Windows builds are *not* Developer Builds.

Dev Builds have enough problems of their own, so I am building close to
the release builds, only branding them as "Developer Test Builds".

Regards,

   Matthias

>
> Regards,
> Dave
>
>>>> Regards
>>>> Keith
>>>>
>>>>> Regards,
>>>>>
>>>>>    Matthias
>>>>>
>>>>> Am 31.12.20 um 00:59 schrieb Keith N. McKenna:
>>>>>> On 12/28/2020 5:11 AM, Matthias Seidel wrote:
>>>>>>> Hi all,
>>>>>>>
>>>>>>> Am 27.12.20 um 14:49 schrieb Jim Jagielski:
>>>>>>>> The AOO419 branch has been created.
>>>>>>>> The version numbers, et.al. have been bumped.
>>>>>>>> The Release Status page has been cloned: https://cwiki.apache.org/confluence/display/OOOUSERS/AOO+4.1.9
>>>>>>> First test builds for Windows are available at:
>>>>>>>
>>>>>>> https://home.apache.org/~mseidel/AOO-builds/AOO-419-Test/
>>>>>>>
>>>>>>> Regards,
>>>>>>>
>>>>>>>    Matthias
>>>>>>>
>>>>>>>> ---------------------------------------------------------------------
>>>>>>>> To unsubscribe, e-mail: [hidden email]
>>>>>>>> For additional commands, e-mail: [hidden email]
>>>>>>>>
>>>>>>> Attached is my QA report for 4.1.9 based on Matthias's 2020-12-29. I
>>>>>> would appreciate someone checking the issues I point out as I have been
>>>>>> experiencing occasional oddities with my system of late.
>>>>>>
>>>>>> Regards
>>>>>> Keith
>>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [hidden email]
> For additional commands, e-mail: [hidden email]
>


smime.p7s (5K) Download Attachment
123