Re: [porting-cvs] CVS update [mws_oof680]: /porting/sal/osl/w32/process.c

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

Re: [porting-cvs] CVS update [mws_oof680]: /porting/sal/osl/w32/process.c

stephan.bergmann
[hidden email] wrote:

> Tag: mws_oof680
> User: obo    
> Date: 2007-05-08 11:02:26+0000
> Log:
>  INTEGRATION: CWS hro15 (1.32.134); FILE MERGED
>  2007/04/26 11:58:51 hro 1.32.134.1: #i59521 Always use complete command line and ignore osl_setCommandArgs to provide UTF-16 support
>
> File Changes:
>
> Directory: /porting/sal/osl/w32/
> ================================
>
> File [changed]: process.c
> Url: http://porting.openoffice.org/source/browse/porting/sal/osl/w32/process.c?r1=1.32&r2=1.32.86.1
> Delta lines:  +9 -7
> -------------------
> --- process.c 2006-06-20 04:21:44+0000 1.32
> +++ process.c 2007-05-08 11:02:24+0000 1.32.86.1
> @@ -264,22 +264,22 @@
>   0
>  };
>  
> +#pragma warning( push )
> +#pragma warning( disable: 4100 )
>  static rtl_uString ** osl_createCommandArgs_Impl (int argc, char ** argv)

As I already communicated off line, it would be better to use the
techniques described at
<http://wiki.services.openoffice.org/wiki/Writing_warning-free_code#Unused_parameters>,
or just fix that static function.

-Stephan

[...]

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]