Re: [porting-cvs] CVS update: /porting/sal/rtl/source/

classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

Re: [porting-cvs] CVS update: /porting/sal/rtl/source/

James Mckenzie
vg:

It would be nice to know why you made this change sinch the cws associated with it
did not go through.

Reply via PM is acceptable.

James McKenzie


-----Original Message-----

>From: [hidden email]
>Sent: Apr 13, 2007 9:02 AM
>To: [hidden email]
>Subject: [porting-cvs] CVS update: /porting/sal/rtl/source/
>
>User: vg      
>Date: 2007/04/13 09:02:06
>
>Modified:
>   porting/sal/rtl/source/ustring.c
>
>Log:
> #i76245#
>
>File Changes:
>
>Directory: /porting/sal/rtl/source/
>===================================
>
>File [changed]: ustring.c
>Url: http://porting.openoffice.org/source/browse/porting/sal/rtl/source/ustring.c?r1=1.26&r2=1.27
>Delta lines:  +6 -6
>-------------------
>--- ustring.c 3 Apr 2007 14:06:19 -0000 1.26
>+++ ustring.c 13 Apr 2007 16:02:04 -0000 1.27
>@@ -4,9 +4,9 @@
>  *
>  *  $RCSfile: ustring.c,v $
>  *
>- *  $Revision: 1.26 $
>+ *  $Revision: 1.27 $
>  *
>- *  last change: $Author: rt $ $Date: 2007/04/03 14:06:19 $
>+ *  last change: $Author: vg $ $Date: 2007/04/13 16:02:04 $
>  *
>  *  The Contents of this file are made available subject to
>  *  the terms of GNU Lesser General Public License Version 2.1.
>@@ -76,9 +76,9 @@
>  */
> static rtl_uString const aImplEmpty_rtl_uString =
> {
>-    SAL_STRING_STATIC_FLAG|1, /* sal_Int32    refCount;   */
>-    0,                        /* sal_Int32    length;     */
>-    { 0 }                     /* sal_Unicode  buffer[1];  */
>+    (sal_Int32) (SAL_STRING_INTERN_FLAG|SAL_STRING_STATIC_FLAG|1), /*sal_Int32    refCount; */
>+    0,                                               /*sal_Int32    length;   */
>+    { 0 }                                            /*sal_Unicode  buffer[1];*/
> };
>
> /* ======================================================================= */
>
>
>
>
>---------------------------------------------------------------------
>To unsubscribe, e-mail: [hidden email]
>For additional commands, e-mail: [hidden email]
>

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: Re: [porting-cvs] CVS update: /porting/sal/rtl/source/

Pavel Janík
Hi James,

> It would be nice to know why you made this change sinch the cws  
> associated with it
> did not go through.

as you can see in EIS, this issue (#i76245#) is associated with cws  
src680m209masterfix thus it was fixed directly on master and it will  
be included in SRC680_m209.
--
Pavel Janík


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: Re: [porting-cvs] CVS update: /porting/sal/rtl/source/

James Mckenzie
In reply to this post by James Mckenzie
Pavel:

Thank you.  Is it usual to fix a problem directly on the master?

James McKenzie


-----Original Message-----

>From: Pavel Janík <[hidden email]>
>Sent: Apr 13, 2007 11:05 PM
>To: [hidden email]
>Subject: Re: [porting-dev] Re: [porting-cvs] CVS update: /porting/sal/rtl/source/
>
>Hi James,
>
>> It would be nice to know why you made this change sinch the cws  
>> associated with it
>> did not go through.
>
>as you can see in EIS, this issue (#i76245#) is associated with cws  
>src680m209masterfix thus it was fixed directly on master and it will  
>be included in SRC680_m209.
>--
>Pavel Janík
>
>
>---------------------------------------------------------------------
>To unsubscribe, e-mail: [hidden email]
>For additional commands, e-mail: [hidden email]
>

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: Re: [porting-cvs] CVS update: /porting/sal/rtl/source/

Rüdiger Timm
In reply to this post by James Mckenzie
In case the build breaks on a master milestone (and we notive that) it
is common practise that RE fixes such problems on the master before the
milestone gets announced as 'ready for use'.
You may query EIS for childworkspaces with status 'fixed on master' or
named '<mws><milestone>masterfix' to see how often that happens.

Rüdiger


James Mckenzie wrote:

> Pavel:
>
> Thank you.  Is it usual to fix a problem directly on the master?
>
> James McKenzie
>
>
> -----Original Message-----
>> From: Pavel Janík <[hidden email]>
>> Sent: Apr 13, 2007 11:05 PM
>> To: [hidden email]
>> Subject: Re: [porting-dev] Re: [porting-cvs] CVS update: /porting/sal/rtl/source/
>>
>> Hi James,
>>
>>> It would be nice to know why you made this change sinch the cws  
>>> associated with it
>>> did not go through.
>> as you can see in EIS, this issue (#i76245#) is associated with cws  
>> src680m209masterfix thus it was fixed directly on master and it will  
>> be included in SRC680_m209.
>> --
>> Pavel Janík
>>

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]