Re: [sw-issues] [Issue 115174] Crash when opening odt document having a lot of graphics and Redlines

classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

Re: [sw-issues] [Issue 115174] Crash when opening odt document having a lot of graphics and Redlines

Mike Kierna
Please, REMOVE ME FROM THE E-MAIL LISTING'S !!!!!!!!!! Your system has literally
locked up my e-mail system in both Yahoo and Google to the point that both
system's mailbox's are in permanent 'load' cycle. And who ever came up with this
system needs to be locked in an elevator and left to listen to the music for a
week.





________________________________
From: "[hidden email]" <[hidden email]>
To: [hidden email]
Sent: Wed, December 22, 2010 1:14:31 PM
Subject: [sw-issues] [Issue 115174] Crash when opening odt document having a lot
of graphics and Redlines

To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=115174


User mst changed the following:

                What    |Old value                |New value
================================================================================
                      CC|'od'                      |'mib,od'
--------------------------------------------------------------------------------
                  Status|NEW                      |RESOLVED
--------------------------------------------------------------------------------
              Resolution|                          |FIXED
--------------------------------------------------------------------------------




------- Additional comments from [hidden email] Wed Dec 22 18:14:28 +0000
2010 -------
the following fragment causes the crash:

<text:p text:style-name="newP183">
  <text:span text:style-name="newAttribute">full</text:span>
  specifies a full circle or ellipse, like
  <draw:circle draw:style-name="newgr1" draw:text-style-name="P2227"
draw:z-index="0" svg:height="0.5cm" svg:width="0.5cm"
text:anchor-type="as-char">
    <text:p>
      <text:change-start text:change-id="ct5853"/>
      <text:change-end text:change-id="ct5853"/>
    </text:p>
  </draw:circle>
  .
</text:p>


OOo crashes on reading the text:change-end element.

(gdb) bt
#1  0xb155def6 in SwXTextRange::GetDoc (this=0x0)
    at sw/source/core/unocore/unoobj2.cxx:893
#2  0xb181436c in lcl_GetDocViaTunnel (rRange=...)
    at sw/source/filter/xml/XMLRedlineImportHelper.cxx:87
#3  0xb181442c in XTextRangeOrNodeIndexPosition::GetDoc (this=0xb00ac7b0)
    at sw/source/filter/xml/XMLRedlineImportHelper.cxx:197
#4  0xb1814689 in XMLRedlineImportHelper::InsertIntoDocument (this=0xb051ea50,
    pRedlineInfo=0xb00ac794)
    at sw/source/filter/xml/XMLRedlineImportHelper.cxx:612

the problem is that lcl_GetDocViaTunnel expects the
XTextRange to be a SwXTextRange, but it is not:

(gdb) p *xTunnel._pInterface
$2 = (SvxUnoTextRange) {

this is apparently because the text:p is inside a draw:circle.
according to cl OOo currently does not support change tracking
inside drawing objects anyway, so the easiest fix is to just
not import the tracked change if the XTextRange does not belong
to writer.


fixed in cws sw34bf03
http://hg.services.openoffice.org/hg/cws/sw34bf03/rev/bc5dd26cbd6f

---------------------------------------------------------------------
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]


Reply | Threaded
Open this post in threaded view
|

Re: [sw-issues] [Issue 115174] Crash when opening odt document having a lot of graphics and Redlines

Mathias Bauer
Hi Mike,

you must do that by yourself. All postings in the mailing lists have a
footer with a link for unsubscribing. If you click on it, a mail is
created that you must send. But make sure that your "from" mail address
in this mail is the one that you have used when you subscribed.

Regards,
Mathias

On 23.12.2010 00:22, Mike Kierna wrote:

> Please, REMOVE ME FROM THE E-MAIL LISTING'S !!!!!!!!!! Your system has literally
> locked up my e-mail system in both Yahoo and Google to the point that both
> system's mailbox's are in permanent 'load' cycle. And who ever came up with this
> system needs to be locked in an elevator and left to listen to the music for a
> week.
>
>
>
>
>
> ________________________________
> From: "[hidden email]"<[hidden email]>
> To: [hidden email]
> Sent: Wed, December 22, 2010 1:14:31 PM
> Subject: [sw-issues] [Issue 115174] Crash when opening odt document having a lot
> of graphics and Redlines
>
> To comment on the following update, log in, then open the issue:
> http://www.openoffice.org/issues/show_bug.cgi?id=115
>
>
> User mst changed the following:
>
>                  What    |Old value                |New value
> ================================================================================
>                        CC|'od'                      |'mib,od'
> --------------------------------------------------------------------------------
>                    Status|NEW                      |RESOLVED
> --------------------------------------------------------------------------------
>                Resolution|                          |FIXED
> --------------------------------------------------------------------------------
>
>
>
>
> ------- Additional comments from [hidden email] Wed Dec 22 18:14:28 +0000
> 2010 -------
> the following fragment causes the crash:
>
> <text:p text:style-name="newP183">
>    <text:span text:style-name="newAttribute">full</text:span>
>    specifies a full circle or ellipse, like
>    <draw:circle draw:style-name="newgr1" draw:text-style-name="P2227"
> draw:z-index="0" svg:height="0.5cm" svg:width="0.5cm"
> text:anchor-type="as-char">
>      <text:p>
>        <text:change-start text:change-id="ct5853"/>
>        <text:change-end text:change-id="ct5853"/>
>      </text:p>
>    </draw:circle>
>    .
> </text:p>
>
>
> OOo crashes on reading the text:change-end element.
>
> (gdb) bt
> #1  0xb155def6 in SwXTextRange::GetDoc (this=0x0)
>      at sw/source/core/unocore/unoobj2.cxx:893
> #2  0xb181436c in lcl_GetDocViaTunnel (rRange=...)
>      at sw/source/filter/xml/XMLRedlineImportHelper.cxx:87
> #3  0xb181442c in XTextRangeOrNodeIndexPosition::GetDoc (this=0xb00ac7b0)
>      at sw/source/filter/xml/XMLRedlineImportHelper.cxx:197
> #4  0xb1814689 in XMLRedlineImportHelper::InsertIntoDocument (this=0xb051ea50,
>      pRedlineInfo=0xb00ac794)
>      at sw/source/filter/xml/XMLRedlineImportHelper.cxx:612
>
> the problem is that lcl_GetDocViaTunnel expects the
> XTextRange to be a SwXTextRange, but it is not:
>
> (gdb) p *xTunnel._pInterface
> $2 = (SvxUnoTextRange) {
>
> this is apparently because the text:p is inside a draw:circle.
> according to cl OOo currently does not support change tracking
> inside drawing objects anyway, so the easiest fix is to just
> not import the tracked change if the XTextRange does not belong
> to writer.
>
>
> fixed in cws sw34bf03
> http://hg.services.openoffice.org/hg/cws/sw34bf03/rev/bc5dd26cbd6f
>
> ---------------------------------------------------------------------
> Please do not reply to this automatically generated notification from
> Issue Tracker. Please log onto the website and enter your comments.
> http://qa.openoffice.org/issue_handling/project_issues.html#notification
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [hidden email]
> For additional commands, e-mail: [hidden email]
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [hidden email]
> For additional commands, e-mail: [hidden email]
>
>
>


--
Mathias Bauer (mba) - Project Lead OpenOffice.org Writer
OpenOffice.org Engineering at Oracle: http://blogs.sun.com/GullFOSS
Please don't reply to "[hidden email]".
I use it for the OOo lists and only rarely read other mails sent to it.

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]