Remove main/crashrep?

classic Classic list List threaded Threaded
8 messages Options
Reply | Threaded
Open this post in threaded view
|

Remove main/crashrep?

Matthias Seidel
Hi all,

The crash report tool was abandoned some years ago. Help files were
removed in 2014:
https://bz.apache.org/ooo/show_bug.cgi?id=125696

Now I simply removed the directory main/crashrep from my build tree
(AOO42X) and still could build successfully.

So my question is, can it be safely removed? That would free some space
and remove unused strings for translation.

Regards,

   Matthias



smime.p7s (5K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: Remove main/crashrep?

Marcus (OOo)
Am 28.01.19 um 23:54 schrieb Matthias Seidel:
> The crash report tool was abandoned some years ago. Help files were
> removed in 2014:
> https://bz.apache.org/ooo/show_bug.cgi?id=125696
>
> Now I simply removed the directory main/crashrep from my build tree
> (AOO42X) and still could build successfully.
>
> So my question is, can it be safely removed? That would free some space
> and remove unused strings for translation.

Without a details search in the code I wouldn't do this for 4.2.0 but in
trunk. Then we can do more tests over the time. I don't know how this
feature was done and is still linked within the OpenOffice code.

My 2ct.

Marcus


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: Remove main/crashrep?

Matthias Seidel
Hi Marcus,

Am 30.01.19 um 19:37 schrieb Marcus:

> Am 28.01.19 um 23:54 schrieb Matthias Seidel:
>> The crash report tool was abandoned some years ago. Help files were
>> removed in 2014:
>> https://bz.apache.org/ooo/show_bug.cgi?id=125696
>>
>> Now I simply removed the directory main/crashrep from my build tree
>> (AOO42X) and still could build successfully.
>>
>> So my question is, can it be safely removed? That would free some space
>> and remove unused strings for translation.
>
> Without a details search in the code I wouldn't do this for 4.2.0 but
> in trunk. Then we can do more tests over the time. I don't know how
> this feature was done and is still linked within the OpenOffice code.
Of course this would be something for trunk.
If it does no harm and other tests are successful we can backport it
later to 4.2.x.

Kay was involved during that time, maybe she knows more details?

Regards,

   Matthias

>
> My 2ct.
>
> Marcus
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [hidden email]
> For additional commands, e-mail: [hidden email]
>


smime.p7s (5K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: Remove main/crashrep?

Marcus (OOo)
Am 30.01.19 um 21:07 schrieb Matthias Seidel:

> Am 30.01.19 um 19:37 schrieb Marcus:
>> Am 28.01.19 um 23:54 schrieb Matthias Seidel:
>>> The crash report tool was abandoned some years ago. Help files were
>>> removed in 2014:
>>> https://bz.apache.org/ooo/show_bug.cgi?id=125696
>>>
>>> Now I simply removed the directory main/crashrep from my build tree
>>> (AOO42X) and still could build successfully.
>>>
>>> So my question is, can it be safely removed? That would free some space
>>> and remove unused strings for translation.
>>
>> Without a details search in the code I wouldn't do this for 4.2.0 but
>> in trunk. Then we can do more tests over the time. I don't know how
>> this feature was done and is still linked within the OpenOffice code.
>
> Of course this would be something for trunk.

you wrote about AOO42X, so I wasn't sure.

> If it does no harm and other tests are successful we can backport it
> later to 4.2.x.

Yes, this could be an option.

> Kay was involved during that time, maybe she knows more details?

Ah great, let's see. ;-)

Marcus


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: Remove main/crashrep?

Kay Schenk-2

On 1/30/19 1:06 PM, Marcus wrote:

> Am 30.01.19 um 21:07 schrieb Matthias Seidel:
>> Am 30.01.19 um 19:37 schrieb Marcus:
>>> Am 28.01.19 um 23:54 schrieb Matthias Seidel:
>>>> The crash report tool was abandoned some years ago. Help files were
>>>> removed in 2014:
>>>> https://bz.apache.org/ooo/show_bug.cgi?id=125696
>>>>
>>>> Now I simply removed the directory main/crashrep from my build tree
>>>> (AOO42X) and still could build successfully.
>>>>
>>>> So my question is, can it be safely removed? That would free some space
>>>> and remove unused strings for translation.
>>>
>>> Without a details search in the code I wouldn't do this for 4.2.0 but
>>> in trunk. Then we can do more tests over the time. I don't know how
>>> this feature was done and is still linked within the OpenOffice code.
>>
>> Of course this would be something for trunk.
>
> you wrote about AOO42X, so I wasn't sure.
>
>> If it does no harm and other tests are successful we can backport it
>> later to 4.2.x.
>
> Yes, this could be an option.
>
>> Kay was involved during that time, maybe she knows more details?
>
> Ah great, let's see. ;-)
>
> Marcus

Hi...
Well this was some time ago. As Marcus points out, you need to
investigate the dependencies on the module before eliminating it. I
recall starting to do that at some point, but I don't remember anything
about the outcome. Likely I found it too complicated to determine and
that's why I just eliminated what I did. With the build process now
moving to gbuild, determining module dependencies will be different than
they were in 2014. This is about all the information I can give at the
moment. ;)

--Kay

>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [hidden email]
> For additional commands, e-mail: [hidden email]
>

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: Remove main/crashrep?

Damjan Jovanovic
In reply to this post by Matthias Seidel
On Tue, Jan 29, 2019 at 12:54 AM Matthias Seidel <[hidden email]>
wrote:

> Hi all,
>
> The crash report tool was abandoned some years ago. Help files were
> removed in 2014:
> https://bz.apache.org/ooo/show_bug.cgi?id=125696
>
> Now I simply removed the directory main/crashrep from my build tree
> (AOO42X) and still could build successfully.
>
> So my question is, can it be safely removed? That would free some space
> and remove unused strings for translation.
>
>
My vote would be: ABSOLUTELY NOT!

This is C++, there is no Exception.printStackTrace() when things go wrong,
there is no cross-platform remote debugging. What are we going to do when
users come back to us crying how "it crashed"? With a stack trace, we know
where to look, and even if there are no debug symbols, we at least know
which module crashed. Without a stack trace, the best we can hope for is to
reproduce the problem ourselves while running in a debugger.

We absolutely need a user-friendly crash reporter, especially after so many
changes, with the upcoming Win64 port, with the port to newer MSVC, and
many other changes that will destabilize the codebase further.

Yes the crashreporter tool wasn't great, it didn't work on Mac, it required
some webservice to submit reports to, but so what? It's just code. We could
just make it print a textual report that users can copy and paste into
Bugzilla.

That crashreporter stands between us and chaos.


Prior threads discussing it:

29 May 2012
“How to enable crash log for AOO3.4?”
http://mail-archives.apache.org/mod_mbox/openoffice-dev/201205.mbox/%3cCAGSaLEqZaw12nYE089iDRJY=Bb0AXQujePnAdvG25vrW0LN-oQ@...%3e

22 October 2014
“crash reporter -- can someone supply commit information on this?”
http://mail-archives.apache.org/mod_mbox/openoffice-dev/201410.mbox/%3C544838E3.6050600%40gmail.com%3E


Regards
Damjan
Reply | Threaded
Open this post in threaded view
|

Re: Remove main/crashrep?

Matthias Seidel
Hi Damjan,

Am 31.01.19 um 18:36 schrieb Damjan Jovanovic:

> On Tue, Jan 29, 2019 at 12:54 AM Matthias Seidel <[hidden email]>
> wrote:
>
>> Hi all,
>>
>> The crash report tool was abandoned some years ago. Help files were
>> removed in 2014:
>> https://bz.apache.org/ooo/show_bug.cgi?id=125696
>>
>> Now I simply removed the directory main/crashrep from my build tree
>> (AOO42X) and still could build successfully.
>>
>> So my question is, can it be safely removed? That would free some space
>> and remove unused strings for translation.
>>
>>
> My vote would be: ABSOLUTELY NOT!
>
> This is C++, there is no Exception.printStackTrace() when things go wrong,
> there is no cross-platform remote debugging. What are we going to do when
> users come back to us crying how "it crashed"? With a stack trace, we know
> where to look, and even if there are no debug symbols, we at least know
> which module crashed. Without a stack trace, the best we can hope for is to
> reproduce the problem ourselves while running in a debugger.
>
> We absolutely need a user-friendly crash reporter, especially after so many
> changes, with the upcoming Win64 port, with the port to newer MSVC, and
> many other changes that will destabilize the codebase further.
I see your point.
>
> Yes the crashreporter tool wasn't great, it didn't work on Mac, it required
> some webservice to submit reports to, but so what? It's just code. We could
> just make it print a textual report that users can copy and paste into
> Bugzilla.

Then let's get it functional again. Indeed a simple text file would
really be helpful for bug reports.

Later, we can update/re-enable the help pages again.

Regards,

   Matthias

>
> That crashreporter stands between us and chaos.
>
>
> Prior threads discussing it:
>
> 29 May 2012
> “How to enable crash log for AOO3.4?”
> http://mail-archives.apache.org/mod_mbox/openoffice-dev/201205.mbox/%3cCAGSaLEqZaw12nYE089iDRJY=Bb0AXQujePnAdvG25vrW0LN-oQ@...%3e
>
> 22 October 2014
> “crash reporter -- can someone supply commit information on this?”
> http://mail-archives.apache.org/mod_mbox/openoffice-dev/201410.mbox/%3C544838E3.6050600%40gmail.com%3E
>
>
> Regards
> Damjan
>


smime.p7s (5K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: Remove main/crashrep?

Peter Kovacs-3
Can someone then open up a bugzilla report and file the action points
what needs to be done?

We have a bunch of bugs that are pointing towards crash the
crashreporter. Should we set those on obsolete and start fresh?


On 31.01.19 18:58, Matthias Seidel wrote:

> Hi Damjan,
>
> Am 31.01.19 um 18:36 schrieb Damjan Jovanovic:
>> On Tue, Jan 29, 2019 at 12:54 AM Matthias Seidel <[hidden email]>
>> wrote:
>>
>>> Hi all,
>>>
>>> The crash report tool was abandoned some years ago. Help files were
>>> removed in 2014:
>>> https://bz.apache.org/ooo/show_bug.cgi?id=125696
>>>
>>> Now I simply removed the directory main/crashrep from my build tree
>>> (AOO42X) and still could build successfully.
>>>
>>> So my question is, can it be safely removed? That would free some space
>>> and remove unused strings for translation.
>>>
>>>
>> My vote would be: ABSOLUTELY NOT!
>>
>> This is C++, there is no Exception.printStackTrace() when things go wrong,
>> there is no cross-platform remote debugging. What are we going to do when
>> users come back to us crying how "it crashed"? With a stack trace, we know
>> where to look, and even if there are no debug symbols, we at least know
>> which module crashed. Without a stack trace, the best we can hope for is to
>> reproduce the problem ourselves while running in a debugger.
>>
>> We absolutely need a user-friendly crash reporter, especially after so many
>> changes, with the upcoming Win64 port, with the port to newer MSVC, and
>> many other changes that will destabilize the codebase further.
> I see your point.
>> Yes the crashreporter tool wasn't great, it didn't work on Mac, it required
>> some webservice to submit reports to, but so what? It's just code. We could
>> just make it print a textual report that users can copy and paste into
>> Bugzilla.
> Then let's get it functional again. Indeed a simple text file would
> really be helpful for bug reports.
>
> Later, we can update/re-enable the help pages again.
>
> Regards,
>
>    Matthias
>
>> That crashreporter stands between us and chaos.
>>
>>
>> Prior threads discussing it:
>>
>> 29 May 2012
>> “How to enable crash log for AOO3.4?”
>> http://mail-archives.apache.org/mod_mbox/openoffice-dev/201205.mbox/%3cCAGSaLEqZaw12nYE089iDRJY=Bb0AXQujePnAdvG25vrW0LN-oQ@...%3e
>>
>> 22 October 2014
>> “crash reporter -- can someone supply commit information on this?”
>> http://mail-archives.apache.org/mod_mbox/openoffice-dev/201410.mbox/%3C544838E3.6050600%40gmail.com%3E
>>
>>
>> Regards
>> Damjan
>>

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]