Shall "dmake clean" also remove "$INPATH.pro" directories?

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

Shall "dmake clean" also remove "$INPATH.pro" directories?

Arrigo Marchiori
Dear All,

we recently fixed the "dmake clean" problem that deleted the whole
source tree, in certain condition, instead of the $INPATH directories
[1].

Shall the command also delete the "$INPATH.pro" directories?  On my
system, they are:

./main/apache-commons/unxlngx6.pro
./main/solenv/unxlngx6.pro
./main/stlport/unxlngx6.pro
./main/test/unxlngx6.pro
./main/mythes/unxlngx6.pro
./ext_libraries/apr/unxlngx6.pro
./ext_libraries/coinmp/unxlngx6.pro
./ext_libraries/gtest/unxlngx6.pro
./ext_libraries/apr-util/unxlngx6.pro
...and many more.

If anyone can confirm this would be a desirable behavior, I can fix it
in the trunk branch. I am still struggling to understand the build
system.

Best regards.

References:

1: https://github.com/apache/openoffice/pull/113
   and incidentally: https://bz.apache.org/ooo/show_bug.cgi?id=124263
--
Arrigo

http://rigo.altervista.org

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: Shall "dmake clean" also remove "$INPATH.pro" directories?

Peter Kovacs-3
Hi

On 01.01.21 18:41, Arrigo Marchiori wrote:

> Dear All,
>
> we recently fixed the "dmake clean" problem that deleted the whole
> source tree, in certain condition, instead of the $INPATH directories
> [1].
>
> Shall the command also delete the "$INPATH.pro" directories?  On my
> system, they are:
>
> ./main/apache-commons/unxlngx6.pro
> ./main/solenv/unxlngx6.pro
> ./main/stlport/unxlngx6.pro
> ./main/test/unxlngx6.pro
> ./main/mythes/unxlngx6.pro
> ./ext_libraries/apr/unxlngx6.pro
> ./ext_libraries/coinmp/unxlngx6.pro
> ./ext_libraries/gtest/unxlngx6.pro
> ./ext_libraries/apr-util/unxlngx6.pro
> ...and many more.
>
> If anyone can confirm this would be a desirable behavior, I can fix it
> in the trunk branch. I am still struggling to understand the build
> system.

removing this bit is desirable. I do not want to claim I understand it,
but I what happens is that each module (apache-commons, solenv, stport, ...)

will be "independently" build in its folder. In the end there is a
deliverabe step which copies everything into the final structure.

The Idea behind this construct is to speed up development time. Lets say
you want to work on one module. Then youcreate a complete build of
OpenOffice.

Afterwards you CD into your module you want to work on, chenge your
stuff, and then simply rebuild only the module. However since the
dependants may break

the build is more a pragmatic approach to the long build times instead.
Just think in the past they were even longer.

Check incompatible and compatible builds on
https://wiki.openoffice.org/wiki/Documentation/Building_Guide_AOO for
more details.


HTH

Peter

--
This is the Way! http://www.apache.org/theapacheway/index.html

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: Shall "dmake clean" also remove "$INPATH.pro" directories?

Arrigo Marchiori
On Wed, Jan 06, 2021 at 08:40:51PM +0100, Peter Kovacs wrote:

> Hi
>
> On 01.01.21 18:41, Arrigo Marchiori wrote:
> > Dear All,
> >
> > we recently fixed the "dmake clean" problem that deleted the whole
> > source tree, in certain condition, instead of the $INPATH directories
> > [1].
> >
> > Shall the command also delete the "$INPATH.pro" directories?  On my
> > system, they are:
> >
> > ./main/apache-commons/unxlngx6.pro
> > ./main/solenv/unxlngx6.pro
> > ./main/stlport/unxlngx6.pro
> > ./main/test/unxlngx6.pro
> > ./main/mythes/unxlngx6.pro
> > ./ext_libraries/apr/unxlngx6.pro
> > ./ext_libraries/coinmp/unxlngx6.pro
> > ./ext_libraries/gtest/unxlngx6.pro
> > ./ext_libraries/apr-util/unxlngx6.pro
> > ...and many more.
> >
> > If anyone can confirm this would be a desirable behavior, I can fix it
> > in the trunk branch. I am still struggling to understand the build
> > system.
>
> removing this bit is desirable. I do not want to claim I understand it, but
> I what happens is that each module (apache-commons, solenv, stport, ...)
> will be "independently" build in its folder. In the end there is a
> deliverabe step which copies everything into the final structure.
>
> The Idea behind this construct is to speed up development time. Lets say you
> want to work on one module. Then youcreate a complete build of OpenOffice.
>
> Afterwards you CD into your module you want to work on, chenge your stuff,
> and then simply rebuild only the module. However since the dependants may
> break
> the build is more a pragmatic approach to the long build times instead. Just
> think in the past they were even longer.
>
> Check incompatible and compatible builds on
> https://wiki.openoffice.org/wiki/Documentation/Building_Guide_AOO for more
> details.

Thank you very much for your detailed answer.  It helped me to
understand that "dmake clean" already deletes what it should, as I
confused the INPATH and OUTPATH variables (the formed ends in ".pro",
the latter not, but it is never used).

Sorry for the noise,
--
Arrigo

http://rigo.altervista.org

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]