Small regression in trunk

classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

Small regression in trunk

Matthias Seidel
Hi Damjan,

Is there a specific reason why you moved "sd/res/imagelst" to
"sd/imagelst" in this commit:

https://github.com/apache/openoffice/commit/b63233d868a9af170b0457a7aa0c5809011cc2c1

The reason why I ask is that it breaks some icons in Draw/Impress
(Classic and Industrial icon set) and in help.

If the change is mandatory, I would fix the location for the icon sets
and the paths in Help.

Regards,

   Matthias



smime.p7s (5K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: Small regression in trunk

Damjan Jovanovic
On Mon, May 11, 2020 at 5:25 PM Matthias Seidel <[hidden email]>
wrote:

> Hi Damjan,
>
> Is there a specific reason why you moved "sd/res/imagelst" to
> "sd/imagelst" in this commit:
>
>
> https://github.com/apache/openoffice/commit/b63233d868a9af170b0457a7aa0c5809011cc2c1
>
> The reason why I ask is that it breaks some icons in Draw/Impress
> (Classic and Industrial icon set) and in help.
>
> If the change is mandatory, I would fix the location for the icon sets
> and the paths in Help.
>
>
Hi

I can't remember, but looking through the git log, I see this which might
explain it:

commit c11f6e41367333ceec3dd9cdcb59a80bff914618
Author: damjan <damjan@13f79535-47bb-0310-9956-ffa450edef68>
Date:   Wed Mar 16 03:50:45 2016 +0000

    Merge from branches/gbuild:
    * r1409617: sd2gbuild: removed unneeded Package_misc.mk
    * r1409614: sd2gbuild: removed not needed effects.xsl
    * r1409613: sd2gbuild: cleanup after migration to gbuild
    * r1409612: sd2gbuild: migrated sd to gbuild
    * r1409611: sd2gbuild: migrated sd to gbuild
    * r1409608: sd2gbuild: migrated module sd to gbuild

    Also updated lists of files (deleted and added by eg. sidebar)
    and had to rename
    main/default_images/sd/res/imagelst
    to
    main/default_images/sd/imglst
    to get it to build with gbuild (sw did the same).

    BUILDS

    Build updates by: me
Reply | Threaded
Open this post in threaded view
|

Re: Small regression in trunk

Matthias Seidel
Hi Damjan,

Am 11.05.20 um 17:48 schrieb Damjan Jovanovic:

> On Mon, May 11, 2020 at 5:25 PM Matthias Seidel <[hidden email]>
> wrote:
>
>> Hi Damjan,
>>
>> Is there a specific reason why you moved "sd/res/imagelst" to
>> "sd/imagelst" in this commit:
>>
>>
>> https://github.com/apache/openoffice/commit/b63233d868a9af170b0457a7aa0c5809011cc2c1
>>
>> The reason why I ask is that it breaks some icons in Draw/Impress
>> (Classic and Industrial icon set) and in help.
>>
>> If the change is mandatory, I would fix the location for the icon sets
>> and the paths in Help.
>>
>>
> Hi
>
> I can't remember, but looking through the git log, I see this which might
> explain it:
>
> commit c11f6e41367333ceec3dd9cdcb59a80bff914618
> Author: damjan <damjan@13f79535-47bb-0310-9956-ffa450edef68>
> Date:   Wed Mar 16 03:50:45 2016 +0000
>
>     Merge from branches/gbuild:
>     * r1409617: sd2gbuild: removed unneeded Package_misc.mk
>     * r1409614: sd2gbuild: removed not needed effects.xsl
>     * r1409613: sd2gbuild: cleanup after migration to gbuild
>     * r1409612: sd2gbuild: migrated sd to gbuild
>     * r1409611: sd2gbuild: migrated sd to gbuild
>     * r1409608: sd2gbuild: migrated module sd to gbuild
>
>     Also updated lists of files (deleted and added by eg. sidebar)
>     and had to rename
>     main/default_images/sd/res/imagelst
>     to
>     main/default_images/sd/imglst
>     to get it to build with gbuild (sw did the same).
>
>     BUILDS
>
>     Build updates by: me
OK, thanks!

Then I will do some small fixes in "/ooo_custom_images" and help.

That said, of course I will wait until Jim has branched off Dev2. ;-)

Regards,

   Matthias

>


smime.p7s (5K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: Small regression in trunk

Matthias Seidel
Hi Damjan, all,

Am 11.05.20 um 17:54 schrieb Matthias Seidel:

> Hi Damjan,
>
> Am 11.05.20 um 17:48 schrieb Damjan Jovanovic:
>> On Mon, May 11, 2020 at 5:25 PM Matthias Seidel <[hidden email]>
>> wrote:
>>
>>> Hi Damjan,
>>>
>>> Is there a specific reason why you moved "sd/res/imagelst" to
>>> "sd/imagelst" in this commit:
>>>
>>>
>>> https://github.com/apache/openoffice/commit/b63233d868a9af170b0457a7aa0c5809011cc2c1
>>>
>>> The reason why I ask is that it breaks some icons in Draw/Impress
>>> (Classic and Industrial icon set) and in help.
>>>
>>> If the change is mandatory, I would fix the location for the icon sets
>>> and the paths in Help.
>>>
>>>
>> Hi
>>
>> I can't remember, but looking through the git log, I see this which might
>> explain it:
>>
>> commit c11f6e41367333ceec3dd9cdcb59a80bff914618
>> Author: damjan <damjan@13f79535-47bb-0310-9956-ffa450edef68>
>> Date:   Wed Mar 16 03:50:45 2016 +0000
>>
>>     Merge from branches/gbuild:
>>     * r1409617: sd2gbuild: removed unneeded Package_misc.mk
>>     * r1409614: sd2gbuild: removed not needed effects.xsl
>>     * r1409613: sd2gbuild: cleanup after migration to gbuild
>>     * r1409612: sd2gbuild: migrated sd to gbuild
>>     * r1409611: sd2gbuild: migrated sd to gbuild
>>     * r1409608: sd2gbuild: migrated module sd to gbuild
>>
>>     Also updated lists of files (deleted and added by eg. sidebar)
>>     and had to rename
>>     main/default_images/sd/res/imagelst
>>     to
>>     main/default_images/sd/imglst
>>     to get it to build with gbuild (sw did the same).
>>
>>     BUILDS
>>
>>     Build updates by: me
> OK, thanks!
>
> Then I will do some small fixes in "/ooo_custom_images" and help.
>
> That said, of course I will wait until Jim has branched off Dev2. ;-)
>
> Regards,
>
>    Matthias
This should be fixed now in trunk and AOO42X...

In Draw/Impress, when using Navigator, all icons are now according to
the chosen icon set again.

Regards,

   Matthias

>


smime.p7s (5K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: Small regression in trunk

Damjan Jovanovic-2
On Mon, May 18, 2020 at 9:41 AM Matthias Seidel <[hidden email]>
wrote:

> Hi Damjan, all,
>
> Am 11.05.20 um 17:54 schrieb Matthias Seidel:
> > Hi Damjan,
> >
> > Am 11.05.20 um 17:48 schrieb Damjan Jovanovic:
> >> On Mon, May 11, 2020 at 5:25 PM Matthias Seidel <
> [hidden email]>
> >> wrote:
> >>
> >>> Hi Damjan,
> >>>
> >>> Is there a specific reason why you moved "sd/res/imagelst" to
> >>> "sd/imagelst" in this commit:
> >>>
> >>>
> >>>
> https://github.com/apache/openoffice/commit/b63233d868a9af170b0457a7aa0c5809011cc2c1
> >>>
> >>> The reason why I ask is that it breaks some icons in Draw/Impress
> >>> (Classic and Industrial icon set) and in help.
> >>>
> >>> If the change is mandatory, I would fix the location for the icon sets
> >>> and the paths in Help.
> >>>
> >>>
> >> Hi
> >>
> >> I can't remember, but looking through the git log, I see this which
> might
> >> explain it:
> >>
> >> commit c11f6e41367333ceec3dd9cdcb59a80bff914618
> >> Author: damjan <damjan@13f79535-47bb-0310-9956-ffa450edef68>
> >> Date:   Wed Mar 16 03:50:45 2016 +0000
> >>
> >>     Merge from branches/gbuild:
> >>     * r1409617: sd2gbuild: removed unneeded Package_misc.mk
> >>     * r1409614: sd2gbuild: removed not needed effects.xsl
> >>     * r1409613: sd2gbuild: cleanup after migration to gbuild
> >>     * r1409612: sd2gbuild: migrated sd to gbuild
> >>     * r1409611: sd2gbuild: migrated sd to gbuild
> >>     * r1409608: sd2gbuild: migrated module sd to gbuild
> >>
> >>     Also updated lists of files (deleted and added by eg. sidebar)
> >>     and had to rename
> >>     main/default_images/sd/res/imagelst
> >>     to
> >>     main/default_images/sd/imglst
> >>     to get it to build with gbuild (sw did the same).
> >>
> >>     BUILDS
> >>
> >>     Build updates by: me
> > OK, thanks!
> >
> > Then I will do some small fixes in "/ooo_custom_images" and help.
> >
> > That said, of course I will wait until Jim has branched off Dev2. ;-)
> >
> > Regards,
> >
> >    Matthias
>
> This should be fixed now in trunk and AOO42X...
>
> In Draw/Impress, when using Navigator, all icons are now according to
> the chosen icon set again.
>
> Regards,
>
>    Matthias
>
>
Great :)

Damjan