URGENT: Need to build new version based on 4.1.4

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
73 messages Options
1234
Reply | Threaded
Open this post in threaded view
|

URGENT: Need to build new version based on 4.1.4

Patricia Shanahan
There is a bug in my LinkManager changes. Specifically, I made the
totally newbie mistake of accessing memory based on a pointer without
allowing for it being null, and it turns out it can be null :-(

The primary report for this is
https://bz.apache.org/ooo/show_bug.cgi?id=127581, "Writer crashes after
copying all content".

I would have expected the failure to be some form of access violation.
However, recent e-mails have convinced me that some paths include catch
blocks that conceal all exceptions, so it may be the root cause of other
problems.

I have checked a fix into the trunk, revision 1814994. However, trunk
has other changes.

The simplest way to check whether other bug reports are due to this is
to build a version that is identical to 4.1.4 except for the one fix.
Anything that works with that but not with 4.1.4 is a duplicate. Of
course, the more duplicates we have the worse the problem and the more
urgent a fix.

I am going ahead and doing the fix in my 4.1.5 working copy, but
activating 4.1.5 is a broader decision.


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: URGENT: Need to build new version based on 4.1.4

Patricia Shanahan
I'm attaching the patch in case anyone else wants to build their own
test version.

On 11/18/2017 11:11 AM, Patricia Shanahan wrote:

> There is a bug in my LinkManager changes. Specifically, I made the
> totally newbie mistake of accessing memory based on a pointer without
> allowing for it being null, and it turns out it can be null :-(
>
> The primary report for this is
> https://bz.apache.org/ooo/show_bug.cgi?id=127581, "Writer crashes after
> copying all content".
>
> I would have expected the failure to be some form of access violation.
> However, recent e-mails have convinced me that some paths include catch
> blocks that conceal all exceptions, so it may be the root cause of other
> problems.
>
> I have checked a fix into the trunk, revision 1814994. However, trunk
> has other changes.
>
> The simplest way to check whether other bug reports are due to this is
> to build a version that is identical to 4.1.4 except for the one fix.
> Anything that works with that but not with 4.1.4 is a duplicate. Of
> course, the more duplicates we have the worse the problem and the more
> urgent a fix.
>
> I am going ahead and doing the fix in my 4.1.5 working copy, but
> activating 4.1.5 is a broader decision.
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [hidden email]
> For additional commands, e-mail: [hidden email]
>


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

null_pointer.patch (930 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: URGENT: Need to build new version based on 4.1.4

Jim Jagielski
In reply to this post by Patricia Shanahan
We do have the AOO415 branch! :)

> On Nov 18, 2017, at 2:11 PM, Patricia Shanahan <[hidden email]> wrote:
>
> There is a bug in my LinkManager changes. Specifically, I made the totally newbie mistake of accessing memory based on a pointer without allowing for it being null, and it turns out it can be null :-(
>
> The primary report for this is https://bz.apache.org/ooo/show_bug.cgi?id=127581, "Writer crashes after copying all content".
>
> I would have expected the failure to be some form of access violation. However, recent e-mails have convinced me that some paths include catch blocks that conceal all exceptions, so it may be the root cause of other problems.
>
> I have checked a fix into the trunk, revision 1814994. However, trunk has other changes.
>
> The simplest way to check whether other bug reports are due to this is to build a version that is identical to 4.1.4 except for the one fix. Anything that works with that but not with 4.1.4 is a duplicate. Of course, the more duplicates we have the worse the problem and the more urgent a fix.
>
> I am going ahead and doing the fix in my 4.1.5 working copy, but activating 4.1.5 is a broader decision.
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [hidden email]
> For additional commands, e-mail: [hidden email]
>


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: URGENT: Need to build new version based on 4.1.4

Patricia Shanahan
I see you have checked in some Mac building changes. Would it be better
to keep the two fixes separate, or encourage testing both of them together?

On 11/18/2017 1:20 PM, Jim Jagielski wrote:

> We do have the AOO415 branch! :)
>
>> On Nov 18, 2017, at 2:11 PM, Patricia Shanahan <[hidden email]> wrote:
>>
>> There is a bug in my LinkManager changes. Specifically, I made the totally newbie mistake of accessing memory based on a pointer without allowing for it being null, and it turns out it can be null :-(
>>
>> The primary report for this is https://bz.apache.org/ooo/show_bug.cgi?id=127581, "Writer crashes after copying all content".
>>
>> I would have expected the failure to be some form of access violation. However, recent e-mails have convinced me that some paths include catch blocks that conceal all exceptions, so it may be the root cause of other problems.
>>
>> I have checked a fix into the trunk, revision 1814994. However, trunk has other changes.
>>
>> The simplest way to check whether other bug reports are due to this is to build a version that is identical to 4.1.4 except for the one fix. Anything that works with that but not with 4.1.4 is a duplicate. Of course, the more duplicates we have the worse the problem and the more urgent a fix.
>>
>> I am going ahead and doing the fix in my 4.1.5 working copy, but activating 4.1.5 is a broader decision.
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: [hidden email]
>> For additional commands, e-mail: [hidden email]
>>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [hidden email]
> For additional commands, e-mail: [hidden email]
>

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: URGENT: Need to build new version based on 4.1.4

Peter Kovacs-3
 +1 for testing together.  If it doesn't work we can go into analysis.

Am 19. November 2017 00:01:35 MEZ schrieb Patricia Shanahan <[hidden email]>:

>I see you have checked in some Mac building changes. Would it be better
>
>to keep the two fixes separate, or encourage testing both of them
>together?
>
>On 11/18/2017 1:20 PM, Jim Jagielski wrote:
>> We do have the AOO415 branch! :)
>>
>>> On Nov 18, 2017, at 2:11 PM, Patricia Shanahan <[hidden email]> wrote:
>>>
>>> There is a bug in my LinkManager changes. Specifically, I made the
>totally newbie mistake of accessing memory based on a pointer without
>allowing for it being null, and it turns out it can be null :-(
>>>
>>> The primary report for this is
>https://bz.apache.org/ooo/show_bug.cgi?id=127581, "Writer crashes after
>copying all content".
>>>
>>> I would have expected the failure to be some form of access
>violation. However, recent e-mails have convinced me that some paths
>include catch blocks that conceal all exceptions, so it may be the root
>cause of other problems.
>>>
>>> I have checked a fix into the trunk, revision 1814994. However,
>trunk has other changes.
>>>
>>> The simplest way to check whether other bug reports are due to this
>is to build a version that is identical to 4.1.4 except for the one
>fix. Anything that works with that but not with 4.1.4 is a duplicate.
>Of course, the more duplicates we have the worse the problem and the
>more urgent a fix.
>>>
>>> I am going ahead and doing the fix in my 4.1.5 working copy, but
>activating 4.1.5 is a broader decision.
>>>
>>>
>>>
>---------------------------------------------------------------------
>>> To unsubscribe, e-mail: [hidden email]
>>> For additional commands, e-mail: [hidden email]
>>>
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: [hidden email]
>> For additional commands, e-mail: [hidden email]
>>
>
>---------------------------------------------------------------------
>To unsubscribe, e-mail: [hidden email]
>For additional commands, e-mail: [hidden email]

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: URGENT: Need to build new version based on 4.1.4

Jim Jagielski
In reply to this post by Patricia Shanahan
I think together is best. :)

> On Nov 18, 2017, at 6:01 PM, Patricia Shanahan <[hidden email]> wrote:
>
> I see you have checked in some Mac building changes. Would it be better to keep the two fixes separate, or encourage testing both of them together?
>
> On 11/18/2017 1:20 PM, Jim Jagielski wrote:
>> We do have the AOO415 branch! :)
>>> On Nov 18, 2017, at 2:11 PM, Patricia Shanahan <[hidden email]> wrote:
>>>
>>> There is a bug in my LinkManager changes. Specifically, I made the totally newbie mistake of accessing memory based on a pointer without allowing for it being null, and it turns out it can be null :-(
>>>
>>> The primary report for this is https://bz.apache.org/ooo/show_bug.cgi?id=127581, "Writer crashes after copying all content".
>>>
>>> I would have expected the failure to be some form of access violation. However, recent e-mails have convinced me that some paths include catch blocks that conceal all exceptions, so it may be the root cause of other problems.
>>>
>>> I have checked a fix into the trunk, revision 1814994. However, trunk has other changes.
>>>
>>> The simplest way to check whether other bug reports are due to this is to build a version that is identical to 4.1.4 except for the one fix. Anything that works with that but not with 4.1.4 is a duplicate. Of course, the more duplicates we have the worse the problem and the more urgent a fix.
>>>
>>> I am going ahead and doing the fix in my 4.1.5 working copy, but activating 4.1.5 is a broader decision.
>>>
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: [hidden email]
>>> For additional commands, e-mail: [hidden email]
>>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: [hidden email]
>> For additional commands, e-mail: [hidden email]
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [hidden email]
> For additional commands, e-mail: [hidden email]
>


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: URGENT: Need to build new version based on 4.1.4

Jim Jagielski
In reply to this post by Patricia Shanahan
Just to be clear:

    SetUserAllowsLinkUpdate(pLink, GetUserAllowsLinkUpdate(parent));

is OK if parent == NULL? That is, does GetUserAllowsLinkUpdate()
work OK if passed NULL? Or, if parent is NULL, should we skip
calling SetUserAllowsLinkUpdate()?

> On Nov 18, 2017, at 3:49 PM, Patricia Shanahan <[hidden email]> wrote:
>
> I'm attaching the patch in case anyone else wants to build their own test version.
>
> On 11/18/2017 11:11 AM, Patricia Shanahan wrote:
>> There is a bug in my LinkManager changes. Specifically, I made the totally newbie mistake of accessing memory based on a pointer without allowing for it being null, and it turns out it can be null :-(
>> The primary report for this is https://bz.apache.org/ooo/show_bug.cgi?id=127581, "Writer crashes after copying all content".
>> I would have expected the failure to be some form of access violation. However, recent e-mails have convinced me that some paths include catch blocks that conceal all exceptions, so it may be the root cause of other problems.
>> I have checked a fix into the trunk, revision 1814994. However, trunk has other changes.
>> The simplest way to check whether other bug reports are due to this is to build a version that is identical to 4.1.4 except for the one fix. Anything that works with that but not with 4.1.4 is a duplicate. Of course, the more duplicates we have the worse the problem and the more urgent a fix.
>> I am going ahead and doing the fix in my 4.1.5 working copy, but activating 4.1.5 is a broader decision.
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: [hidden email]
>> For additional commands, e-mail: [hidden email]
> <null_pointer.patch>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [hidden email]
> For additional commands, e-mail: [hidden email]


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: URGENT: Need to build new version based on 4.1.4

Patricia Shanahan
The null check inside the mAutoAskUpdateAllLinks test is something of an
over-reaction on my part, in the direction of defensive programming.
mAutoAskUpdateAllLinks is only true in two specific cases, both of which
I have reviewed. The bug was doing the parent look-up outside that if block.

I have tested forcing the parent to null in a debugger. It does not
crash. I suspect it would not necessarily pick the right parent window
if multiple windows are open.



On 11/19/2017 7:11 AM, Jim Jagielski wrote:

> Just to be clear:
>
>      SetUserAllowsLinkUpdate(pLink, GetUserAllowsLinkUpdate(parent));
>
> is OK if parent == NULL? That is, does GetUserAllowsLinkUpdate()
> work OK if passed NULL? Or, if parent is NULL, should we skip
> calling SetUserAllowsLinkUpdate()?
>
>> On Nov 18, 2017, at 3:49 PM, Patricia Shanahan <[hidden email]> wrote:
>>
>> I'm attaching the patch in case anyone else wants to build their own test version.
>>
>> On 11/18/2017 11:11 AM, Patricia Shanahan wrote:
>>> There is a bug in my LinkManager changes. Specifically, I made the totally newbie mistake of accessing memory based on a pointer without allowing for it being null, and it turns out it can be null :-(
>>> The primary report for this is https://bz.apache.org/ooo/show_bug.cgi?id=127581, "Writer crashes after copying all content".
>>> I would have expected the failure to be some form of access violation. However, recent e-mails have convinced me that some paths include catch blocks that conceal all exceptions, so it may be the root cause of other problems.
>>> I have checked a fix into the trunk, revision 1814994. However, trunk has other changes.
>>> The simplest way to check whether other bug reports are due to this is to build a version that is identical to 4.1.4 except for the one fix. Anything that works with that but not with 4.1.4 is a duplicate. Of course, the more duplicates we have the worse the problem and the more urgent a fix.
>>> I am going ahead and doing the fix in my 4.1.5 working copy, but activating 4.1.5 is a broader decision.
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: [hidden email]
>>> For additional commands, e-mail: [hidden email]
>> <null_pointer.patch>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: [hidden email]
>> For additional commands, e-mail: [hidden email]
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [hidden email]
> For additional commands, e-mail: [hidden email]
>

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: URGENT: Need to build new version based on 4.1.4

Patricia Shanahan
Jim,

I am going to be away from computers for most of the day. If you have
everything you want tested in 4.1.5 checked in, I would like you to
trigger a request for general testing.

In particular, anyone who is working a bug report that is a regression
between 4.1.3 and 4.1.4 should test it with the 4.1.5 branch, regardless
of the symptoms.

Originally, I expected my null point bug to manifest as an access
violation, as is the case for the original report. I was monitoring
bugzilla for any similar reports. From dev@ discussion, I have learned
there are instances of catching and hiding all exceptions. That means
data structures could be left in an inconsistent state without AOO
crashing or the access violation being reported, and almost any symptom
could result.

On 11/19/2017 7:21 AM, Patricia Shanahan wrote:

> The null check inside the mAutoAskUpdateAllLinks test is something of an
> over-reaction on my part, in the direction of defensive programming.
> mAutoAskUpdateAllLinks is only true in two specific cases, both of which
> I have reviewed. The bug was doing the parent look-up outside that if
> block.
>
> I have tested forcing the parent to null in a debugger. It does not
> crash. I suspect it would not necessarily pick the right parent window
> if multiple windows are open.
>
>
>
> On 11/19/2017 7:11 AM, Jim Jagielski wrote:
>> Just to be clear:
>>
>>      SetUserAllowsLinkUpdate(pLink, GetUserAllowsLinkUpdate(parent));
>>
>> is OK if parent == NULL? That is, does GetUserAllowsLinkUpdate()
>> work OK if passed NULL? Or, if parent is NULL, should we skip
>> calling SetUserAllowsLinkUpdate()?
>>
>>> On Nov 18, 2017, at 3:49 PM, Patricia Shanahan <[hidden email]> wrote:
>>>
>>> I'm attaching the patch in case anyone else wants to build their own
>>> test version.
>>>
>>> On 11/18/2017 11:11 AM, Patricia Shanahan wrote:
>>>> There is a bug in my LinkManager changes. Specifically, I made the
>>>> totally newbie mistake of accessing memory based on a pointer
>>>> without allowing for it being null, and it turns out it can be null :-(
>>>> The primary report for this is
>>>> https://bz.apache.org/ooo/show_bug.cgi?id=127581, "Writer crashes
>>>> after copying all content".
>>>> I would have expected the failure to be some form of access
>>>> violation. However, recent e-mails have convinced me that some paths
>>>> include catch blocks that conceal all exceptions, so it may be the
>>>> root cause of other problems.
>>>> I have checked a fix into the trunk, revision 1814994. However,
>>>> trunk has other changes.
>>>> The simplest way to check whether other bug reports are due to this
>>>> is to build a version that is identical to 4.1.4 except for the one
>>>> fix. Anything that works with that but not with 4.1.4 is a
>>>> duplicate. Of course, the more duplicates we have the worse the
>>>> problem and the more urgent a fix.
>>>> I am going ahead and doing the fix in my 4.1.5 working copy, but
>>>> activating 4.1.5 is a broader decision.
>>>> ---------------------------------------------------------------------
>>>> To unsubscribe, e-mail: [hidden email]
>>>> For additional commands, e-mail: [hidden email]
>>> <null_pointer.patch>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: [hidden email]
>>> For additional commands, e-mail: [hidden email]
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: [hidden email]
>> For additional commands, e-mail: [hidden email]
>>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [hidden email]
> For additional commands, e-mail: [hidden email]
>

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: URGENT: Need to build new version based on 4.1.4

Jim Jagielski
I think I will spend some time creating some 4.1.5-dev builds for people to
play with...

> On Nov 19, 2017, at 10:40 AM, Patricia Shanahan <[hidden email]> wrote:
>
> Jim,
>
> I am going to be away from computers for most of the day. If you have everything you want tested in 4.1.5 checked in, I would like you to trigger a request for general testing.
>
> In particular, anyone who is working a bug report that is a regression between 4.1.3 and 4.1.4 should test it with the 4.1.5 branch, regardless of the symptoms.
>
> Originally, I expected my null point bug to manifest as an access violation, as is the case for the original report. I was monitoring bugzilla for any similar reports. From dev@ discussion, I have learned there are instances of catching and hiding all exceptions. That means data structures could be left in an inconsistent state without AOO crashing or the access violation being reported, and almost any symptom could result.
>
> On 11/19/2017 7:21 AM, Patricia Shanahan wrote:
>> The null check inside the mAutoAskUpdateAllLinks test is something of an over-reaction on my part, in the direction of defensive programming. mAutoAskUpdateAllLinks is only true in two specific cases, both of which I have reviewed. The bug was doing the parent look-up outside that if block.
>> I have tested forcing the parent to null in a debugger. It does not crash. I suspect it would not necessarily pick the right parent window if multiple windows are open.
>> On 11/19/2017 7:11 AM, Jim Jagielski wrote:
>>> Just to be clear:
>>>
>>>      SetUserAllowsLinkUpdate(pLink, GetUserAllowsLinkUpdate(parent));
>>>
>>> is OK if parent == NULL? That is, does GetUserAllowsLinkUpdate()
>>> work OK if passed NULL? Or, if parent is NULL, should we skip
>>> calling SetUserAllowsLinkUpdate()?
>>>
>>>> On Nov 18, 2017, at 3:49 PM, Patricia Shanahan <[hidden email]> wrote:
>>>>
>>>> I'm attaching the patch in case anyone else wants to build their own test version.
>>>>
>>>> On 11/18/2017 11:11 AM, Patricia Shanahan wrote:
>>>>> There is a bug in my LinkManager changes. Specifically, I made the totally newbie mistake of accessing memory based on a pointer without allowing for it being null, and it turns out it can be null :-(
>>>>> The primary report for this is https://bz.apache.org/ooo/show_bug.cgi?id=127581, "Writer crashes after copying all content".
>>>>> I would have expected the failure to be some form of access violation. However, recent e-mails have convinced me that some paths include catch blocks that conceal all exceptions, so it may be the root cause of other problems.
>>>>> I have checked a fix into the trunk, revision 1814994. However, trunk has other changes.
>>>>> The simplest way to check whether other bug reports are due to this is to build a version that is identical to 4.1.4 except for the one fix. Anything that works with that but not with 4.1.4 is a duplicate. Of course, the more duplicates we have the worse the problem and the more urgent a fix.
>>>>> I am going ahead and doing the fix in my 4.1.5 working copy, but activating 4.1.5 is a broader decision.
>>>>> ---------------------------------------------------------------------
>>>>> To unsubscribe, e-mail: [hidden email]
>>>>> For additional commands, e-mail: [hidden email]
>>>> <null_pointer.patch>
>>>> ---------------------------------------------------------------------
>>>> To unsubscribe, e-mail: [hidden email]
>>>> For additional commands, e-mail: [hidden email]
>>>
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: [hidden email]
>>> For additional commands, e-mail: [hidden email]
>>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: [hidden email]
>> For additional commands, e-mail: [hidden email]
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [hidden email]
> For additional commands, e-mail: [hidden email]
>


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: URGENT: Need to build new version based on 4.1.4

Kay Schenk-2
On Sun, Nov 19, 2017 at 8:08 AM, Jim Jagielski <[hidden email]> wrote:

> I think I will spend some time creating some 4.1.5-dev builds for people to
> play with...
>
> > On Nov 19, 2017, at 10:40 AM, Patricia Shanahan <[hidden email]> wrote:
> >
> > Jim,
>

​That would be great. :)

>
> > I am going to be away from computers for most of the day. If you have
> everything you want tested in 4.1.5 checked in, I would like you to trigger
> a request for general testing.
> >
> > In particular, anyone who is working a bug report that is a regression
> between 4.1.3 and 4.1.4 should test it with the 4.1.5 branch, regardless of
> the symptoms.
> >
> > Originally, I expected my null point bug to manifest as an access
> violation, as is the case for the original report. I was monitoring
> bugzilla for any similar reports. From dev@ discussion, I have learned
> there are instances of catching and hiding all exceptions. That means data
> structures could be left in an inconsistent state without AOO crashing or
> the access violation being reported, and almost any symptom could result.
> >
> > On 11/19/2017 7:21 AM, Patricia Shanahan wrote:
> >> The null check inside the mAutoAskUpdateAllLinks test is something of
> an over-reaction on my part, in the direction of defensive programming.
> mAutoAskUpdateAllLinks is only true in two specific cases, both of which I
> have reviewed. The bug was doing the parent look-up outside that if block.
> >> I have tested forcing the parent to null in a debugger. It does not
> crash. I suspect it would not necessarily pick the right parent window if
> multiple windows are open.
> >> On 11/19/2017 7:11 AM, Jim Jagielski wrote:
> >>> Just to be clear:
> >>>
> >>>      SetUserAllowsLinkUpdate(pLink, GetUserAllowsLinkUpdate(parent));
> >>>
> >>> is OK if parent == NULL? That is, does GetUserAllowsLinkUpdate()
> >>> work OK if passed NULL? Or, if parent is NULL, should we skip
> >>> calling SetUserAllowsLinkUpdate()?
> >>>
> >>>> On Nov 18, 2017, at 3:49 PM, Patricia Shanahan <[hidden email]> wrote:
> >>>>
> >>>> I'm attaching the patch in case anyone else wants to build their own
> test version.
> >>>>
> >>>> On 11/18/2017 11:11 AM, Patricia Shanahan wrote:
> >>>>> There is a bug in my LinkManager changes. Specifically, I made the
> totally newbie mistake of accessing memory based on a pointer without
> allowing for it being null, and it turns out it can be null :-(
> >>>>> The primary report for this is https://bz.apache.org/ooo/
> show_bug.cgi?id=127581, "Writer crashes after copying all content".
> >>>>> I would have expected the failure to be some form of access
> violation. However, recent e-mails have convinced me that some paths
> include catch blocks that conceal all exceptions, so it may be the root
> cause of other problems.
> >>>>> I have checked a fix into the trunk, revision 1814994. However,
> trunk has other changes.
> >>>>> The simplest way to check whether other bug reports are due to this
> is to build a version that is identical to 4.1.4 except for the one fix.
> Anything that works with that but not with 4.1.4 is a duplicate. Of course,
> the more duplicates we have the worse the problem and the more urgent a fix.
> >>>>> I am going ahead and doing the fix in my 4.1.5 working copy, but
> activating 4.1.5 is a broader decision.
> >>>>> ------------------------------------------------------------
> ---------
> >>>>> To unsubscribe, e-mail: [hidden email]
> >>>>> For additional commands, e-mail: [hidden email]
> >>>> <null_pointer.patch>
> >>>> ---------------------------------------------------------------------
> >>>> To unsubscribe, e-mail: [hidden email]
> >>>> For additional commands, e-mail: [hidden email]
> >>>
> >>>
> >>> ---------------------------------------------------------------------
> >>> To unsubscribe, e-mail: [hidden email]
> >>> For additional commands, e-mail: [hidden email]
> >>>
> >> ---------------------------------------------------------------------
> >> To unsubscribe, e-mail: [hidden email]
> >> For additional commands, e-mail: [hidden email]
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: [hidden email]
> > For additional commands, e-mail: [hidden email]
> >
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [hidden email]
> For additional commands, e-mail: [hidden email]
>
>


--
----------------------------------------------------------------------
MzK

"Only the truth will save you now."
                         -- Ensei Tankado, "Digital Fortress"
Reply | Threaded
Open this post in threaded view
|

Re: URGENT: Need to build new version based on 4.1.4

Patricia Shanahan
In reply to this post by Patricia Shanahan
Now that I have a bit more time, I wanted to thank Jim for raising the
question. I really want people to review my code and question anything
that seems dubious.

On 11/19/2017 7:21 AM, Patricia Shanahan wrote:

> The null check inside the mAutoAskUpdateAllLinks test is something of an
> over-reaction on my part, in the direction of defensive programming.
> mAutoAskUpdateAllLinks is only true in two specific cases, both of which
> I have reviewed. The bug was doing the parent look-up outside that if
> block.
>
> I have tested forcing the parent to null in a debugger. It does not
> crash. I suspect it would not necessarily pick the right parent window
> if multiple windows are open.
>
>
>
> On 11/19/2017 7:11 AM, Jim Jagielski wrote:
>> Just to be clear:
>>
>>      SetUserAllowsLinkUpdate(pLink, GetUserAllowsLinkUpdate(parent));
>>
>> is OK if parent == NULL? That is, does GetUserAllowsLinkUpdate()
>> work OK if passed NULL? Or, if parent is NULL, should we skip
>> calling SetUserAllowsLinkUpdate()?
>>
>>> On Nov 18, 2017, at 3:49 PM, Patricia Shanahan <[hidden email]> wrote:
>>>
>>> I'm attaching the patch in case anyone else wants to build their own
>>> test version.
>>>
>>> On 11/18/2017 11:11 AM, Patricia Shanahan wrote:
>>>> There is a bug in my LinkManager changes. Specifically, I made the
>>>> totally newbie mistake of accessing memory based on a pointer
>>>> without allowing for it being null, and it turns out it can be null :-(
>>>> The primary report for this is
>>>> https://bz.apache.org/ooo/show_bug.cgi?id=127581, "Writer crashes
>>>> after copying all content".
>>>> I would have expected the failure to be some form of access
>>>> violation. However, recent e-mails have convinced me that some paths
>>>> include catch blocks that conceal all exceptions, so it may be the
>>>> root cause of other problems.
>>>> I have checked a fix into the trunk, revision 1814994. However,
>>>> trunk has other changes.
>>>> The simplest way to check whether other bug reports are due to this
>>>> is to build a version that is identical to 4.1.4 except for the one
>>>> fix. Anything that works with that but not with 4.1.4 is a
>>>> duplicate. Of course, the more duplicates we have the worse the
>>>> problem and the more urgent a fix.
>>>> I am going ahead and doing the fix in my 4.1.5 working copy, but
>>>> activating 4.1.5 is a broader decision.
>>>> ---------------------------------------------------------------------
>>>> To unsubscribe, e-mail: [hidden email]
>>>> For additional commands, e-mail: [hidden email]
>>> <null_pointer.patch>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: [hidden email]
>>> For additional commands, e-mail: [hidden email]
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: [hidden email]
>> For additional commands, e-mail: [hidden email]
>>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [hidden email]
> For additional commands, e-mail: [hidden email]
>

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: URGENT: Need to build new version based on 4.1.4

Matthias Seidel
In reply to this post by Jim Jagielski
Hi Jim,

I saw that you updated the metadata for 4.1.5.

One file is still missing, see:
https://bz.apache.org/ooo/show_bug.cgi?id=127552#c2

Regards, Matthias


Am 18.11.2017 um 22:20 schrieb Jim Jagielski:

> We do have the AOO415 branch! :)
>
>> On Nov 18, 2017, at 2:11 PM, Patricia Shanahan <[hidden email]> wrote:
>>
>> There is a bug in my LinkManager changes. Specifically, I made the totally newbie mistake of accessing memory based on a pointer without allowing for it being null, and it turns out it can be null :-(
>>
>> The primary report for this is https://bz.apache.org/ooo/show_bug.cgi?id=127581, "Writer crashes after copying all content".
>>
>> I would have expected the failure to be some form of access violation. However, recent e-mails have convinced me that some paths include catch blocks that conceal all exceptions, so it may be the root cause of other problems.
>>
>> I have checked a fix into the trunk, revision 1814994. However, trunk has other changes.
>>
>> The simplest way to check whether other bug reports are due to this is to build a version that is identical to 4.1.4 except for the one fix. Anything that works with that but not with 4.1.4 is a duplicate. Of course, the more duplicates we have the worse the problem and the more urgent a fix.
>>
>> I am going ahead and doing the fix in my 4.1.5 working copy, but activating 4.1.5 is a broader decision.
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: [hidden email]
>> For additional commands, e-mail: [hidden email]
>>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [hidden email]
> For additional commands, e-mail: [hidden email]
>
>


smime.p7s (5K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

AOO 4.1.5-dev builds

Jim Jagielski
I have both macOS and Linux-64bit builds of 4.1.5-dev (HEAD on the
AOO415 branch) available for fun and games (and testing) at:

    http://home.apache.org/~jim/AOO-builds/

I've built all langs but have just uploaded: de, en-US, es, fr
and ja (for now). Let me know if people want/need others
uploaded.

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: AOO 4.1.5-dev builds

Rory O'Farrell
On Mon, 20 Nov 2017 10:49:24 -0500
Jim Jagielski <[hidden email]> wrote:

> I have both macOS and Linux-64bit builds of 4.1.5-dev (HEAD on the
> AOO415 branch) available for fun and games (and testing) at:
>
>     http://home.apache.org/~jim/AOO-builds/
>
> I've built all langs but have just uploaded: de, en-US, es, fr
> and ja (for now). Let me know if people want/need others
> uploaded.
>
I'm getting "No permission message" when I attempt to access http://home.apache.org/~jim/AOO-builds/AOO-4.1.5-dev-20171120/en-US/Apache_OpenOffice_4.1.5_Linux_x86-64_install-deb_en-US.tar.gz

I don't use many of the features of OO - merely Writer, simple (trivial) Calc, and occasional Impress, but I will try 4.1.5 for my daily use.

--
Rory O'Farrell <[hidden email]>

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: AOO 4.1.5-dev builds

Jim Jagielski
Permissions should be fixed now. Thx. and Sorry :)

> On Nov 20, 2017, at 11:01 AM, Rory O'Farrell <[hidden email]> wrote:
>
> On Mon, 20 Nov 2017 10:49:24 -0500
> Jim Jagielski <[hidden email]> wrote:
>
>> I have both macOS and Linux-64bit builds of 4.1.5-dev (HEAD on the
>> AOO415 branch) available for fun and games (and testing) at:
>>
>>    http://home.apache.org/~jim/AOO-builds/
>>
>> I've built all langs but have just uploaded: de, en-US, es, fr
>> and ja (for now). Let me know if people want/need others
>> uploaded.
>>
> I'm getting "No permission message" when I attempt to access http://home.apache.org/~jim/AOO-builds/AOO-4.1.5-dev-20171120/en-US/Apache_OpenOffice_4.1.5_Linux_x86-64_install-deb_en-US.tar.gz
>
> I don't use many of the features of OO - merely Writer, simple (trivial) Calc, and occasional Impress, but I will try 4.1.5 for my daily use.
>
> --
> Rory O'Farrell <[hidden email]>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [hidden email]
> For additional commands, e-mail: [hidden email]
>


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: AOO 4.1.5-dev builds

Rory O'Farrell
On Mon, 20 Nov 2017 11:07:49 -0500
Jim Jagielski <[hidden email]> wrote:

> Permissions should be fixed now. Thx. and Sorry :)

Thanks, downloading now.

Rory


>
> > On Nov 20, 2017, at 11:01 AM, Rory O'Farrell <[hidden email]> wrote:
> >
> > On Mon, 20 Nov 2017 10:49:24 -0500
> > Jim Jagielski <[hidden email]> wrote:
> >
> >> I have both macOS and Linux-64bit builds of 4.1.5-dev (HEAD on the
> >> AOO415 branch) available for fun and games (and testing) at:
> >>
> >>    http://home.apache.org/~jim/AOO-builds/
> >>
> >> I've built all langs but have just uploaded: de, en-US, es, fr
> >> and ja (for now). Let me know if people want/need others
> >> uploaded.
> >>
> > I'm getting "No permission message" when I attempt to access http://home.apache.org/~jim/AOO-builds/AOO-4.1.5-dev-20171120/en-US/Apache_OpenOffice_4.1.5_Linux_x86-64_install-deb_en-US.tar.gz
> >
> > I don't use many of the features of OO - merely Writer, simple (trivial) Calc, and occasional Impress, but I will try 4.1.5 for my daily use.
> >
> > --
> > Rory O'Farrell <[hidden email]>
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: [hidden email]
> > For additional commands, e-mail: [hidden email]
> >
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [hidden email]
> For additional commands, e-mail: [hidden email]
>
>


--
Rory O'Farrell <[hidden email]>

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: AOO 4.1.5-dev builds

Rory O'Farrell
On Mon, 20 Nov 2017 16:14:53 +0000
Rory O'Farrell <[hidden email]> wrote:

> On Mon, 20 Nov 2017 11:07:49 -0500
> Jim Jagielski <[hidden email]> wrote:
>
> > Permissions should be fixed now. Thx. and Sorry :)
>
> Thanks, downloading now.
>
> Rory

Now installed, opened and running.

Rory


> >
> > > On Nov 20, 2017, at 11:01 AM, Rory O'Farrell <[hidden email]> wrote:
> > >
> > > On Mon, 20 Nov 2017 10:49:24 -0500
> > > Jim Jagielski <[hidden email]> wrote:
> > >
> > >> I have both macOS and Linux-64bit builds of 4.1.5-dev (HEAD on the
> > >> AOO415 branch) available for fun and games (and testing) at:
> > >>
> > >>    http://home.apache.org/~jim/AOO-builds/
> > >>
> > >> I've built all langs but have just uploaded: de, en-US, es, fr
> > >> and ja (for now). Let me know if people want/need others
> > >> uploaded.
> > >>
> > > I'm getting "No permission message" when I attempt to access http://home.apache.org/~jim/AOO-builds/AOO-4.1.5-dev-20171120/en-US/Apache_OpenOffice_4.1.5_Linux_x86-64_install-deb_en-US.tar.gz
> > >
> > > I don't use many of the features of OO - merely Writer, simple (trivial) Calc, and occasional Impress, but I will try 4.1.5 for my daily use.
> > >
> > > --
> > > Rory O'Farrell <[hidden email]>
> > >
> > > ---------------------------------------------------------------------
> > > To unsubscribe, e-mail: [hidden email]
> > > For additional commands, e-mail: [hidden email]
> > >
> >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: [hidden email]
> > For additional commands, e-mail: [hidden email]
> >
> >
>
>
> --
> Rory O'Farrell <[hidden email]>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [hidden email]
> For additional commands, e-mail: [hidden email]
>
>


--
Rory O'Farrell <[hidden email]>

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: AOO 4.1.5-dev builds

Larry Gusaas-4
In reply to this post by Jim Jagielski
Database & spreadsheet regressions fixed.
Larry

On 2017-11-20, 9:49 AM Jim Jagielski wrote:

> I have both macOS and Linux-64bit builds of 4.1.5-dev (HEAD on the
> AOO415 branch) available for fun and games (and testing) at:
>
>      http://home.apache.org/~jim/AOO-builds/
>
> I've built all langs but have just uploaded: de, en-US, es, fr
> and ja (for now). Let me know if people want/need others
> uploaded.
>
> __________
>


--
_________________________________

Larry I. Gusaas
Moose Jaw, Saskatchewan Canada
Website: http://larry-gusaas.com

"An artist is never ahead of his time but most people are far behind theirs." - Edgard Varese



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: AOO 4.1.5-dev builds

Dave Fisher
Hi -

Both regressions are fixed in the new build.

Also, it looks like all of the versioning has been changed correctly. At least on the about box and readme files.

I tried to test issue 127600 but I can’t understand what was done in the first place.

Regards,
Dave

> On Nov 20, 2017, at 10:18 AM, Larry Gusaas <[hidden email]> wrote:
>
> Database & spreadsheet regressions fixed.
> Larry
>
> On 2017-11-20, 9:49 AM Jim Jagielski wrote:
>> I have both macOS and Linux-64bit builds of 4.1.5-dev (HEAD on the
>> AOO415 branch) available for fun and games (and testing) at:
>>
>>     http://home.apache.org/~jim/AOO-builds/
>>
>> I've built all langs but have just uploaded: de, en-US, es, fr
>> and ja (for now). Let me know if people want/need others
>> uploaded.
>>
>> __________
>>
>
>
> --
> _________________________________
>
> Larry I. Gusaas
> Moose Jaw, Saskatchewan Canada
> Website: http://larry-gusaas.com
>
> "An artist is never ahead of his time but most people are far behind theirs." - Edgard Varese
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [hidden email]
> For additional commands, e-mail: [hidden email]
>


signature.asc (817 bytes) Download Attachment
1234