Versioning script

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

Versioning script

Ash Blade
Hi guys

I have been working on a script to help increase the version of OO in certain files before a release. Up until now this was done manually. I need your help in confirming some details before I finalize it.

I have a diff from 4.1.3 to 4.1.4 (https://svn.apache.org/viewvc?view=revision&revision=1765197) that I used as startup point to see how versioning numbers have evolved. I checked the files for all builds between 3.4.0 and 4.1.4.

My issue is this: the version is currently set up in the form of  x.x.x, but this is for service level I guess. For main release I saw that you sometimes have the form x.x. Is this going to be the rule also in the future or not? How will the version look like when you will reach 5.0? Will it be in the form 5.0.0 or 5.0? Some files where I found this difference were:
- /openoffice/branches/AOO413/main/sysui/desktop/productversion.mk
- /openoffice/branches/AOO413/main/solenv/bin/srcrelease.xml       
- /openoffice/branches/AOO413/main/odk/util/makefile.pmk        

Also, how are the rscrevision, build and lastminor variables set in /openoffice/branches/AOO413/main/solenv/inc/minor.mk? Are they done manually by someone or automatically every time you create a new build?

Thank you in advance

Ash


Sent from Mail for Windows 10

Reply | Threaded
Open this post in threaded view
|

Re: Versioning script

Andrea Pescetti-2
On 24/01/2018 Ash Blade wrote:
> I have been working on a script to help increase the version of OO in certain files before a release.

Thank you Ash! Noted in https://bz.apache.org/ooo/show_bug.cgi?id=127639

> My issue is this: the version is currently set up in the form of  x.x.x, but this is for service level I guess. For main release I saw that you sometimes have the form x.x. Is this going to be the rule also in the future or not?

Whatever we publish externally, internally we always keep the x.x.x form
(one digit each).

> How will the version look like when you will reach 5.0? Will it be in the form 5.0.0 or 5.0?

I guess there is nothing wrong if the script always assumes a 3-digit
number, i.e., 4.1.5, or 4.2.0, or 5.0.0. Then, if for some reason we
prefer to go with a shorter version like 4.2 or 5.0, then this can be
done manually after running the script, since it requires internal
agreement among developers. As far as the script is concerned, three
digits is the way to go.

> Also, how are the rscrevision, build and lastminor variables set in /openoffice/branches/AOO413/main/solenv/inc/minor.mk? Are they done manually by someone or automatically every time you create a new build?

They are done manually, with a simple increase without any special logic
behind it (e.g., the previous build was 9876, the next one is 9877).
This doesn't play well with branches. So ideally the script here should
increase by 1 by default, but also accept an explicit build number as an
argument.

Regards,
   Andrea.

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

RE: Versioning script

Ash Blade
Hi Andrea

Thanks for the info. I will take this into account and come back with the solution in a few days.

Thanks

Ash

Sent from Mail for Windows 10

From: Andrea Pescetti
Sent: Sunday, January 28, 2018 11:26 AM
To: [hidden email]
Cc: Ash Blade
Subject: Re: Versioning script

On 24/01/2018 Ash Blade wrote:
> I have been working on a script to help increase the version of OO in certain files before a release.

Thank you Ash! Noted in https://bz.apache.org/ooo/show_bug.cgi?id=127639

> My issue is this: the version is currently set up in the form of  x.x.x, but this is for service level I guess. For main release I saw that you sometimes have the form x.x. Is this going to be the rule also in the future or not?

Whatever we publish externally, internally we always keep the x.x.x form
(one digit each).

> How will the version look like when you will reach 5.0? Will it be in the form 5.0.0 or 5.0?

I guess there is nothing wrong if the script always assumes a 3-digit
number, i.e., 4.1.5, or 4.2.0, or 5.0.0. Then, if for some reason we
prefer to go with a shorter version like 4.2 or 5.0, then this can be
done manually after running the script, since it requires internal
agreement among developers. As far as the script is concerned, three
digits is the way to go.

> Also, how are the rscrevision, build and lastminor variables set in /openoffice/branches/AOO413/main/solenv/inc/minor.mk? Are they done manually by someone or automatically every time you create a new build?

They are done manually, with a simple increase without any special logic
behind it (e.g., the previous build was 9876, the next one is 9877).
This doesn't play well with branches. So ideally the script here should
increase by 1 by default, but also accept an explicit build number as an
argument.

Regards,
   Andrea.