i101937: useless errormessage when "exporting" template in organizer

classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

i101937: useless errormessage when "exporting" template in organizer

Zhang Xiaofei-6
Hi Mikhail,

Sorry for the delay. Thanks to your advice I have made a patch that seems to solve the issue. Please review it for me when you get time.
By the way, I have created i111034 according to the previous finds solving i40233, please have a look

Thanks and Best Regards,
Felix.

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]
Reply | Threaded
Open this post in threaded view
|

Re: i101937: useless errormessage when "exporting" template in organizer

Mikhail Voytenko
Hi Felix,

thank you for the patch. It looks good.
Did you test, whether it really fixes the original problem? It could be
that the InteractionHandler should be adjusted a little bit to handle
the triggered error as well.

Best regards,
Mikhail.

PS: It is good that you have added me in CC directly, since the mailing
list has removed the attached patch.

On 04/21/10 11:24, Zhang Xiaofei wrote:

> Hi Mikhail,
>
> Sorry for the delay. Thanks to your advice I have made a patch that
> seems to solve the issue. Please review it for me when you get time.
> By the way, I have created i111034 according to the previous finds
> solving i40233, please have a look
>
> Thanks and Best Regards,
> Felix.
> ------------------------------------------------------------------------
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [hidden email]
> For additional commands, e-mail: [hidden email]
>  

Reply | Threaded
Open this post in threaded view
|

Re: i101937: useless errormessage when "exporting" template in organizer

Zhang Xiaofei-6
Hi Mikhail,

Thanks very much for reminding me. I rechecked the patch and found an stupid
error in the implementation of filedlghelper.cxx that makes the program only
seems to behave right but introduces potential risk. I will continue to
adjust the wrapper. Please stay tuned for the next version of patch.

Thanks and Best Regards,
Felix.


On Thu, Apr 22, 2010 at 2:28 PM, Mikhail Voytenko
<[hidden email]>wrote:

> Hi Felix,
>
> thank you for the patch. It looks good.
> Did you test, whether it really fixes the original problem? It could be
> that the InteractionHandler should be adjusted a little bit to handle the
> triggered error as well.
>
> Best regards,
> Mikhail.
>
> PS: It is good that you have added me in CC directly, since the mailing
> list has removed the attached patch.
>
>
> On 04/21/10 11:24, Zhang Xiaofei wrote:
>
>> Hi Mikhail,
>>
>> Sorry for the delay. Thanks to your advice I have made a patch that seems
>> to solve the issue. Please review it for me when you get time.
>> By the way, I have created i111034 according to the previous finds solving
>> i40233, please have a look
>>
>> Thanks and Best Regards,
>> Felix.
>> ------------------------------------------------------------------------
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: [hidden email]
>> For additional commands, e-mail: [hidden email]
>>
>>
>
>
Reply | Threaded
Open this post in threaded view
|

Re: i101937: useless errormessage when "exporting" template in organizer

Zhang Xiaofei-6
Hi Mikhail,

I guess this modified patch should work. I have tested it myself. Please have a look.

Thanks and Best Regards,
Felix.

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]
Reply | Threaded
Open this post in threaded view
|

Re: i101937: useless errormessage when "exporting" template in organizer

Mikhail Voytenko
Hi Felix,

thank you for the patch, it looks good. Please attach it to the issue
and change the type of the issue to "patch".

Carsten has currently an issue in the list, for which he does not have
enough time. But it would be great if the issue could be solved before
OOo3.3.
So please take a look to the following issue to see, whether you are
interested in the task. We could discuss the details on the meeting
tomorrow.
http://qa.openoffice.org/issues/show_bug.cgi?id=90815

Best regards,
Mikhail.

On 04/23/10 11:35, Zhang Xiaofei wrote:

> Hi Mikhail,
>
> I guess this modified patch should work. I have tested it myself.
> Please have a look.
>
> Thanks and Best Regards,
> Felix.
> ------------------------------------------------------------------------
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [hidden email]
> For additional commands, e-mail: [hidden email]
>