info/CWStl77 : SfxPoolItem Create/Store function being removed

classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

info/CWStl77 : SfxPoolItem Create/Store function being removed

thomas.lange


          Type: info
         Title: SfxPoolItem Create/Store function being removed
     Posted by: [hidden email]
      Affected: all
         TaskId: i109099
<http://www.openoffice.org/issues/show_bug.cgi?id=109099>
Effective from: CWStl77 CWS SRX644/draw11,SRX645/draw11


*Summary*
--------
In SfxPoolItem and ist derived classes:
-    virtual SfxPoolItem*     Create(SvStream &, USHORT) const;
-    virtual SvStream&        Store(SvStream &, USHORT nItemVersion ) const;


*Description*
-------------
As from CWS tl77 the functions
-    virtual SfxPoolItem*     Create(SvStream &, USHORT) const;
-    virtual SvStream&        Store(SvStream &, USHORT nItemVersion )
const;
will be removed from SfxPoolItem and all its derived classes.

Wherever those functions are still in need non-virtual function named
+    SfxPoolItem*     CreateItem(SvStream &, USHORT) const;
+    SvStream&        StoreItem(SvStream &, USHORT nItemVersion ) const;
got introduced. (In the long run those should probably be eliminated
by the responsible engineers as well.)

Thus when you write new code please don't use them anymore. And if you
still have need for them please use functions like
CreateItem/StoreItem as listed above.

This change is part of getting rid of EditEngines binary clipboard
format and replacing it with a ODF based clipboard format.



Send feedback to [hidden email]



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]
Reply | Threaded
Open this post in threaded view
|

Re: info/CWStl77 : SfxPoolItem Create/Store function being removed

Thomas Lange - Oracle
Hi,


> *Summary*
> --------
> In SfxPoolItem and ist derived classes:
> -    virtual SfxPoolItem*     Create(SvStream &, USHORT) const;
> -    virtual SvStream&        Store(SvStream &, USHORT nItemVersion ) const;
>
>
> *Description*
> -------------
> As from CWS tl77 the functions
> -    virtual SfxPoolItem*     Create(SvStream &, USHORT) const;
> -    virtual SvStream&        Store(SvStream &, USHORT nItemVersion )
> const;
> will be removed from SfxPoolItem and all its derived classes.
>
> Wherever those functions are still in need non-virtual function named
> +    SfxPoolItem*     CreateItem(SvStream &, USHORT) const;
> +    SvStream&        StoreItem(SvStream &, USHORT nItemVersion ) const;
> got introduced. (In the long run those should probably be eliminated
> by the responsible engineers as well.)
>
> Thus when you write new code please don't use them anymore. And if you
> still have need for them please use functions like
> CreateItem/StoreItem as listed above.
>
> This change is part of getting rid of EditEngines binary clipboard
> format and replacing it with a ODF based clipboard format.
>


Removing Create/Store from SfxPoolItem and its derived classes also
resulted in some other methods in not from SfxPoolItem derived classes
to get removed as well. Those are:


EditEngineItemPool
editeng/source/editeng/editdoc.hxx
- virtual SvStream& Store( SvStream& rStream ) const;


BinTextObject
editeng/source/editeng/editobj2.hxx
- virtual void StoreData( SvStream& rOStream ) const;
- virtual void CreateData( SvStream& rIStream );
- void CreateData300( SvStream& rIStream );


SfxItemPool
svl/inc/svl/itempool.hxx
- const SfxPoolItem* LoadItem( SvStream &rStream,
-  FASTBOOL bDirect = FALSE,
-  const SfxItemPool *pRefPool = 0 );
- FASTBOOL StoreItem( SvStream &rStream,
-   const SfxPoolItem &rItem,
-   FASTBOOL bDirect = FALSE ) const;
- virtual SvStream & Load(SvStream &);
- virtual SvStream & Store(SvStream &) const;


SfxItemSet
svl/inc/svl/itemset.hxx
- virtual SvStream & Load( SvStream &, FASTBOOL bDirect ...
- virtual SvStream & Store( SvStream &, FASTBOOL bDirect ) const;


SfxStyleSheetBasePool
svl/inc/svl/style.hxx
- BOOL Load( SvStream& );
- BOOL Store( SvStream&, BOOL bUsed = TRUE );


Thomas



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]